Skip to content

Fix join game flow race condition (regression) #123

@norswap

Description

@norswap

There seems to be a regression whereas if both player send their drawInitialHand transaction at the same time there is a race condition (which is also not resolved by resending the transaction, though possible that's because of client-side caching of the drawn cards?).

This didn't used to be the case (I tested this explicitly).

In particular, I'm having an easy time triggering this by creating a game in browser 1 (firefox), joining with browser 2 (chrome) then immediately going back to browser 1 and joining too.

This was discovered while reviewing #107 (but mostly likely isn't the cause).

First order of business should be to figure out what introduced this regression. Could it be the contract refactor? Some more recent frontend changes, however unlikely?

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions