From bff535f0dc96b1c9e8566710052201a84f44cb0e Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 19:21:17 -0800 Subject: [PATCH 1/8] Create workflow for linting PRs --- .github/workflows/formatting-and-lint.yml | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/workflows/formatting-and-lint.yml diff --git a/.github/workflows/formatting-and-lint.yml b/.github/workflows/formatting-and-lint.yml new file mode 100644 index 00000000..69c0dae8 --- /dev/null +++ b/.github/workflows/formatting-and-lint.yml @@ -0,0 +1,23 @@ +name: Check formatting and lint + +on: + pull_request: + +jobs: + formatting-and-lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + + - uses: actions/setup-node@v3 + with: + node-version: 14 + + - name: Install Node.js dependencies + run: npm ci + + - name: Check formatting with Prettier + run: npx prettier -cu . + + - name: Lint with ESLint + run: npx eslint . From f0232afc61aca5fe8f8c258e962be5aca7c5a4fc Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 20:25:49 -0800 Subject: [PATCH 2/8] Log to console for debugging --- assets/chat/js/autocomplete.js | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index baffc0a0..da0de0cd 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -11,6 +11,7 @@ function getBucketId(id) { } function sortResults(a, b) { + console.log(a); if (!a || !b) return 0; // order emotes second From 9c4e350207b82a262fea2af7d6904ab757bc46cf Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 20:41:03 -0800 Subject: [PATCH 3/8] Log `b`, too --- assets/chat/js/autocomplete.js | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index da0de0cd..967f3585 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -12,6 +12,7 @@ function getBucketId(id) { function sortResults(a, b) { console.log(a); + console.log(b); if (!a || !b) return 0; // order emotes second From b042b295071e82535b00d9a07e627a9102584ec3 Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 20:46:59 -0800 Subject: [PATCH 4/8] Adjust indentation --- assets/chat/js/autocomplete.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index 967f3585..72f757fd 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -11,7 +11,7 @@ function getBucketId(id) { } function sortResults(a, b) { - console.log(a); + console.log(a); console.log(b); if (!a || !b) return 0; From 6f3bee717fa5d8785145e53f33fb298af553531d Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 21:11:34 -0800 Subject: [PATCH 5/8] Commit more sloppy indenting --- assets/chat/js/autocomplete.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index 72f757fd..9339a950 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -12,7 +12,7 @@ function getBucketId(id) { function sortResults(a, b) { console.log(a); - console.log(b); +console.log(b); if (!a || !b) return 0; // order emotes second From b75d32c996852e9426d4800ee93e66db8642833a Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 21:13:59 -0800 Subject: [PATCH 6/8] Try to log something that doesn't exist --- assets/chat/js/autocomplete.js | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index 9339a950..db252533 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -13,6 +13,7 @@ function getBucketId(id) { function sortResults(a, b) { console.log(a); console.log(b); +console.log(c); if (!a || !b) return 0; // order emotes second From f18b16bf8218f34ba69f1953d1b9455647d6847a Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Mon, 7 Nov 2022 23:50:27 -0800 Subject: [PATCH 7/8] Add another useless log statement --- assets/chat/js/autocomplete.js | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index db252533..443d6c8f 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -14,6 +14,7 @@ function sortResults(a, b) { console.log(a); console.log(b); console.log(c); +console.log(d); if (!a || !b) return 0; // order emotes second From 8b8fc8b9210265c66f00b51d2482e03f8f570c93 Mon Sep 17 00:00:00 2001 From: Farhad Jay Date: Tue, 8 Nov 2022 00:05:51 -0800 Subject: [PATCH 8/8] Remove bad logging --- assets/chat/js/autocomplete.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/assets/chat/js/autocomplete.js b/assets/chat/js/autocomplete.js index 443d6c8f..8e98f6b9 100644 --- a/assets/chat/js/autocomplete.js +++ b/assets/chat/js/autocomplete.js @@ -11,10 +11,10 @@ function getBucketId(id) { } function sortResults(a, b) { - console.log(a); -console.log(b); -console.log(c); -console.log(d); + // eslint-disable-next-line no-console + console.log(a); + // eslint-disable-next-line no-console + console.log(b); if (!a || !b) return 0; // order emotes second