Environment
- VS Code integrated terminal
- Turkish Q keyboard layout
- jcode TUI
Problem
Shifted symbols are reported as their base keys inside jcode.
For example, with a Turkish Q keyboard layout:
- Pressing Shift+7 currently produces
7
- It should produce
/
This is specific to enhanced keyboard input in the terminal environment.
Proposed fix
I prepared a focused change that enables:
KeyboardEnhancementFlags::REPORT_ALTERNATE_KEYS
while keeping:
KeyboardEnhancementFlags::REPORT_ALL_KEYS_AS_ESCAPE_CODES
disabled.
Prepared branch:
uzunenes/jcode:fix/vscode-shifted-symbol-input
Commit:
31e951d0c fix(tui): report alternate keys for shifted symbols
Verification
- Updated the existing keyboard enhancement flag test
- Ran the targeted
jcode-tui test
- Built the release version
- Manually verified in the VS Code integrated terminal
- Shift+7 now produces
/ with Turkish Q
Pull request restriction
I attempted to submit this as a pull request, but both GitHub CLI and
the web interface report that pull request creation is restricted to
repository collaborators:
An owner of this repository has limited the ability to open a pull
request to users that are collaborators on this repository.
Could you please do one of the following?
-
Temporarily allow external pull requests so I can submit the prepared PR
-
Add @uzunenes as a collaborator
-
Cherry-pick the prepared commit while preserving its author
-
If the implementation is rewritten, retain attribution with:
Co-authored-by: uzunenes 42443500+uzunenes@users.noreply.github.com
Cherry-pick reference:
git fetch https://github.com/uzunenes/jcode.git fix/vscode-shifted-symbol-input
git cherry-pick 31e951d
Environment
Problem
Shifted symbols are reported as their base keys inside jcode.
For example, with a Turkish Q keyboard layout:
7/This is specific to enhanced keyboard input in the terminal environment.
Proposed fix
I prepared a focused change that enables:
KeyboardEnhancementFlags::REPORT_ALTERNATE_KEYSwhile keeping:
KeyboardEnhancementFlags::REPORT_ALL_KEYS_AS_ESCAPE_CODESdisabled.
Prepared branch:
uzunenes/jcode:fix/vscode-shifted-symbol-inputCommit:
31e951d0c fix(tui): report alternate keys for shifted symbolsVerification
jcode-tuitest/with Turkish QPull request restriction
I attempted to submit this as a pull request, but both GitHub CLI and
the web interface report that pull request creation is restricted to
repository collaborators:
Could you please do one of the following?
Temporarily allow external pull requests so I can submit the prepared PR
Add
@uzunenesas a collaboratorCherry-pick the prepared commit while preserving its author
If the implementation is rewritten, retain attribution with:
Co-authored-by: uzunenes 42443500+uzunenes@users.noreply.github.com
Cherry-pick reference:
git fetch https://github.com/uzunenes/jcode.git fix/vscode-shifted-symbol-input
git cherry-pick 31e951d