From eb16ae6dd7b5b37fa9ac19c61e79edb30685c30d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?An=C4=B1l=20Akp=C4=B1nar?= <4ni1ak@gmail.com>
Date: Sat, 21 Mar 2026 12:53:41 +0300
Subject: [PATCH] fix: resolve all clippy warnings
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove unused PAM_AUTH_ERR constant and unused re-exports from pam/mod.rs
- Implement Default trait for FaceStore instead of inherent default() method
- Fix redundant closures: unwrap_or_else(|| fn()) → unwrap_or_else(fn)
- Fix doc comment style in camera_test.rs (/// → //! for crate-level docs)
---
 src/bin/camera_test.rs |  6 +++---
 src/bin/enroll.rs      |  2 +-
 src/bin/sim_test.rs    |  2 +-
 src/pam/constants.rs   |  1 -
 src/pam/mod.rs         |  3 ---
 src/storage/mod.rs     | 10 ++++++----
 6 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/bin/camera_test.rs b/src/bin/camera_test.rs
index d06b444..545082f 100644
--- a/src/bin/camera_test.rs
+++ b/src/bin/camera_test.rs
@@ -1,12 +1,12 @@
-/// camera-test — capture a frame from the IR camera and save it as PNG
-/// Usage: cargo run --bin camera-test [/dev/video2] [output.png]
+//! camera-test — capture a frame from the IR camera and save it as PNG
+//! Usage: cargo run --bin camera-test [/dev/video2] [output.png]
 
 fn main() {
     eprintln!("[camera-test] Starting...");
 
     let device_path = std::env::args()
         .nth(1)
-        .unwrap_or_else(|| pam_rustface::camera::auto_detect_ir_camera());
+        .unwrap_or_else(pam_rustface::camera::auto_detect_ir_camera);
     let output_path = std::env::args()
         .nth(2)
         .unwrap_or_else(|| "frame.png".to_owned());
diff --git a/src/bin/enroll.rs b/src/bin/enroll.rs
index c67ac24..6c547d9 100644
--- a/src/bin/enroll.rs
+++ b/src/bin/enroll.rs
@@ -76,7 +76,7 @@ fn main() {
     // Open camera — auto-detect IR camera if not specified
     let device = std::env::args()
         .nth(3)
-        .unwrap_or_else(|| pam_rustface::camera::auto_detect_ir_camera());
+        .unwrap_or_else(pam_rustface::camera::auto_detect_ir_camera);
     eprintln!("[enroll] Camera: {device}");
     let camera = IrCamera::open(&device).unwrap_or_else(|e| {
         eprintln!("[enroll] ERROR opening camera: {e}");
diff --git a/src/bin/sim_test.rs b/src/bin/sim_test.rs
index 1489e7d..76cd44f 100644
--- a/src/bin/sim_test.rs
+++ b/src/bin/sim_test.rs
@@ -35,7 +35,7 @@ fn main() {
 
     let device = std::env::args()
         .nth(2)
-        .unwrap_or_else(|| pam_rustface::camera::auto_detect_ir_camera());
+        .unwrap_or_else(pam_rustface::camera::auto_detect_ir_camera);
     eprintln!("[sim-test] Camera: {device}");
     let camera = IrCamera::open(&device).expect("Failed to open camera");
 
diff --git a/src/pam/constants.rs b/src/pam/constants.rs
index 49b7ff7..e806fb6 100644
--- a/src/pam/constants.rs
+++ b/src/pam/constants.rs
@@ -1,6 +1,5 @@
 use std::os::raw::c_int;
 
 pub const PAM_SUCCESS: c_int = 0;
-pub const PAM_AUTH_ERR: c_int = 7;
 pub const PAM_IGNORE: c_int = 25;
 pub const PAM_USER: c_int = 2;
diff --git a/src/pam/mod.rs b/src/pam/mod.rs
index 7fbbf40..76221ab 100644
--- a/src/pam/mod.rs
+++ b/src/pam/mod.rs
@@ -1,5 +1,2 @@
 pub mod constants;
 pub mod handle;
-
-pub use constants::{PAM_AUTH_ERR, PAM_IGNORE, PAM_SUCCESS};
-pub use handle::{get_username, PamHandle};
diff --git a/src/storage/mod.rs b/src/storage/mod.rs
index 72b2130..f860e26 100644
--- a/src/storage/mod.rs
+++ b/src/storage/mod.rs
@@ -20,10 +20,6 @@ impl FaceStore {
         }
     }
 
-    pub fn default() -> Self {
-        Self::new(FACES_DIR)
-    }
-
     fn user_path(&self, username: &str) -> PathBuf {
         self.base_path.join(format!("{username}.bin"))
     }
@@ -47,3 +43,9 @@ impl FaceStore {
         write::write_embedding(&path, embedding)
     }
 }
+
+impl Default for FaceStore {
+    fn default() -> Self {
+        Self::new(FACES_DIR)
+    }
+}