[refactor] refactor-language-download#11
Open
GabrielSousa02 wants to merge 14 commits into
Open
Conversation
Drop the `force` parameter. this is now handled within the download provider atomically.
Collaborator
Author
|
@holybiber Here's the refactor I've been working on to remove Tests are passing, and local emulators are working, download actually feels even faster at the moment. Would like to take a look and test it before I merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Create local download manager for languages and remove
download_assetspackage.language_downloaderfeaturearchivedependency and bump minor versionslanguage_downloaderutillanguage_downloaderinto globalslanguage_downloaderinto background_tasklanguage_downloaderinto mainbackground_testpubspecfiles to removedownload_assetslanguages.dartto use the newlanguage_downloaderupdate_language_buttonbackground_taskto use new provider setuplanguage_downloaderand providerdart fixWhy?
This removes an unnecessary dependency on the project, which makes it more reliable,
and less prone to update issues. Which was already happening with the latest version
of
download_assets.How?
Created custom download classes and functions that is able to fetch the two files per
language at the same time and unpack the zip in which they come, as per the current
setup of the application and content distribution.
Testing?
New testes were added, and all automated tests passing locally.
Screenshots (optional)
N/A
Anything Else?
N/A