[fix] fix-flutter-html-issues#6
Merged
Merged
Conversation
- Fix layout rendering errors - Improve layout - Improve components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix issues with layout generated for tables.
fvmrcto lock flutter version for developmentflutter_htmlWhy?
Our parsed tables were breaking and not rendering properly.
How?
Upgraded core dependencies and refactored the code to improve UI/UX.
Implemented horizontal scrolling, following common Flutter patterns.
Added a very light custom scroll bar to provide some visual information for
the user to be aware that there's a horizontal scroll in the first place.
Also corrected an error with rendering width with
%from html. Theflutter_htmllibrary does not parse the
%correctly, it parses it as rawpixels, fixedthat problem as well.
Testing?
Automated tests are all passing locally.
Screenshots (optional)
Anything Else?
It was detected that there is an ongoing issue, with the framework/library,
Here's the link which is related
to some issues we were having and was poluting the logs.
Therefore, a filter was added, since the excepctions were not breaking the app,
neither were they affecting build at all.
In the future this needs to be revisited and fixed, then remove the filter.