fix: correct bye resolution, slot assignment, and LB bye cascade

- seed_stage: fix bye marking bug using column names instead of stale
  local variables, restrict to WB path only
- advance_byes_for_tournament: mark bye brackets as finished so
  downstream resolve_bracket_bye knows no loser will arrive
- resolve_bracket_bye: replace total_feeders >= 2 guard with pending
  (unfinished) feeders check, allowing LB brackets to correctly
  resolve as byes when a WB feeder was a bye
- assign_team_to_bracket_slot: use deterministic slot assignment based
  on feeder ordering instead of first-empty-slot heuristic
- update_tournament_bracket: pass source bracket ID for correct slot

Author: Flegma

hasura/functions/tournaments/advance_byes_for_tournament.sql

@@ -46,6 +46,12 @@ BEGIN
             WHERE id = v_parent_bracket_id;
         END IF;
 
+        -- Mark the bye bracket as finished so downstream bye resolution
+        -- (e.g. LB R1 brackets) can detect that no loser will arrive
+        UPDATE tournament_brackets
+        SET finished = true
+        WHERE id = bracket.id;
+
         RAISE NOTICE '  Advanced team % from bracket % to parent %', winner_id, bracket.id, v_parent_bracket_id;
     END LOOP;
 

hasura/functions/tournaments/assign_team_to_bracket_slot.sql

@@ -1,11 +1,13 @@
 CREATE OR REPLACE FUNCTION public.assign_team_to_bracket_slot(
     _target_bracket_id uuid,
-    _team_id uuid
+    _team_id uuid,
+    _source_bracket_id uuid DEFAULT NULL
 ) RETURNS VOID
     LANGUAGE plpgsql
 AS $$
 DECLARE
     target_bracket tournament_brackets%ROWTYPE;
+    slot_position int;
 BEGIN
     SELECT * INTO target_bracket
     FROM tournament_brackets
@@ -16,14 +18,48 @@ BEGIN
         RETURN;
     END IF;
 
-    IF target_bracket.tournament_team_id_1 IS NULL THEN
+    -- Determine the correct slot from feeder ordering:
+    -- 1. Loser drops (loser_parent_bracket_id) come before winner feeds (parent_bracket_id)
+    -- 2. Within same type, order by round then match_number
+    -- This matches the bracket generation layout.
+    IF _source_bracket_id IS NOT NULL THEN
+        SELECT pos INTO slot_position
+        FROM (
+            SELECT f.id,
+                   row_number() OVER (
+                       ORDER BY
+                           CASE WHEN f.loser_parent_bracket_id = _target_bracket_id THEN 0 ELSE 1 END,
+                           f.round,
+                           f.match_number
+                   ) AS pos
+            FROM tournament_brackets f
+            WHERE f.parent_bracket_id = _target_bracket_id
+               OR f.loser_parent_bracket_id = _target_bracket_id
+        ) ranked
+        WHERE ranked.id = _source_bracket_id;
+    END IF;
+
+    IF slot_position = 1 THEN
         UPDATE tournament_brackets
         SET tournament_team_id_1 = _team_id
-        WHERE id = _target_bracket_id;
-    ELSIF target_bracket.tournament_team_id_2 IS NULL THEN
+        WHERE id = _target_bracket_id
+          AND tournament_team_id_1 IS NULL;
+    ELSIF slot_position = 2 THEN
         UPDATE tournament_brackets
         SET tournament_team_id_2 = _team_id
-        WHERE id = _target_bracket_id;
+        WHERE id = _target_bracket_id
+          AND tournament_team_id_2 IS NULL;
+    ELSE
+        -- Fallback: first empty slot (for callers without source bracket)
+        IF target_bracket.tournament_team_id_1 IS NULL THEN
+            UPDATE tournament_brackets
+            SET tournament_team_id_1 = _team_id
+            WHERE id = _target_bracket_id;
+        ELSIF target_bracket.tournament_team_id_2 IS NULL THEN
+            UPDATE tournament_brackets
+            SET tournament_team_id_2 = _team_id
+            WHERE id = _target_bracket_id;
+        END IF;
     END IF;
 END;
 $$;

hasura/functions/tournaments/resolve_bracket_bye.sql

@@ -11,7 +11,6 @@ CREATE OR REPLACE FUNCTION public.resolve_bracket_bye(
 AS $$
 DECLARE
     current_bracket tournament_brackets%ROWTYPE;
-    total_feeders int;
     pending_feeders int;
     lone_team_id uuid;
     tournament_id uuid;
@@ -38,25 +37,14 @@ BEGIN
         RETURN false;
     END IF;
 
-    -- A bracket with 2+ total feeders is designed to receive 2 teams through
-    -- normal match play (e.g. LB R1 fed by two WB R1 matches). It should
-    -- never be a bye — the second team will arrive when the other feeder finishes.
-    SELECT COUNT(*) INTO total_feeders
-    FROM tournament_brackets child
-    WHERE child.parent_bracket_id = current_bracket.id
-       OR child.loser_parent_bracket_id = current_bracket.id;
-
-    IF total_feeders >= 2 THEN
-        RETURN false;
-    END IF;
-
-    -- For brackets with 0-1 feeders, check if any are still pending
+    -- Check if any feeders can still provide a team.
+    -- A finished bye feeder via loser_parent_bracket_id will never send a loser,
+    -- so it doesn't count as pending. Only unfinished feeders are pending.
     SELECT COUNT(*) INTO pending_feeders
     FROM tournament_brackets child
     WHERE (child.parent_bracket_id = current_bracket.id
            OR child.loser_parent_bracket_id = current_bracket.id)
-      AND child.finished = false
-      AND child.bye = false;
+      AND child.finished = false;
 
     IF pending_feeders > 0 THEN
         RETURN false;
@@ -75,7 +63,7 @@ BEGIN
 
     -- Advance the lone team to the parent bracket
     IF current_bracket.parent_bracket_id IS NOT NULL THEN
-        PERFORM public.assign_team_to_bracket_slot(current_bracket.parent_bracket_id, lone_team_id);
+        PERFORM public.assign_team_to_bracket_slot(current_bracket.parent_bracket_id, lone_team_id, current_bracket.id);
     ELSE
         RAISE WARNING 'resolve_bracket_bye: bracket % has no parent, team % cannot advance',
             current_bracket.id, lone_team_id;

hasura/functions/tournaments/seed_stage.sql

@@ -166,8 +166,8 @@ BEGIN
                 team_2_seed_val, team_2_id;
         END LOOP;
 
-        update tournament_brackets set bye = (team_1_id IS NULL OR team_2_id IS NULL) 
-              where tournament_stage_id = stage.id and round = 1;
+        update tournament_brackets set bye = (tournament_team_id_1 IS NULL OR tournament_team_id_2 IS NULL)
+              where tournament_stage_id = stage.id and round = 1 and COALESCE(path, 'WB') = 'WB';
     END IF;
 
     IF stage.type != 'RoundRobin' THEN

hasura/functions/tournaments/update_tournament_bracket.sql

@@ -34,11 +34,11 @@ BEGIN
     WHERE id = bracket.id;
 
     IF bracket.parent_bracket_id IS NOT NULL THEN
-        PERFORM public.assign_team_to_bracket_slot(bracket.parent_bracket_id, winning_team_id);
+        PERFORM public.assign_team_to_bracket_slot(bracket.parent_bracket_id, winning_team_id, bracket.id);
     END IF;
 
     IF bracket.loser_parent_bracket_id IS NOT NULL THEN
-        PERFORM public.assign_team_to_bracket_slot(bracket.loser_parent_bracket_id, losing_team_id);
+        PERFORM public.assign_team_to_bracket_slot(bracket.loser_parent_bracket_id, losing_team_id, bracket.id);
     END IF;
 
     SELECT ts.tournament_id, ts.type INTO tournament_id, stage_type