bug: check if exists for trophy migrations (#158)

Author: lukepolo

hasura/functions/leaderboard/get_leaderboard.sql

@@ -358,7 +358,9 @@ BEGIN
       SUM(CASE WHEN tt.placement = 3 THEN 1 ELSE 0 END)::int as bronze,
       COUNT(*)::int as total
     FROM tournament_trophies tt
-    WHERE (_window_days = 0 OR tt.tournament_start >= NOW() - make_interval(days => _window_days))
+    JOIN tournaments t ON t.id = tt.tournament_id
+    WHERE tt.player_steam_id IS NOT NULL
+      AND (_window_days = 0 OR t.start >= NOW() - make_interval(days => _window_days))
     GROUP BY tt.player_steam_id
   )
   SELECT

hasura/migrations/default/1776430000000_add_tournament_trophies/up.sql

@@ -1,4 +1,4 @@
-CREATE TABLE public.tournament_trophies (
+CREATE TABLE IF NOT EXISTS public.tournament_trophies (
     id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
     tournament_id uuid NOT NULL REFERENCES public.tournaments(id) ON DELETE CASCADE,
     tournament_team_id uuid NOT NULL REFERENCES public.tournament_teams(id) ON DELETE CASCADE,
@@ -22,15 +22,15 @@ CREATE TABLE public.tournament_trophies (
     UNIQUE (tournament_id, tournament_team_id, player_steam_id)
 );
 
-CREATE INDEX idx_tournament_trophies_player
+CREATE INDEX IF NOT EXISTS idx_tournament_trophies_player
     ON public.tournament_trophies(player_steam_id, placement);
-CREATE INDEX idx_tournament_trophies_tournament
+CREATE INDEX IF NOT EXISTS idx_tournament_trophies_tournament
     ON public.tournament_trophies(tournament_id);
-CREATE UNIQUE INDEX tournament_trophies_one_mvp_per_tournament
+CREATE UNIQUE INDEX IF NOT EXISTS tournament_trophies_one_mvp_per_tournament
     ON public.tournament_trophies(tournament_id)
     WHERE placement = 0;
 
-CREATE TABLE public.tournament_trophy_configs (
+CREATE TABLE IF NOT EXISTS public.tournament_trophy_configs (
     id uuid PRIMARY KEY DEFAULT gen_random_uuid(),
     tournament_id uuid NOT NULL REFERENCES public.tournaments(id) ON DELETE CASCADE,
     placement int NOT NULL CHECK (placement IN (0, 1, 2, 3)),
@@ -42,5 +42,5 @@ CREATE TABLE public.tournament_trophy_configs (
     UNIQUE (tournament_id, placement)
 );
 
-CREATE INDEX idx_tournament_trophy_configs_tournament
+CREATE INDEX IF NOT EXISTS idx_tournament_trophy_configs_tournament
     ON public.tournament_trophy_configs(tournament_id);

hasura/migrations/default/1776430500000_tournament_trophies_unique_include_placement/down.sql

@@ -1,5 +1,5 @@
 ALTER TABLE public.tournament_trophies
-    DROP CONSTRAINT tournament_trophies_tournament_team_player_placement_key;
+    DROP CONSTRAINT IF EXISTS tournament_trophies_tournament_team_player_placement_key;
 
 ALTER TABLE public.tournament_trophies
     ADD CONSTRAINT tournament_trophies_tournament_id_tournament_team_id_player_key

hasura/migrations/default/1776430500000_tournament_trophies_unique_include_placement/up.sql

@@ -1,9 +1,41 @@
 -- Allow a player to hold both a placement trophy (gold/silver/bronze) and MVP
 -- on the same tournament. The old uniqueness key blocked the second insert
 -- when the MVP was on the winning team.
-ALTER TABLE public.tournament_trophies
-    DROP CONSTRAINT tournament_trophies_tournament_id_tournament_team_id_player_key;
+--
+-- Idempotent: the previous constraint's name is auto-generated by Postgres
+-- (inline UNIQUE in the original migration), and truncation varies by
+-- version / NAMEDATALEN, so look it up by column set. Also guard the new
+-- constraint so re-running is safe.
+DO $$
+DECLARE
+    v_conname text;
+BEGIN
+    SELECT c.conname
+    INTO v_conname
+    FROM pg_constraint c
+    WHERE c.conrelid = 'public.tournament_trophies'::regclass
+      AND c.contype = 'u'
+      AND (
+          SELECT array_agg(a.attname::text ORDER BY a.attname::text)
+          FROM unnest(c.conkey) AS k(attnum)
+          JOIN pg_attribute a
+            ON a.attrelid = c.conrelid AND a.attnum = k.attnum
+      ) = ARRAY['player_steam_id', 'tournament_id', 'tournament_team_id']::text[];
 
-ALTER TABLE public.tournament_trophies
-    ADD CONSTRAINT tournament_trophies_tournament_team_player_placement_key
-    UNIQUE (tournament_id, tournament_team_id, player_steam_id, placement);
+    IF v_conname IS NOT NULL THEN
+        EXECUTE 'ALTER TABLE public.tournament_trophies DROP CONSTRAINT ' || quote_ident(v_conname);
+    END IF;
+END $$;
+
+DO $$
+BEGIN
+    IF NOT EXISTS (
+        SELECT 1 FROM pg_constraint
+        WHERE conrelid = 'public.tournament_trophies'::regclass
+          AND conname = 'tournament_trophies_tournament_team_player_placement_key'
+    ) THEN
+        ALTER TABLE public.tournament_trophies
+            ADD CONSTRAINT tournament_trophies_tournament_team_player_placement_key
+            UNIQUE (tournament_id, tournament_team_id, player_steam_id, placement);
+    END IF;
+END $$;

hasura/migrations/default/1776431000000_add_player_elo_impact/up.sql

@@ -1,7 +1,7 @@
 -- In-match performance multiplier (0.8 - 1.2) driven by KDA-vs-team and damage share.
 -- Stored as a level metric independent of ELO swings so MVP and similar
 -- consumers can rank players without favoring those whose ELO moved most.
-ALTER TABLE public.player_elo ADD COLUMN impact numeric;
+ALTER TABLE public.player_elo ADD COLUMN IF NOT EXISTS impact numeric;
 
 -- Backfill from raw player_kills / player_assists / player_damages.
 -- Mirrors the pre-loss-transform formula in get_player_elo_for_match.

hasura/migrations/default/1776432000000_redesign_tournament_trophies/up.sql

@@ -1,28 +1,28 @@
 -- Per-tournament trophy toggle. Lets organizers skip / clear trophies
 -- on test or casual tournaments without affecting prior awards elsewhere.
 ALTER TABLE public.tournaments
-    ADD COLUMN trophies_enabled boolean NOT NULL DEFAULT true;
+    ADD COLUMN IF NOT EXISTS trophies_enabled boolean NOT NULL DEFAULT true;
 
 -- Drop the denormalized copies. Tournament metadata is read via the
 -- existing `tournament` relation; visuals come from tournament_trophy_configs
 -- through a new manual relationship on (tournament_id, placement).
 ALTER TABLE public.tournament_trophies
-    DROP COLUMN tournament_name,
-    DROP COLUMN tournament_start,
-    DROP COLUMN tournament_type,
-    DROP COLUMN custom_name,
-    DROP COLUMN silhouette,
-    DROP COLUMN image_url;
+    DROP COLUMN IF EXISTS tournament_name,
+    DROP COLUMN IF EXISTS tournament_start,
+    DROP COLUMN IF EXISTS tournament_type,
+    DROP COLUMN IF EXISTS custom_name,
+    DROP COLUMN IF EXISTS silhouette,
+    DROP COLUMN IF EXISTS image_url;
 
 -- Flag rows awarded outside the standard bracket calc (manual imports).
 ALTER TABLE public.tournament_trophies
-    ADD COLUMN manual boolean NOT NULL DEFAULT false;
+    ADD COLUMN IF NOT EXISTS manual boolean NOT NULL DEFAULT false;
 
 -- Tournament trophies can now be awarded to either a player or a real team.
 -- Team trophies are only created for tournament_teams rows that point at
 -- public.teams via tournament_teams.team_id.
 ALTER TABLE public.tournament_trophies
-    ADD COLUMN team_id uuid REFERENCES public.teams(id) ON DELETE CASCADE;
+    ADD COLUMN IF NOT EXISTS team_id uuid REFERENCES public.teams(id) ON DELETE CASCADE;
 
 ALTER TABLE public.tournament_trophies
     ALTER COLUMN player_steam_id DROP NOT NULL;
@@ -35,26 +35,44 @@ ALTER TABLE public.tournament_trophies
 
 DROP INDEX IF EXISTS public.tournament_trophies_tournament_team_player_placement_key;
 
-ALTER TABLE public.tournament_trophies
-    ADD CONSTRAINT tournament_trophies_one_recipient_check
-    CHECK (
-        (CASE WHEN player_steam_id IS NULL THEN 0 ELSE 1 END) +
-        (CASE WHEN team_id IS NULL THEN 0 ELSE 1 END) = 1
-    );
+DO $$
+BEGIN
+    IF NOT EXISTS (
+        SELECT 1 FROM pg_constraint
+        WHERE conrelid = 'public.tournament_trophies'::regclass
+          AND conname = 'tournament_trophies_one_recipient_check'
+    ) THEN
+        ALTER TABLE public.tournament_trophies
+            ADD CONSTRAINT tournament_trophies_one_recipient_check
+            CHECK (
+                (CASE WHEN player_steam_id IS NULL THEN 0 ELSE 1 END) +
+                (CASE WHEN team_id IS NULL THEN 0 ELSE 1 END) = 1
+            );
+    END IF;
+END $$;
 
-ALTER TABLE public.tournament_trophies
-    ADD CONSTRAINT tournament_trophies_mvp_requires_player_check
-    CHECK (placement <> 0 OR player_steam_id IS NOT NULL);
+DO $$
+BEGIN
+    IF NOT EXISTS (
+        SELECT 1 FROM pg_constraint
+        WHERE conrelid = 'public.tournament_trophies'::regclass
+          AND conname = 'tournament_trophies_mvp_requires_player_check'
+    ) THEN
+        ALTER TABLE public.tournament_trophies
+            ADD CONSTRAINT tournament_trophies_mvp_requires_player_check
+            CHECK (placement <> 0 OR player_steam_id IS NOT NULL);
+    END IF;
+END $$;
 
-CREATE UNIQUE INDEX tournament_trophies_player_recipient_key
+CREATE UNIQUE INDEX IF NOT EXISTS tournament_trophies_player_recipient_key
     ON public.tournament_trophies(tournament_id, tournament_team_id, player_steam_id, placement)
     WHERE player_steam_id IS NOT NULL;
 
-CREATE UNIQUE INDEX tournament_trophies_team_recipient_key
+CREATE UNIQUE INDEX IF NOT EXISTS tournament_trophies_team_recipient_key
     ON public.tournament_trophies(tournament_id, tournament_team_id, team_id, placement)
     WHERE team_id IS NOT NULL;
 
-CREATE INDEX idx_tournament_trophies_team
+CREATE INDEX IF NOT EXISTS idx_tournament_trophies_team
     ON public.tournament_trophies(team_id, placement)
     WHERE team_id IS NOT NULL;