fix: revert .catch() swallowing — let queue failures crash process

Author: Flegma

src/app.module.ts

@@ -142,9 +142,7 @@ export class AppModule implements OnApplicationBootstrap {
 
   public async onApplicationBootstrap() {
     try {
-      this.discordBot.setup().catch((error) => {
-        this.logger.error("Discord bot setup failed", error);
-      });
+      void this.discordBot.setup();
       await this.typesense.setup();
       await this.system.detectFeatures();
     } catch (error) {

src/matches/matches.module.ts

@@ -125,93 +125,67 @@ export class MatchesModule implements NestModule {
       return;
     }
 
-    scheduleMatchQueue
-      .add(
-        CheckForScheduledMatches.name,
-        {},
-        {
-          repeat: {
-            pattern: "* * * * *",
-          },
+    void scheduleMatchQueue.add(
+      CheckForScheduledMatches.name,
+      {},
+      {
+        repeat: {
+          pattern: "* * * * *",
         },
-      )
-      .catch((err) => {
-        this.logger.error("Failed to add CheckForScheduledMatches job", err);
-      });
+      },
+    );
 
-    scheduleMatchQueue
-      .add(
-        CancelExpiredMatches.name,
-        {},
-        {
-          repeat: {
-            pattern: "* * * * *",
-          },
+    void scheduleMatchQueue.add(
+      CancelExpiredMatches.name,
+      {},
+      {
+        repeat: {
+          pattern: "* * * * *",
         },
-      )
-      .catch((err) => {
-        this.logger.error("Failed to add CancelExpiredMatches job", err);
-      });
+      },
+    );
 
-    scheduleMatchQueue
-      .add(
-        RemoveCancelledMatches.name,
-        {},
-        {
-          repeat: {
-            pattern: "* * * * *",
-          },
+    void scheduleMatchQueue.add(
+      RemoveCancelledMatches.name,
+      {},
+      {
+        repeat: {
+          pattern: "* * * * *",
         },
-      )
-      .catch((err) => {
-        this.logger.error("Failed to add RemoveCancelledMatches job", err);
-      });
+      },
+    );
 
-    matchServersQueue
-      .add(
-        CheckForTournamentStart.name,
-        {},
-        {
-          repeat: {
-            pattern: "* * * * *",
-          },
+    void matchServersQueue.add(
+      CheckForTournamentStart.name,
+      {},
+      {
+        repeat: {
+          pattern: "* * * * *",
         },
-      )
-      .catch((err) => {
-        this.logger.error("Failed to add CheckForTournamentStart job", err);
-      });
+      },
+    );
 
-    matchServersQueue
-      .add(
-        CleanAbandonedMatches.name,
-        {},
-        {
-          repeat: {
-            pattern: "0 0 * * *",
-          },
+    void matchServersQueue.add(
+      CleanAbandonedMatches.name,
+      {},
+      {
+        repeat: {
+          pattern: "0 0 * * *",
         },
-      )
-      .catch((err) => {
-        this.logger.error("Failed to add CleanAbandonedMatches job", err);
-      });
+      },
+    );
 
-    matchServersQueue
-      .add(
-        CancelInvalidTournaments.name,
-        {},
-        {
-          repeat: {
-            pattern: "* * * * *",
-          },
+    void matchServersQueue.add(
+      CancelInvalidTournaments.name,
+      {},
+      {
+        repeat: {
+          pattern: "* * * * *",
         },
-      )
-      .catch((err) => {
-        this.logger.error("Failed to add CancelInvalidTournaments job", err);
-      });
+      },
+    );
 
-    this.generatePlayerRatings().catch((err) => {
-      this.logger.error("Failed to generate player ratings", err);
-    });
+    void this.generatePlayerRatings();
   }
 
   /**

src/sockets/sockets.service.ts

@@ -33,12 +33,8 @@ export class SocketsService {
 
     const sub = this.redisManager.getConnection("sub");
 
-    sub.subscribe("broadcast-message").catch((err) => {
-      this.logger.error("Failed to subscribe to broadcast-message", err);
-    });
-    sub.subscribe("send-message-to-steam-id").catch((err) => {
-      this.logger.error("Failed to subscribe to send-message-to-steam-id", err);
-    });
+    void sub.subscribe("broadcast-message");
+    void sub.subscribe("send-message-to-steam-id");
     sub.on("message", (channel, message) => {
       const { steamId, event, data } = JSON.parse(message) as {
         steamId: string;
@@ -48,14 +44,10 @@ export class SocketsService {
 
       switch (channel) {
         case "broadcast-message":
-          this.broadcastMessage(event, data).catch((err) => {
-            this.logger.error("broadcast-message error", err);
-          });
+          void this.broadcastMessage(event, data);
           break;
         case "send-message-to-steam-id":
-          this.sendMessageToSteamId(steamId, event, data).catch((err) => {
-            this.logger.error("send-message-to-steam-id error", err);
-          });
+          void this.sendMessageToSteamId(steamId, event, data);
           break;
       }
     });