chore: upgrade console to React Router 7.14.0 and Vite 8#365
Conversation
- Bump react-router and @react-router/* from ^7.12.0 to ^7.14.0 in catalog - Upgrade vite from ^7.3.1 to ^8.0.3 (Rolldown-powered) - Bump vite-plugin-babel from ^1.4.1 to ^1.6.0 for Vite 8 compat - Replace vite-tsconfig-paths plugin with Vite 8 built-in resolve.tsconfigPaths - experimental.bundledDev intentionally omitted (blocked by upstream #14947) Closes #338 Co-authored-by: Heinrich Wendel <heiwen@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpgrade React Router workspace packages to 7.14.0, bump Vite and related devDependencies in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64a969a073
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/console/package.json`:
- Around line 66-68: The package.json currently lists "vite": "^8.0.3" alongside
"vite-plugin-devtools-json": "^1.0.0", but that plugin's peerDeps only support
Vite ^5|^6|^7 and will cause peer dependency warnings; fix by either downgrading
"vite" to a V7-compatible version (change "vite" to "^7.x" in package.json) or
remove "vite-plugin-devtools-json" from dependencies if it's non-critical
(delete the "vite-plugin-devtools-json" entry and any imports/usages), then run
npm/yarn install and verify builds; also run the build/test pipeline to validate
"vite-plugin-babel" compatibility and revert if issues arise.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 8e572280-edc6-4b81-b798-34793e739ffb
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (3)
apps/console/package.jsonapps/console/vite.config.tspackage.json
|
@claude please have a look at the review comments |
|
Claude finished @heiwen's task in 1m 2s —— View job Review of PR comments
Both CodeRabbit and Codex flagged the Plugin Vite 8 compatibility matrix
Assessment
RecommendationsOption A — Keep Vite 8, accept the risk (pragmatic)
Option B — Defer Vite 8 until
For |
|
@claude do these packages already have upstream issues to upgrade to vite 8? |
|
Claude finished @heiwen's task in 1m 34s —— View job
Upstream Vite 8 support status
RecommendationThe only actionable item is bumping |
|
@claude then bump tailwindcss/vite, remove vite-plugin-devtools-json in favor of devtoolsJsonFile and update the bun lockfile |
|
Claude finished @heiwen's task in 1m 32s —— View job
All three items addressed in commit
|
…-json with native Vite 8 - Bump @tailwindcss/vite from ^4.1.18 to ^4.2.2 (adds Vite 8 peerDep support) - Remove vite-plugin-devtools-json in favor of Vite 8 built-in server.devtoolsJsonFile - Update bun lockfile Co-authored-by: Heinrich Wendel <heiwen@users.noreply.github.com>
|
@claude should we keep the ...(mode === "development" guard? |
|
Claude finished @heiwen's task in 28s —— View job
No, you can drop the guard. It's no longer needed. The
The current config on this branch already reflects the correct state — no action needed. |
|
@claude cleanup the |
Co-authored-by: Heinrich Wendel <heiwen@users.noreply.github.com>
Closes #338
Generated with Claude Code
Summary by CodeRabbit