Skip to content

Replace getattr introspection with system.option() for mixing kernels #42

@jc-macdonald

Description

@jc-macdonald

Problem Resolved

The op_engine provider currently reads mixing kernels from the system via getattr(system, "mixing_kernels", {}).

Update (Apr 8): The engine provider code already uses system.option("mixing_kernels", None) — the getattr pattern described originally was already replaced. The system-side fix (op_system populating self.options) landed in op_system PR #56 (merged Apr 8).

Remaining work

The only remaining introspection in the engine provider is:

stepper: SystemProtocol = system._stepper  # noqa: SLF001

This should be replaced with system.bind() now that flepimop2 PR #182 has merged (Apr 8). This is tracked in #49.

Scope

Related

Metadata

Metadata

Assignees

Labels

providerflepimop2 provider/connector packagerefactorCode reorganization without behavior changetestingTest infrastructure and accuracy benchmarks

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions