Skip to content

Commit ef2eb0e

Browse files
committed
Merge branch 'develop'
2 parents 57fab30 + cde297c commit ef2eb0e

9 files changed

Lines changed: 780 additions & 114 deletions

StandardPlugin/CommonExporters.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ public CommonExporters(Standard.Root root)
2626
_catalog = root.Catalog;
2727
Errors = new List<IError>();
2828

29-
var mappingFile = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "TypeMappings/framework-to-standard-type-mappings.json");
29+
var mappingFile = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "framework-to-standard-type-mappings.json");
3030
string mappingData = File.ReadAllText(mappingFile);
3131
TypeMappings = JsonConvert.DeserializeObject<List<TypeMapping>>(mappingData);
3232

33-
var standardTypesFile = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "ADAPTStandard/adapt-data-type-definitions.json");
33+
var standardTypesFile = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "adapt-data-type-definitions.json");
3434
string typesJson = File.ReadAllText(standardTypesFile);
3535
StandardDataTypes = JsonConvert.DeserializeObject<DataTypeDefinitions.DataTypeDefinitions>(typesJson);
3636
}

StandardPlugin/ADAPTStandard/DataTypeDefinitions.cs renamed to StandardPlugin/DataTypeDefinitions.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ public partial class NumericDataTypeDefinitionAttributes
8484
public string UnitOfMeasureCode { get; set; }
8585
}
8686

87-
public enum DataDefinitionBaseTypeCode { Enumeration, Numeric, Text };
87+
public enum DataDefinitionBaseTypeCode { Enumeration, Numeric, Text, Boolean };
8888

89-
public enum StatusCode { Valid };
89+
public enum StatusCode { Valid, Invalid };
9090

9191
public enum NumericDataTypeCode { Double, Integer };
9292

@@ -145,6 +145,9 @@ public override void WriteJson(JsonWriter writer, object untypedValue, JsonSeria
145145
case DataDefinitionBaseTypeCode.Text:
146146
serializer.Serialize(writer, "TEXT");
147147
return;
148+
case DataDefinitionBaseTypeCode.Boolean:
149+
serializer.Serialize(writer, "BOOLEAN");
150+
return;
148151
}
149152
throw new Exception("Cannot marshal type DataDefinitionBaseTypeCode");
150153
}
@@ -180,6 +183,11 @@ public override void WriteJson(JsonWriter writer, object untypedValue, JsonSeria
180183
serializer.Serialize(writer, "VALID");
181184
return;
182185
}
186+
if (value == StatusCode.Invalid)
187+
{
188+
serializer.Serialize(writer, "INVALID");
189+
return;
190+
}
183191
throw new Exception("Cannot marshal type StatusCode");
184192
}
185193

StandardPlugin/StandardPlugin.csproj

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,17 @@
2626
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
2727
</ItemGroup>
2828
<ItemGroup>
29-
<None Update="ADAPTStandard/adapt-data-type-definitions.json" CopyToOutputDirectory="PreserveNewest" />
30-
<None Update="TypeMappings/framework-to-standard-type-mappings.json" CopyToOutputDirectory="PreserveNewest" />
29+
<None Include="adapt-data-type-definitions.json">
30+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
31+
</None>
32+
<None Include="framework-to-standard-type-mappings.json">
33+
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
34+
</None>
35+
</ItemGroup>
36+
<ItemGroup>
37+
<None Include="adapt-data-type-definitions.json" Pack="true" PackagePath="build/" />
38+
<None Include="framework-to-standard-type-mappings.json" Pack="true" PackagePath="build/" />
39+
<None Include="build/AgGateway.ADAPT.StandardPlugin.targets" Pack="true" PackagePath="build/AgGateway.ADAPT.StandardPlugin.targets" />
3140
</ItemGroup>
3241

3342
</Project>
File renamed without changes.

StandardPlugin/WorkRecordExporter.cs

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ internal class WorkRecordExporter
2020
private readonly Standard.Root _root;
2121
private int _variableCounter;
2222
private readonly string _exportPath;
23+
private List<string> _operationIds = new List<string>();
2324
private WorkRecordExporter(Root root, string exportPath, Properties properties)
2425
{
2526
_variableCounter = 0;
@@ -267,13 +268,21 @@ private void ExportOperation(OperationDefinition operationDefinition, Applicatio
267268
p.Id.ReferenceId == r).Description)
268269
.Aggregate((i, j) => i + "_" + j);
269270
}
270-
string outputFileName = string.Concat(operationType, products, ".parquet");
271+
string candidateName = string.Concat(operationType, products);
272+
string uniqueName = candidateName;
273+
int opNameCounter = 1;
274+
while (_operationIds.Contains(uniqueName))
275+
{
276+
uniqueName = string.Concat(candidateName, "_", opNameCounter++);
277+
}
278+
_operationIds.Add(uniqueName);
279+
string outputFileName = string.Concat(uniqueName, ".parquet");
271280
outputFileName = new string(outputFileName.Where(c => !Path.GetInvalidFileNameChars().Contains(c)).ToArray());
272281
if (outputFileName.Length > 255)
273282
{
274283
outputFileName = outputFileName.Substring(0, 255);
275284
}
276-
var id = new Id() { ReferenceId = Guid.NewGuid().ToString() };
285+
var id = new Id() { ReferenceId = uniqueName };
277286
var variables = operationDefinition.VariablesByOutputName.Values.ToList();
278287
string joinedName = string.Join("_", operationDefinition.SourceOperations.Select(x => x.OperationData.Description));
279288
string name = string.IsNullOrEmpty(joinedName) ? workRecord.Name + "_" + operationType : joinedName;

0 commit comments

Comments
 (0)