From 2daf2e2102781a8408b82d71626913e160f931d2 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 15:31:33 -0700 Subject: [PATCH 01/56] intial set up complete --- .gitignore | 27 ++ .ruby-version | 1 + Gemfile | 81 +++++ Gemfile.lock | 279 ++++++++++++++++++ Guardfile | 9 + Rakefile | 6 + app/assets/config/manifest.js | 3 + app/assets/images/.keep | 0 app/assets/javascripts/application.js | 19 ++ app/assets/javascripts/cable.js | 13 + app/assets/javascripts/channels/.keep | 0 app/assets/stylesheets/application.scss | 17 ++ app/channels/application_cable/channel.rb | 4 + app/channels/application_cable/connection.rb | 4 + app/controllers/application_controller.rb | 2 + app/controllers/concerns/.keep | 0 app/helpers/application_helper.rb | 2 + app/jobs/application_job.rb | 2 + app/mailers/application_mailer.rb | 4 + app/models/application_record.rb | 3 + app/models/concerns/.keep | 0 app/views/layouts/application.html.erb | 15 + app/views/layouts/mailer.html.erb | 13 + app/views/layouts/mailer.text.erb | 1 + bin/bundle | 3 + bin/rails | 9 + bin/rake | 9 + bin/setup | 36 +++ bin/spring | 17 ++ bin/update | 31 ++ bin/yarn | 11 + config.ru | 5 + config/application.rb | 25 ++ config/boot.rb | 4 + config/cable.yml | 10 + config/credentials.yml.enc | 1 + config/database.yml | 85 ++++++ config/environment.rb | 5 + config/environments/development.rb | 61 ++++ config/environments/production.rb | 94 ++++++ config/environments/test.rb | 46 +++ config/initializers/action_view.rb | 1 + .../application_controller_renderer.rb | 8 + config/initializers/assets.rb | 14 + config/initializers/backtrace_silencers.rb | 7 + .../initializers/content_security_policy.rb | 25 ++ config/initializers/cookies_serializer.rb | 5 + .../initializers/filter_parameter_logging.rb | 4 + config/initializers/inflections.rb | 16 + config/initializers/mime_types.rb | 4 + config/initializers/wrap_parameters.rb | 14 + config/locales/en.yml | 33 +++ config/puma.rb | 34 +++ config/routes.rb | 3 + config/spring.rb | 6 + config/storage.yml | 34 +++ db/seeds.rb | 7 + lib/assets/.keep | 0 lib/tasks/.keep | 0 log/.keep | 0 package.json | 5 + public/404.html | 67 +++++ public/422.html | 67 +++++ public/500.html | 66 +++++ public/apple-touch-icon-precomposed.png | 0 public/apple-touch-icon.png | 0 public/favicon.ico | 0 public/robots.txt | 1 + storage/.keep | 0 test/application_system_test_case.rb | 5 + test/controllers/.keep | 0 test/fixtures/.keep | 0 test/fixtures/files/.keep | 0 test/helpers/.keep | 0 test/integration/.keep | 0 test/mailers/.keep | 0 test/models/.keep | 0 test/system/.keep | 0 test/test_helper.rb | 24 ++ tmp/.keep | 0 vendor/.keep | 0 81 files changed, 1407 insertions(+) create mode 100644 .gitignore create mode 100644 .ruby-version create mode 100644 Gemfile create mode 100644 Gemfile.lock create mode 100644 Guardfile create mode 100644 Rakefile create mode 100644 app/assets/config/manifest.js create mode 100644 app/assets/images/.keep create mode 100644 app/assets/javascripts/application.js create mode 100644 app/assets/javascripts/cable.js create mode 100644 app/assets/javascripts/channels/.keep create mode 100644 app/assets/stylesheets/application.scss create mode 100644 app/channels/application_cable/channel.rb create mode 100644 app/channels/application_cable/connection.rb create mode 100644 app/controllers/application_controller.rb create mode 100644 app/controllers/concerns/.keep create mode 100644 app/helpers/application_helper.rb create mode 100644 app/jobs/application_job.rb create mode 100644 app/mailers/application_mailer.rb create mode 100644 app/models/application_record.rb create mode 100644 app/models/concerns/.keep create mode 100644 app/views/layouts/application.html.erb create mode 100644 app/views/layouts/mailer.html.erb create mode 100644 app/views/layouts/mailer.text.erb create mode 100755 bin/bundle create mode 100755 bin/rails create mode 100755 bin/rake create mode 100755 bin/setup create mode 100755 bin/spring create mode 100755 bin/update create mode 100755 bin/yarn create mode 100644 config.ru create mode 100644 config/application.rb create mode 100644 config/boot.rb create mode 100644 config/cable.yml create mode 100644 config/credentials.yml.enc create mode 100644 config/database.yml create mode 100644 config/environment.rb create mode 100644 config/environments/development.rb create mode 100644 config/environments/production.rb create mode 100644 config/environments/test.rb create mode 100644 config/initializers/action_view.rb create mode 100644 config/initializers/application_controller_renderer.rb create mode 100644 config/initializers/assets.rb create mode 100644 config/initializers/backtrace_silencers.rb create mode 100644 config/initializers/content_security_policy.rb create mode 100644 config/initializers/cookies_serializer.rb create mode 100644 config/initializers/filter_parameter_logging.rb create mode 100644 config/initializers/inflections.rb create mode 100644 config/initializers/mime_types.rb create mode 100644 config/initializers/wrap_parameters.rb create mode 100644 config/locales/en.yml create mode 100644 config/puma.rb create mode 100644 config/routes.rb create mode 100644 config/spring.rb create mode 100644 config/storage.yml create mode 100644 db/seeds.rb create mode 100644 lib/assets/.keep create mode 100644 lib/tasks/.keep create mode 100644 log/.keep create mode 100644 package.json create mode 100644 public/404.html create mode 100644 public/422.html create mode 100644 public/500.html create mode 100644 public/apple-touch-icon-precomposed.png create mode 100644 public/apple-touch-icon.png create mode 100644 public/favicon.ico create mode 100644 public/robots.txt create mode 100644 storage/.keep create mode 100644 test/application_system_test_case.rb create mode 100644 test/controllers/.keep create mode 100644 test/fixtures/.keep create mode 100644 test/fixtures/files/.keep create mode 100644 test/helpers/.keep create mode 100644 test/integration/.keep create mode 100644 test/mailers/.keep create mode 100644 test/models/.keep create mode 100644 test/system/.keep create mode 100644 test/test_helper.rb create mode 100644 tmp/.keep create mode 100644 vendor/.keep diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000000..18b43c9cd2 --- /dev/null +++ b/.gitignore @@ -0,0 +1,27 @@ +# See https://help.github.com/articles/ignoring-files for more about ignoring files. +# +# If you find yourself ignoring temporary files generated by your text editor +# or operating system, you probably want to add a global ignore instead: +# git config --global core.excludesfile '~/.gitignore_global' + +# Ignore bundler config. +/.bundle + +# Ignore all logfiles and tempfiles. +/log/* +/tmp/* +!/log/.keep +!/tmp/.keep + +# Ignore uploaded files in development +/storage/* +!/storage/.keep + +/node_modules +/yarn-error.log + +/public/assets +.byebug_history + +# Ignore master key for decrypting credentials and more. +/config/master.key diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 0000000000..25c81fe399 --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +ruby-2.5.1 \ No newline at end of file diff --git a/Gemfile b/Gemfile new file mode 100644 index 0000000000..80be142348 --- /dev/null +++ b/Gemfile @@ -0,0 +1,81 @@ +source 'https://rubygems.org' +git_source(:github) { |repo| "https://github.com/#{repo}.git" } + +ruby '2.5.1' + +# Bundle edge Rails instead: gem 'rails', github: 'rails/rails' +gem 'rails', '~> 5.2.3' +# Use postgresql as the database for Active Record +gem 'pg', '>= 0.18', '< 2.0' +# Use Puma as the app server +gem 'puma', '~> 3.11' +# Use SCSS for stylesheets +gem 'sass-rails', '~> 5.0' +# Use Uglifier as compressor for JavaScript assets +gem 'uglifier', '>= 1.3.0' +# See https://github.com/rails/execjs#readme for more supported runtimes +# gem 'mini_racer', platforms: :ruby + +# Use CoffeeScript for .coffee assets and views +# gem 'coffee-rails', '~> 4.2' +# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks +gem 'turbolinks', '~> 5' +# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder +gem 'jbuilder', '~> 2.5' +# Use Redis adapter to run Action Cable in production +# gem 'redis', '~> 4.0' +# Use ActiveModel has_secure_password +# gem 'bcrypt', '~> 3.1.7' + +# Use ActiveStorage variant +# gem 'mini_magick', '~> 4.8' + +# Use Capistrano for deployment +# gem 'capistrano-rails', group: :development + +# Reduces boot times through caching; required in config/boot.rb +gem 'bootsnap', '>= 1.1.0', require: false + +group :development, :test do + # Call 'byebug' anywhere in the code to stop execution and get a debugger console + gem 'byebug', platforms: [:mri, :mingw, :x64_mingw] +end + +group :development do + # Access an interactive console on exception pages or by calling 'console' anywhere in the code. + gem 'web-console', '>= 3.3.0' + gem 'listen', '>= 3.0.5', '< 3.2' + # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring + gem 'spring' + gem 'spring-watcher-listen', '~> 2.0.0' +end + +group :test do + # Adds support for Capybara system testing and selenium driver + gem 'capybara', '>= 2.15' + gem 'selenium-webdriver' + # Easy installation and use of chromedriver to run system tests with Chrome + gem 'chromedriver-helper' +end + +# Windows does not include zoneinfo files, so bundle the tzinfo-data gem +gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby] + +gem 'jquery-rails' +gem 'jquery-turbolinks' +gem 'bootstrap', '~> 4.1.3' +group :development, :test do + gem 'pry-rails' +end + +group :development do + gem 'better_errors' + gem 'binding_of_caller' + gem 'guard' + gem 'guard-minitest' +end + +group :test do + gem 'minitest-rails' + gem 'minitest-reporters' +end diff --git a/Gemfile.lock b/Gemfile.lock new file mode 100644 index 0000000000..800e2e5b40 --- /dev/null +++ b/Gemfile.lock @@ -0,0 +1,279 @@ +GEM + remote: https://rubygems.org/ + specs: + actioncable (5.2.3) + actionpack (= 5.2.3) + nio4r (~> 2.0) + websocket-driver (>= 0.6.1) + actionmailer (5.2.3) + actionpack (= 5.2.3) + actionview (= 5.2.3) + activejob (= 5.2.3) + mail (~> 2.5, >= 2.5.4) + rails-dom-testing (~> 2.0) + actionpack (5.2.3) + actionview (= 5.2.3) + activesupport (= 5.2.3) + rack (~> 2.0) + rack-test (>= 0.6.3) + rails-dom-testing (~> 2.0) + rails-html-sanitizer (~> 1.0, >= 1.0.2) + actionview (5.2.3) + activesupport (= 5.2.3) + builder (~> 3.1) + erubi (~> 1.4) + rails-dom-testing (~> 2.0) + rails-html-sanitizer (~> 1.0, >= 1.0.3) + activejob (5.2.3) + activesupport (= 5.2.3) + globalid (>= 0.3.6) + activemodel (5.2.3) + activesupport (= 5.2.3) + activerecord (5.2.3) + activemodel (= 5.2.3) + activesupport (= 5.2.3) + arel (>= 9.0) + activestorage (5.2.3) + actionpack (= 5.2.3) + activerecord (= 5.2.3) + marcel (~> 0.3.1) + activesupport (5.2.3) + concurrent-ruby (~> 1.0, >= 1.0.2) + i18n (>= 0.7, < 2) + minitest (~> 5.1) + tzinfo (~> 1.1) + addressable (2.6.0) + public_suffix (>= 2.0.2, < 4.0) + ansi (1.5.0) + archive-zip (0.12.0) + io-like (~> 0.3.0) + arel (9.0.0) + autoprefixer-rails (9.5.1) + execjs + better_errors (2.5.1) + coderay (>= 1.0.0) + erubi (>= 1.0.0) + rack (>= 0.9.0) + bindex (0.7.0) + binding_of_caller (0.8.0) + debug_inspector (>= 0.0.1) + bootsnap (1.4.3) + msgpack (~> 1.0) + bootstrap (4.1.3) + autoprefixer-rails (>= 6.0.3) + popper_js (>= 1.12.9, < 2) + sass (>= 3.5.2) + builder (3.2.3) + byebug (11.0.1) + capybara (3.18.0) + addressable + mini_mime (>= 0.1.3) + nokogiri (~> 1.8) + rack (>= 1.6.0) + rack-test (>= 0.6.3) + regexp_parser (~> 1.2) + xpath (~> 3.2) + childprocess (1.0.1) + rake (< 13.0) + chromedriver-helper (2.1.1) + archive-zip (~> 0.10) + nokogiri (~> 1.8) + coderay (1.1.2) + concurrent-ruby (1.1.5) + crass (1.0.4) + debug_inspector (0.0.3) + erubi (1.8.0) + execjs (2.7.0) + ffi (1.10.0) + formatador (0.2.5) + globalid (0.4.2) + activesupport (>= 4.2.0) + guard (2.15.0) + formatador (>= 0.2.4) + listen (>= 2.7, < 4.0) + lumberjack (>= 1.0.12, < 2.0) + nenv (~> 0.1) + notiffany (~> 0.0) + pry (>= 0.9.12) + shellany (~> 0.0) + thor (>= 0.18.1) + guard-compat (1.2.1) + guard-minitest (2.4.6) + guard-compat (~> 1.2) + minitest (>= 3.0) + i18n (1.6.0) + concurrent-ruby (~> 1.0) + io-like (0.3.0) + jbuilder (2.8.0) + activesupport (>= 4.2.0) + multi_json (>= 1.2) + jquery-rails (4.3.3) + rails-dom-testing (>= 1, < 3) + railties (>= 4.2.0) + thor (>= 0.14, < 2.0) + jquery-turbolinks (2.1.0) + railties (>= 3.1.0) + turbolinks + listen (3.1.5) + rb-fsevent (~> 0.9, >= 0.9.4) + rb-inotify (~> 0.9, >= 0.9.7) + ruby_dep (~> 1.2) + loofah (2.2.3) + crass (~> 1.0.2) + nokogiri (>= 1.5.9) + lumberjack (1.0.13) + mail (2.7.1) + mini_mime (>= 0.1.1) + marcel (0.3.3) + mimemagic (~> 0.3.2) + method_source (0.9.2) + mimemagic (0.3.3) + mini_mime (1.0.1) + mini_portile2 (2.4.0) + minitest (5.11.3) + minitest-rails (3.0.0) + minitest (~> 5.8) + railties (~> 5.0) + minitest-reporters (1.3.6) + ansi + builder + minitest (>= 5.0) + ruby-progressbar + msgpack (1.2.10) + multi_json (1.13.1) + nenv (0.3.0) + nio4r (2.3.1) + nokogiri (1.10.3) + mini_portile2 (~> 2.4.0) + notiffany (0.1.1) + nenv (~> 0.1) + shellany (~> 0.0) + pg (1.1.4) + popper_js (1.14.5) + pry (0.12.2) + coderay (~> 1.1.0) + method_source (~> 0.9.0) + pry-rails (0.3.9) + pry (>= 0.10.4) + public_suffix (3.0.3) + puma (3.12.1) + rack (2.0.7) + rack-test (1.1.0) + rack (>= 1.0, < 3) + rails (5.2.3) + actioncable (= 5.2.3) + actionmailer (= 5.2.3) + actionpack (= 5.2.3) + actionview (= 5.2.3) + activejob (= 5.2.3) + activemodel (= 5.2.3) + activerecord (= 5.2.3) + activestorage (= 5.2.3) + activesupport (= 5.2.3) + bundler (>= 1.3.0) + railties (= 5.2.3) + sprockets-rails (>= 2.0.0) + rails-dom-testing (2.0.3) + activesupport (>= 4.2.0) + nokogiri (>= 1.6) + rails-html-sanitizer (1.0.4) + loofah (~> 2.2, >= 2.2.2) + railties (5.2.3) + actionpack (= 5.2.3) + activesupport (= 5.2.3) + method_source + rake (>= 0.8.7) + thor (>= 0.19.0, < 2.0) + rake (12.3.2) + rb-fsevent (0.10.3) + rb-inotify (0.10.0) + ffi (~> 1.0) + regexp_parser (1.4.0) + ruby-progressbar (1.10.0) + ruby_dep (1.5.0) + rubyzip (1.2.2) + sass (3.7.4) + sass-listen (~> 4.0.0) + sass-listen (4.0.0) + rb-fsevent (~> 0.9, >= 0.9.4) + rb-inotify (~> 0.9, >= 0.9.7) + sass-rails (5.0.7) + railties (>= 4.0.0, < 6) + sass (~> 3.1) + sprockets (>= 2.8, < 4.0) + sprockets-rails (>= 2.0, < 4.0) + tilt (>= 1.1, < 3) + selenium-webdriver (3.141.5926) + childprocess (>= 0.5, < 2.0) + rubyzip (~> 1.2, >= 1.2.2) + shellany (0.0.1) + spring (2.0.2) + activesupport (>= 4.2) + spring-watcher-listen (2.0.1) + listen (>= 2.7, < 4.0) + spring (>= 1.2, < 3.0) + sprockets (3.7.2) + concurrent-ruby (~> 1.0) + rack (> 1, < 3) + sprockets-rails (3.2.1) + actionpack (>= 4.0) + activesupport (>= 4.0) + sprockets (>= 3.0.0) + thor (0.20.3) + thread_safe (0.3.6) + tilt (2.0.9) + turbolinks (5.2.0) + turbolinks-source (~> 5.2) + turbolinks-source (5.2.0) + tzinfo (1.2.5) + thread_safe (~> 0.1) + uglifier (4.1.20) + execjs (>= 0.3.0, < 3) + web-console (3.7.0) + actionview (>= 5.0) + activemodel (>= 5.0) + bindex (>= 0.4.0) + railties (>= 5.0) + websocket-driver (0.7.0) + websocket-extensions (>= 0.1.0) + websocket-extensions (0.1.3) + xpath (3.2.0) + nokogiri (~> 1.8) + +PLATFORMS + ruby + +DEPENDENCIES + better_errors + binding_of_caller + bootsnap (>= 1.1.0) + bootstrap (~> 4.1.3) + byebug + capybara (>= 2.15) + chromedriver-helper + guard + guard-minitest + jbuilder (~> 2.5) + jquery-rails + jquery-turbolinks + listen (>= 3.0.5, < 3.2) + minitest-rails + minitest-reporters + pg (>= 0.18, < 2.0) + pry-rails + puma (~> 3.11) + rails (~> 5.2.3) + sass-rails (~> 5.0) + selenium-webdriver + spring + spring-watcher-listen (~> 2.0.0) + turbolinks (~> 5) + tzinfo-data + uglifier (>= 1.3.0) + web-console (>= 3.3.0) + +RUBY VERSION + ruby 2.5.1p57 + +BUNDLED WITH + 2.0.1 diff --git a/Guardfile b/Guardfile new file mode 100644 index 0000000000..e34f706f4a --- /dev/null +++ b/Guardfile @@ -0,0 +1,9 @@ +guard :minitest, autorun: false, spring: true do + watch(%r{^app/(.+).rb$}) { |m| "test/#{m[1]}_test.rb" } + watch(%r{^app/controllers/application_controller.rb$}) { 'test/controllers' } + watch(%r{^app/controllers/(.+)_controller.rb$}) { |m| "test/integration/#{m[1]}_test.rb" } + watch(%r{^app/views/(.+)_mailer/.+}) { |m| "test/mailers/#{m[1]}_mailer_test.rb" } + watch(%r{^lib/(.+).rb$}) { |m| "test/lib/#{m[1]}_test.rb" } + watch(%r{^test/.+_test.rb$}) + watch(%r{^test/test_helper.rb$}) { 'test' } +end diff --git a/Rakefile b/Rakefile new file mode 100644 index 0000000000..e85f913914 --- /dev/null +++ b/Rakefile @@ -0,0 +1,6 @@ +# Add your own tasks in files placed in lib/tasks ending in .rake, +# for example lib/tasks/capistrano.rake, and they will automatically be available to Rake. + +require_relative 'config/application' + +Rails.application.load_tasks diff --git a/app/assets/config/manifest.js b/app/assets/config/manifest.js new file mode 100644 index 0000000000..b16e53d6d5 --- /dev/null +++ b/app/assets/config/manifest.js @@ -0,0 +1,3 @@ +//= link_tree ../images +//= link_directory ../javascripts .js +//= link_directory ../stylesheets .css diff --git a/app/assets/images/.keep b/app/assets/images/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/app/assets/javascripts/application.js b/app/assets/javascripts/application.js new file mode 100644 index 0000000000..b0ef35b723 --- /dev/null +++ b/app/assets/javascripts/application.js @@ -0,0 +1,19 @@ +// This is a manifest file that'll be compiled into application.js, which will include all the files +// listed below. +// +// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, or any plugin's +// vendor/assets/javascripts directory can be referenced here using a relative path. +// +// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the +// compiled file. JavaScript code in this file should be added after the last require_* statement. +// +// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details +// about supported directives. //= require jquery3 + //= require popper + //= require bootstrap-sprockets + +// +//= require rails-ujs +//= require activestorage +//= require turbolinks +//= require_tree . diff --git a/app/assets/javascripts/cable.js b/app/assets/javascripts/cable.js new file mode 100644 index 0000000000..739aa5f022 --- /dev/null +++ b/app/assets/javascripts/cable.js @@ -0,0 +1,13 @@ +// Action Cable provides the framework to deal with WebSockets in Rails. +// You can generate new channels where WebSocket features live using the `rails generate channel` command. +// +//= require action_cable +//= require_self +//= require_tree ./channels + +(function() { + this.App || (this.App = {}); + + App.cable = ActionCable.createConsumer(); + +}).call(this); diff --git a/app/assets/javascripts/channels/.keep b/app/assets/javascripts/channels/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss new file mode 100644 index 0000000000..b4d20f5641 --- /dev/null +++ b/app/assets/stylesheets/application.scss @@ -0,0 +1,17 @@ +/* + * This is a manifest file that'll be compiled into application.css, which will include all the files + * listed below. + * + * Any CSS and SCSS file within this directory, lib/assets/stylesheets, or any plugin's + * vendor/assets/stylesheets directory can be referenced here using a relative path. + * + * You're free to add application-wide styles to this file and they'll appear at the bottom of the + * compiled file so the styles you add here take precedence over styles defined in any other CSS/SCSS + * files in this directory. Styles in this file should be added after the last require_* statement. + * It is generally better to create a new file per style scope. + * + */ +/* Custom bootstrap variables must be set or imported *before* bootstrap. */ +@import "bootstrap"; +/* Import scss content */ +@import "**/*"; diff --git a/app/channels/application_cable/channel.rb b/app/channels/application_cable/channel.rb new file mode 100644 index 0000000000..d672697283 --- /dev/null +++ b/app/channels/application_cable/channel.rb @@ -0,0 +1,4 @@ +module ApplicationCable + class Channel < ActionCable::Channel::Base + end +end diff --git a/app/channels/application_cable/connection.rb b/app/channels/application_cable/connection.rb new file mode 100644 index 0000000000..0ff5442f47 --- /dev/null +++ b/app/channels/application_cable/connection.rb @@ -0,0 +1,4 @@ +module ApplicationCable + class Connection < ActionCable::Connection::Base + end +end diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb new file mode 100644 index 0000000000..09705d12ab --- /dev/null +++ b/app/controllers/application_controller.rb @@ -0,0 +1,2 @@ +class ApplicationController < ActionController::Base +end diff --git a/app/controllers/concerns/.keep b/app/controllers/concerns/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb new file mode 100644 index 0000000000..de6be7945c --- /dev/null +++ b/app/helpers/application_helper.rb @@ -0,0 +1,2 @@ +module ApplicationHelper +end diff --git a/app/jobs/application_job.rb b/app/jobs/application_job.rb new file mode 100644 index 0000000000..a009ace51c --- /dev/null +++ b/app/jobs/application_job.rb @@ -0,0 +1,2 @@ +class ApplicationJob < ActiveJob::Base +end diff --git a/app/mailers/application_mailer.rb b/app/mailers/application_mailer.rb new file mode 100644 index 0000000000..286b2239d1 --- /dev/null +++ b/app/mailers/application_mailer.rb @@ -0,0 +1,4 @@ +class ApplicationMailer < ActionMailer::Base + default from: 'from@example.com' + layout 'mailer' +end diff --git a/app/models/application_record.rb b/app/models/application_record.rb new file mode 100644 index 0000000000..10a4cba84d --- /dev/null +++ b/app/models/application_record.rb @@ -0,0 +1,3 @@ +class ApplicationRecord < ActiveRecord::Base + self.abstract_class = true +end diff --git a/app/models/concerns/.keep b/app/models/concerns/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb new file mode 100644 index 0000000000..f32268a271 --- /dev/null +++ b/app/views/layouts/application.html.erb @@ -0,0 +1,15 @@ + + + + MediaRanker + <%= csrf_meta_tags %> + <%= csp_meta_tag %> + + <%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %> + <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %> + + + + <%= yield %> + + diff --git a/app/views/layouts/mailer.html.erb b/app/views/layouts/mailer.html.erb new file mode 100644 index 0000000000..cbd34d2e9d --- /dev/null +++ b/app/views/layouts/mailer.html.erb @@ -0,0 +1,13 @@ + + + + + + + + + <%= yield %> + + diff --git a/app/views/layouts/mailer.text.erb b/app/views/layouts/mailer.text.erb new file mode 100644 index 0000000000..37f0bddbd7 --- /dev/null +++ b/app/views/layouts/mailer.text.erb @@ -0,0 +1 @@ +<%= yield %> diff --git a/bin/bundle b/bin/bundle new file mode 100755 index 0000000000..f19acf5b5c --- /dev/null +++ b/bin/bundle @@ -0,0 +1,3 @@ +#!/usr/bin/env ruby +ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__) +load Gem.bin_path('bundler', 'bundle') diff --git a/bin/rails b/bin/rails new file mode 100755 index 0000000000..5badb2fde0 --- /dev/null +++ b/bin/rails @@ -0,0 +1,9 @@ +#!/usr/bin/env ruby +begin + load File.expand_path('../spring', __FILE__) +rescue LoadError => e + raise unless e.message.include?('spring') +end +APP_PATH = File.expand_path('../config/application', __dir__) +require_relative '../config/boot' +require 'rails/commands' diff --git a/bin/rake b/bin/rake new file mode 100755 index 0000000000..d87d5f5781 --- /dev/null +++ b/bin/rake @@ -0,0 +1,9 @@ +#!/usr/bin/env ruby +begin + load File.expand_path('../spring', __FILE__) +rescue LoadError => e + raise unless e.message.include?('spring') +end +require_relative '../config/boot' +require 'rake' +Rake.application.run diff --git a/bin/setup b/bin/setup new file mode 100755 index 0000000000..94fd4d7977 --- /dev/null +++ b/bin/setup @@ -0,0 +1,36 @@ +#!/usr/bin/env ruby +require 'fileutils' +include FileUtils + +# path to your application root. +APP_ROOT = File.expand_path('..', __dir__) + +def system!(*args) + system(*args) || abort("\n== Command #{args} failed ==") +end + +chdir APP_ROOT do + # This script is a starting point to setup your application. + # Add necessary setup steps to this file. + + puts '== Installing dependencies ==' + system! 'gem install bundler --conservative' + system('bundle check') || system!('bundle install') + + # Install JavaScript dependencies if using Yarn + # system('bin/yarn') + + # puts "\n== Copying sample files ==" + # unless File.exist?('config/database.yml') + # cp 'config/database.yml.sample', 'config/database.yml' + # end + + puts "\n== Preparing database ==" + system! 'bin/rails db:setup' + + puts "\n== Removing old logs and tempfiles ==" + system! 'bin/rails log:clear tmp:clear' + + puts "\n== Restarting application server ==" + system! 'bin/rails restart' +end diff --git a/bin/spring b/bin/spring new file mode 100755 index 0000000000..fb2ec2ebb4 --- /dev/null +++ b/bin/spring @@ -0,0 +1,17 @@ +#!/usr/bin/env ruby + +# This file loads spring without using Bundler, in order to be fast. +# It gets overwritten when you run the `spring binstub` command. + +unless defined?(Spring) + require 'rubygems' + require 'bundler' + + lockfile = Bundler::LockfileParser.new(Bundler.default_lockfile.read) + spring = lockfile.specs.detect { |spec| spec.name == "spring" } + if spring + Gem.use_paths Gem.dir, Bundler.bundle_path.to_s, *Gem.path + gem 'spring', spring.version + require 'spring/binstub' + end +end diff --git a/bin/update b/bin/update new file mode 100755 index 0000000000..58bfaed518 --- /dev/null +++ b/bin/update @@ -0,0 +1,31 @@ +#!/usr/bin/env ruby +require 'fileutils' +include FileUtils + +# path to your application root. +APP_ROOT = File.expand_path('..', __dir__) + +def system!(*args) + system(*args) || abort("\n== Command #{args} failed ==") +end + +chdir APP_ROOT do + # This script is a way to update your development environment automatically. + # Add necessary update steps to this file. + + puts '== Installing dependencies ==' + system! 'gem install bundler --conservative' + system('bundle check') || system!('bundle install') + + # Install JavaScript dependencies if using Yarn + # system('bin/yarn') + + puts "\n== Updating database ==" + system! 'bin/rails db:migrate' + + puts "\n== Removing old logs and tempfiles ==" + system! 'bin/rails log:clear tmp:clear' + + puts "\n== Restarting application server ==" + system! 'bin/rails restart' +end diff --git a/bin/yarn b/bin/yarn new file mode 100755 index 0000000000..460dd565b4 --- /dev/null +++ b/bin/yarn @@ -0,0 +1,11 @@ +#!/usr/bin/env ruby +APP_ROOT = File.expand_path('..', __dir__) +Dir.chdir(APP_ROOT) do + begin + exec "yarnpkg", *ARGV + rescue Errno::ENOENT + $stderr.puts "Yarn executable was not detected in the system." + $stderr.puts "Download Yarn at https://yarnpkg.com/en/docs/install" + exit 1 + end +end diff --git a/config.ru b/config.ru new file mode 100644 index 0000000000..f7ba0b527b --- /dev/null +++ b/config.ru @@ -0,0 +1,5 @@ +# This file is used by Rack-based servers to start the application. + +require_relative 'config/environment' + +run Rails.application diff --git a/config/application.rb b/config/application.rb new file mode 100644 index 0000000000..08db79cb25 --- /dev/null +++ b/config/application.rb @@ -0,0 +1,25 @@ +require_relative 'boot' + +require 'rails/all' + +# Require the gems listed in Gemfile, including any gems +# you've limited to :test, :development, or :production. +Bundler.require(*Rails.groups) + +module MediaRanker + class Application < Rails::Application + config.generators do |g| + # Force new test files to be generated in the minitest-spec style + g.test_framework :minitest, spec: true + # Always use .js files, never .coffee + g.javascript_engine :js + end + # Initialize configuration defaults for originally generated Rails version. + config.load_defaults 5.2 + + # Settings in config/environments/* take precedence over those specified here. + # Application configuration can go into files in config/initializers + # -- all .rb files in that directory are automatically loaded after loading + # the framework and any gems in your application. + end +end diff --git a/config/boot.rb b/config/boot.rb new file mode 100644 index 0000000000..b9e460cef3 --- /dev/null +++ b/config/boot.rb @@ -0,0 +1,4 @@ +ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__) + +require 'bundler/setup' # Set up gems listed in the Gemfile. +require 'bootsnap/setup' # Speed up boot time by caching expensive operations. diff --git a/config/cable.yml b/config/cable.yml new file mode 100644 index 0000000000..0b286f676e --- /dev/null +++ b/config/cable.yml @@ -0,0 +1,10 @@ +development: + adapter: async + +test: + adapter: async + +production: + adapter: redis + url: <%= ENV.fetch("REDIS_URL") { "redis://localhost:6379/1" } %> + channel_prefix: MediaRanker_production diff --git a/config/credentials.yml.enc b/config/credentials.yml.enc new file mode 100644 index 0000000000..43aba0b0e3 --- /dev/null +++ b/config/credentials.yml.enc @@ -0,0 +1 @@ +BWF7WEm0JQNu432NF0Sks6vGp1wPHRYEshDUoNjjWtGiyYlLemwnnDvG8Ss6aTV4XKTPD5tvCbqij/M2ARSqQlM27po5DlyXPQ4DOnsTTw1ZtG+Rcxvjx+6+v70ezZZx7OTJEdXXak08Em6xfrv1L4VfXRtvW8pzZFQHipH0jUBQnr6dg4SOPoPQqQ0aGLC7UVnbBTu33z/SBHSAeItEe5gKeECfgMMzTp75T+0McMG1Z/Y+uVuIbht5b27+v90nVBdCL2qHWlzeZbWGiLqCivgVyxMJhrPvhAA0V+jV7W1TB7c3dd0U7NCJrF74mbKBHz1ppE/jZfXbRGHp9Yh9IGtPuuuUkk4JSxmJ81aeLMU6EJcg1lbTJrR9N+JB0WmS9VWnJ0pTo+ob3GjFFLJVehUrjbpzCk6LxURW--VR5Xs+xSjWLNbaOM--bprcPv5qnHoHA5ISqa/xOA== \ No newline at end of file diff --git a/config/database.yml b/config/database.yml new file mode 100644 index 0000000000..0bd2511123 --- /dev/null +++ b/config/database.yml @@ -0,0 +1,85 @@ +# PostgreSQL. Versions 9.1 and up are supported. +# +# Install the pg driver: +# gem install pg +# On OS X with Homebrew: +# gem install pg -- --with-pg-config=/usr/local/bin/pg_config +# On OS X with MacPorts: +# gem install pg -- --with-pg-config=/opt/local/lib/postgresql84/bin/pg_config +# On Windows: +# gem install pg +# Choose the win32 build. +# Install PostgreSQL and put its /bin directory on your path. +# +# Configure Using Gemfile +# gem 'pg' +# +default: &default + adapter: postgresql + encoding: unicode + # For details on connection pooling, see Rails configuration guide + # http://guides.rubyonrails.org/configuring.html#database-pooling + pool: <%= ENV.fetch("RAILS_MAX_THREADS") { 5 } %> + +development: + <<: *default + database: MediaRanker_development + + # The specified database role being used to connect to postgres. + # To create additional roles in postgres see `$ createuser --help`. + # When left blank, postgres will use the default role. This is + # the same name as the operating system user that initialized the database. + #username: MediaRanker + + # The password associated with the postgres role (username). + #password: + + # Connect on a TCP socket. Omitted by default since the client uses a + # domain socket that doesn't need configuration. Windows does not have + # domain sockets, so uncomment these lines. + #host: localhost + + # The TCP port the server listens on. Defaults to 5432. + # If your server runs on a different port number, change accordingly. + #port: 5432 + + # Schema search path. The server defaults to $user,public + #schema_search_path: myapp,sharedapp,public + + # Minimum log levels, in increasing order: + # debug5, debug4, debug3, debug2, debug1, + # log, notice, warning, error, fatal, and panic + # Defaults to warning. + #min_messages: notice + +# Warning: The database defined as "test" will be erased and +# re-generated from your development database when you run "rake". +# Do not set this db to the same as development or production. +test: + <<: *default + database: MediaRanker_test + +# As with config/secrets.yml, you never want to store sensitive information, +# like your database password, in your source code. If your source code is +# ever seen by anyone, they now have access to your database. +# +# Instead, provide the password as a unix environment variable when you boot +# the app. Read http://guides.rubyonrails.org/configuring.html#configuring-a-database +# for a full rundown on how to provide these environment variables in a +# production deployment. +# +# On Heroku and other platform providers, you may have a full connection URL +# available as an environment variable. For example: +# +# DATABASE_URL="postgres://myuser:mypass@localhost/somedatabase" +# +# You can use this database configuration with: +# +# production: +# url: <%= ENV['DATABASE_URL'] %> +# +production: + <<: *default + database: MediaRanker_production + username: MediaRanker + password: <%= ENV['MEDIARANKER_DATABASE_PASSWORD'] %> diff --git a/config/environment.rb b/config/environment.rb new file mode 100644 index 0000000000..426333bb46 --- /dev/null +++ b/config/environment.rb @@ -0,0 +1,5 @@ +# Load the Rails application. +require_relative 'application' + +# Initialize the Rails application. +Rails.application.initialize! diff --git a/config/environments/development.rb b/config/environments/development.rb new file mode 100644 index 0000000000..1311e3e4ef --- /dev/null +++ b/config/environments/development.rb @@ -0,0 +1,61 @@ +Rails.application.configure do + # Settings specified here will take precedence over those in config/application.rb. + + # In the development environment your application's code is reloaded on + # every request. This slows down response time but is perfect for development + # since you don't have to restart the web server when you make code changes. + config.cache_classes = false + + # Do not eager load code on boot. + config.eager_load = false + + # Show full error reports. + config.consider_all_requests_local = true + + # Enable/disable caching. By default caching is disabled. + # Run rails dev:cache to toggle caching. + if Rails.root.join('tmp', 'caching-dev.txt').exist? + config.action_controller.perform_caching = true + + config.cache_store = :memory_store + config.public_file_server.headers = { + 'Cache-Control' => "public, max-age=#{2.days.to_i}" + } + else + config.action_controller.perform_caching = false + + config.cache_store = :null_store + end + + # Store uploaded files on the local file system (see config/storage.yml for options) + config.active_storage.service = :local + + # Don't care if the mailer can't send. + config.action_mailer.raise_delivery_errors = false + + config.action_mailer.perform_caching = false + + # Print deprecation notices to the Rails logger. + config.active_support.deprecation = :log + + # Raise an error on page load if there are pending migrations. + config.active_record.migration_error = :page_load + + # Highlight code that triggered database queries in logs. + config.active_record.verbose_query_logs = true + + # Debug mode disables concatenation and preprocessing of assets. + # This option may cause significant delays in view rendering with a large + # number of complex assets. + config.assets.debug = true + + # Suppress logger output for asset requests. + config.assets.quiet = true + + # Raises error for missing translations + # config.action_view.raise_on_missing_translations = true + + # Use an evented file watcher to asynchronously detect changes in source code, + # routes, locales, etc. This feature depends on the listen gem. + config.file_watcher = ActiveSupport::EventedFileUpdateChecker +end diff --git a/config/environments/production.rb b/config/environments/production.rb new file mode 100644 index 0000000000..bd39d9d752 --- /dev/null +++ b/config/environments/production.rb @@ -0,0 +1,94 @@ +Rails.application.configure do + # Settings specified here will take precedence over those in config/application.rb. + + # Code is not reloaded between requests. + config.cache_classes = true + + # Eager load code on boot. This eager loads most of Rails and + # your application in memory, allowing both threaded web servers + # and those relying on copy on write to perform better. + # Rake tasks automatically ignore this option for performance. + config.eager_load = true + + # Full error reports are disabled and caching is turned on. + config.consider_all_requests_local = false + config.action_controller.perform_caching = true + + # Ensures that a master key has been made available in either ENV["RAILS_MASTER_KEY"] + # or in config/master.key. This key is used to decrypt credentials (and other encrypted files). + # config.require_master_key = true + + # Disable serving static files from the `/public` folder by default since + # Apache or NGINX already handles this. + config.public_file_server.enabled = ENV['RAILS_SERVE_STATIC_FILES'].present? + + # Compress JavaScripts and CSS. + config.assets.js_compressor = :uglifier + # config.assets.css_compressor = :sass + + # Do not fallback to assets pipeline if a precompiled asset is missed. + config.assets.compile = false + + # `config.assets.precompile` and `config.assets.version` have moved to config/initializers/assets.rb + + # Enable serving of images, stylesheets, and JavaScripts from an asset server. + # config.action_controller.asset_host = 'http://assets.example.com' + + # Specifies the header that your server uses for sending files. + # config.action_dispatch.x_sendfile_header = 'X-Sendfile' # for Apache + # config.action_dispatch.x_sendfile_header = 'X-Accel-Redirect' # for NGINX + + # Store uploaded files on the local file system (see config/storage.yml for options) + config.active_storage.service = :local + + # Mount Action Cable outside main process or domain + # config.action_cable.mount_path = nil + # config.action_cable.url = 'wss://example.com/cable' + # config.action_cable.allowed_request_origins = [ 'http://example.com', /http:\/\/example.*/ ] + + # Force all access to the app over SSL, use Strict-Transport-Security, and use secure cookies. + # config.force_ssl = true + + # Use the lowest log level to ensure availability of diagnostic information + # when problems arise. + config.log_level = :debug + + # Prepend all log lines with the following tags. + config.log_tags = [ :request_id ] + + # Use a different cache store in production. + # config.cache_store = :mem_cache_store + + # Use a real queuing backend for Active Job (and separate queues per environment) + # config.active_job.queue_adapter = :resque + # config.active_job.queue_name_prefix = "MediaRanker_#{Rails.env}" + + config.action_mailer.perform_caching = false + + # Ignore bad email addresses and do not raise email delivery errors. + # Set this to true and configure the email server for immediate delivery to raise delivery errors. + # config.action_mailer.raise_delivery_errors = false + + # Enable locale fallbacks for I18n (makes lookups for any locale fall back to + # the I18n.default_locale when a translation cannot be found). + config.i18n.fallbacks = true + + # Send deprecation notices to registered listeners. + config.active_support.deprecation = :notify + + # Use default logging formatter so that PID and timestamp are not suppressed. + config.log_formatter = ::Logger::Formatter.new + + # Use a different logger for distributed setups. + # require 'syslog/logger' + # config.logger = ActiveSupport::TaggedLogging.new(Syslog::Logger.new 'app-name') + + if ENV["RAILS_LOG_TO_STDOUT"].present? + logger = ActiveSupport::Logger.new(STDOUT) + logger.formatter = config.log_formatter + config.logger = ActiveSupport::TaggedLogging.new(logger) + end + + # Do not dump schema after migrations. + config.active_record.dump_schema_after_migration = false +end diff --git a/config/environments/test.rb b/config/environments/test.rb new file mode 100644 index 0000000000..0a38fd3ce9 --- /dev/null +++ b/config/environments/test.rb @@ -0,0 +1,46 @@ +Rails.application.configure do + # Settings specified here will take precedence over those in config/application.rb. + + # The test environment is used exclusively to run your application's + # test suite. You never need to work with it otherwise. Remember that + # your test database is "scratch space" for the test suite and is wiped + # and recreated between test runs. Don't rely on the data there! + config.cache_classes = true + + # Do not eager load code on boot. This avoids loading your whole application + # just for the purpose of running a single test. If you are using a tool that + # preloads Rails for running tests, you may have to set it to true. + config.eager_load = false + + # Configure public file server for tests with Cache-Control for performance. + config.public_file_server.enabled = true + config.public_file_server.headers = { + 'Cache-Control' => "public, max-age=#{1.hour.to_i}" + } + + # Show full error reports and disable caching. + config.consider_all_requests_local = true + config.action_controller.perform_caching = false + + # Raise exceptions instead of rendering exception templates. + config.action_dispatch.show_exceptions = false + + # Disable request forgery protection in test environment. + config.action_controller.allow_forgery_protection = false + + # Store uploaded files on the local file system in a temporary directory + config.active_storage.service = :test + + config.action_mailer.perform_caching = false + + # Tell Action Mailer not to deliver emails to the real world. + # The :test delivery method accumulates sent emails in the + # ActionMailer::Base.deliveries array. + config.action_mailer.delivery_method = :test + + # Print deprecation notices to the stderr. + config.active_support.deprecation = :stderr + + # Raises error for missing translations + # config.action_view.raise_on_missing_translations = true +end diff --git a/config/initializers/action_view.rb b/config/initializers/action_view.rb new file mode 100644 index 0000000000..142d382f87 --- /dev/null +++ b/config/initializers/action_view.rb @@ -0,0 +1 @@ +Rails.application.config.action_view.form_with_generates_remote_forms = false diff --git a/config/initializers/application_controller_renderer.rb b/config/initializers/application_controller_renderer.rb new file mode 100644 index 0000000000..89d2efab2b --- /dev/null +++ b/config/initializers/application_controller_renderer.rb @@ -0,0 +1,8 @@ +# Be sure to restart your server when you modify this file. + +# ActiveSupport::Reloader.to_prepare do +# ApplicationController.renderer.defaults.merge!( +# http_host: 'example.org', +# https: false +# ) +# end diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb new file mode 100644 index 0000000000..4b828e80cb --- /dev/null +++ b/config/initializers/assets.rb @@ -0,0 +1,14 @@ +# Be sure to restart your server when you modify this file. + +# Version of your assets, change this if you want to expire all your assets. +Rails.application.config.assets.version = '1.0' + +# Add additional assets to the asset load path. +# Rails.application.config.assets.paths << Emoji.images_path +# Add Yarn node_modules folder to the asset load path. +Rails.application.config.assets.paths << Rails.root.join('node_modules') + +# Precompile additional assets. +# application.js, application.css, and all non-JS/CSS in the app/assets +# folder are already added. +# Rails.application.config.assets.precompile += %w( admin.js admin.css ) diff --git a/config/initializers/backtrace_silencers.rb b/config/initializers/backtrace_silencers.rb new file mode 100644 index 0000000000..59385cdf37 --- /dev/null +++ b/config/initializers/backtrace_silencers.rb @@ -0,0 +1,7 @@ +# Be sure to restart your server when you modify this file. + +# You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces. +# Rails.backtrace_cleaner.add_silencer { |line| line =~ /my_noisy_library/ } + +# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code. +# Rails.backtrace_cleaner.remove_silencers! diff --git a/config/initializers/content_security_policy.rb b/config/initializers/content_security_policy.rb new file mode 100644 index 0000000000..d3bcaa5ec8 --- /dev/null +++ b/config/initializers/content_security_policy.rb @@ -0,0 +1,25 @@ +# Be sure to restart your server when you modify this file. + +# Define an application-wide content security policy +# For further information see the following documentation +# https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy + +# Rails.application.config.content_security_policy do |policy| +# policy.default_src :self, :https +# policy.font_src :self, :https, :data +# policy.img_src :self, :https, :data +# policy.object_src :none +# policy.script_src :self, :https +# policy.style_src :self, :https + +# # Specify URI for violation reports +# # policy.report_uri "/csp-violation-report-endpoint" +# end + +# If you are using UJS then enable automatic nonce generation +# Rails.application.config.content_security_policy_nonce_generator = -> request { SecureRandom.base64(16) } + +# Report CSP violations to a specified URI +# For further information see the following documentation: +# https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy-Report-Only +# Rails.application.config.content_security_policy_report_only = true diff --git a/config/initializers/cookies_serializer.rb b/config/initializers/cookies_serializer.rb new file mode 100644 index 0000000000..5a6a32d371 --- /dev/null +++ b/config/initializers/cookies_serializer.rb @@ -0,0 +1,5 @@ +# Be sure to restart your server when you modify this file. + +# Specify a serializer for the signed and encrypted cookie jars. +# Valid options are :json, :marshal, and :hybrid. +Rails.application.config.action_dispatch.cookies_serializer = :json diff --git a/config/initializers/filter_parameter_logging.rb b/config/initializers/filter_parameter_logging.rb new file mode 100644 index 0000000000..4a994e1e7b --- /dev/null +++ b/config/initializers/filter_parameter_logging.rb @@ -0,0 +1,4 @@ +# Be sure to restart your server when you modify this file. + +# Configure sensitive parameters which will be filtered from the log file. +Rails.application.config.filter_parameters += [:password] diff --git a/config/initializers/inflections.rb b/config/initializers/inflections.rb new file mode 100644 index 0000000000..ac033bf9dc --- /dev/null +++ b/config/initializers/inflections.rb @@ -0,0 +1,16 @@ +# Be sure to restart your server when you modify this file. + +# Add new inflection rules using the following format. Inflections +# are locale specific, and you may define rules for as many different +# locales as you wish. All of these examples are active by default: +# ActiveSupport::Inflector.inflections(:en) do |inflect| +# inflect.plural /^(ox)$/i, '\1en' +# inflect.singular /^(ox)en/i, '\1' +# inflect.irregular 'person', 'people' +# inflect.uncountable %w( fish sheep ) +# end + +# These inflection rules are supported but not enabled by default: +# ActiveSupport::Inflector.inflections(:en) do |inflect| +# inflect.acronym 'RESTful' +# end diff --git a/config/initializers/mime_types.rb b/config/initializers/mime_types.rb new file mode 100644 index 0000000000..dc1899682b --- /dev/null +++ b/config/initializers/mime_types.rb @@ -0,0 +1,4 @@ +# Be sure to restart your server when you modify this file. + +# Add new mime types for use in respond_to blocks: +# Mime::Type.register "text/richtext", :rtf diff --git a/config/initializers/wrap_parameters.rb b/config/initializers/wrap_parameters.rb new file mode 100644 index 0000000000..bbfc3961bf --- /dev/null +++ b/config/initializers/wrap_parameters.rb @@ -0,0 +1,14 @@ +# Be sure to restart your server when you modify this file. + +# This file contains settings for ActionController::ParamsWrapper which +# is enabled by default. + +# Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array. +ActiveSupport.on_load(:action_controller) do + wrap_parameters format: [:json] +end + +# To enable root element in JSON for ActiveRecord objects. +# ActiveSupport.on_load(:active_record) do +# self.include_root_in_json = true +# end diff --git a/config/locales/en.yml b/config/locales/en.yml new file mode 100644 index 0000000000..decc5a8573 --- /dev/null +++ b/config/locales/en.yml @@ -0,0 +1,33 @@ +# Files in the config/locales directory are used for internationalization +# and are automatically loaded by Rails. If you want to use locales other +# than English, add the necessary files in this directory. +# +# To use the locales, use `I18n.t`: +# +# I18n.t 'hello' +# +# In views, this is aliased to just `t`: +# +# <%= t('hello') %> +# +# To use a different locale, set it with `I18n.locale`: +# +# I18n.locale = :es +# +# This would use the information in config/locales/es.yml. +# +# The following keys must be escaped otherwise they will not be retrieved by +# the default I18n backend: +# +# true, false, on, off, yes, no +# +# Instead, surround them with single quotes. +# +# en: +# 'true': 'foo' +# +# To learn more, please read the Rails Internationalization guide +# available at http://guides.rubyonrails.org/i18n.html. + +en: + hello: "Hello world" diff --git a/config/puma.rb b/config/puma.rb new file mode 100644 index 0000000000..a5eccf816b --- /dev/null +++ b/config/puma.rb @@ -0,0 +1,34 @@ +# Puma can serve each request in a thread from an internal thread pool. +# The `threads` method setting takes two numbers: a minimum and maximum. +# Any libraries that use thread pools should be configured to match +# the maximum value specified for Puma. Default is set to 5 threads for minimum +# and maximum; this matches the default thread size of Active Record. +# +threads_count = ENV.fetch("RAILS_MAX_THREADS") { 5 } +threads threads_count, threads_count + +# Specifies the `port` that Puma will listen on to receive requests; default is 3000. +# +port ENV.fetch("PORT") { 3000 } + +# Specifies the `environment` that Puma will run in. +# +environment ENV.fetch("RAILS_ENV") { "development" } + +# Specifies the number of `workers` to boot in clustered mode. +# Workers are forked webserver processes. If using threads and workers together +# the concurrency of the application would be max `threads` * `workers`. +# Workers do not work on JRuby or Windows (both of which do not support +# processes). +# +# workers ENV.fetch("WEB_CONCURRENCY") { 2 } + +# Use the `preload_app!` method when specifying a `workers` number. +# This directive tells Puma to first boot the application and load code +# before forking the application. This takes advantage of Copy On Write +# process behavior so workers use less memory. +# +# preload_app! + +# Allow puma to be restarted by `rails restart` command. +plugin :tmp_restart diff --git a/config/routes.rb b/config/routes.rb new file mode 100644 index 0000000000..787824f888 --- /dev/null +++ b/config/routes.rb @@ -0,0 +1,3 @@ +Rails.application.routes.draw do + # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html +end diff --git a/config/spring.rb b/config/spring.rb new file mode 100644 index 0000000000..9fa7863f99 --- /dev/null +++ b/config/spring.rb @@ -0,0 +1,6 @@ +%w[ + .ruby-version + .rbenv-vars + tmp/restart.txt + tmp/caching-dev.txt +].each { |path| Spring.watch(path) } diff --git a/config/storage.yml b/config/storage.yml new file mode 100644 index 0000000000..d32f76e8fb --- /dev/null +++ b/config/storage.yml @@ -0,0 +1,34 @@ +test: + service: Disk + root: <%= Rails.root.join("tmp/storage") %> + +local: + service: Disk + root: <%= Rails.root.join("storage") %> + +# Use rails credentials:edit to set the AWS secrets (as aws:access_key_id|secret_access_key) +# amazon: +# service: S3 +# access_key_id: <%= Rails.application.credentials.dig(:aws, :access_key_id) %> +# secret_access_key: <%= Rails.application.credentials.dig(:aws, :secret_access_key) %> +# region: us-east-1 +# bucket: your_own_bucket + +# Remember not to checkin your GCS keyfile to a repository +# google: +# service: GCS +# project: your_project +# credentials: <%= Rails.root.join("path/to/gcs.keyfile") %> +# bucket: your_own_bucket + +# Use rails credentials:edit to set the Azure Storage secret (as azure_storage:storage_access_key) +# microsoft: +# service: AzureStorage +# storage_account_name: your_account_name +# storage_access_key: <%= Rails.application.credentials.dig(:azure_storage, :storage_access_key) %> +# container: your_container_name + +# mirror: +# service: Mirror +# primary: local +# mirrors: [ amazon, google, microsoft ] diff --git a/db/seeds.rb b/db/seeds.rb new file mode 100644 index 0000000000..1beea2accd --- /dev/null +++ b/db/seeds.rb @@ -0,0 +1,7 @@ +# This file should contain all the record creation needed to seed the database with its default values. +# The data can then be loaded with the rails db:seed command (or created alongside the database with db:setup). +# +# Examples: +# +# movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) +# Character.create(name: 'Luke', movie: movies.first) diff --git a/lib/assets/.keep b/lib/assets/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/lib/tasks/.keep b/lib/tasks/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/log/.keep b/log/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/package.json b/package.json new file mode 100644 index 0000000000..625900f9d8 --- /dev/null +++ b/package.json @@ -0,0 +1,5 @@ +{ + "name": "MediaRanker", + "private": true, + "dependencies": {} +} diff --git a/public/404.html b/public/404.html new file mode 100644 index 0000000000..2be3af26fc --- /dev/null +++ b/public/404.html @@ -0,0 +1,67 @@ + + + + The page you were looking for doesn't exist (404) + + + + + + +
+
+

The page you were looking for doesn't exist.

+

You may have mistyped the address or the page may have moved.

+
+

If you are the application owner check the logs for more information.

+
+ + diff --git a/public/422.html b/public/422.html new file mode 100644 index 0000000000..c08eac0d1d --- /dev/null +++ b/public/422.html @@ -0,0 +1,67 @@ + + + + The change you wanted was rejected (422) + + + + + + +
+
+

The change you wanted was rejected.

+

Maybe you tried to change something you didn't have access to.

+
+

If you are the application owner check the logs for more information.

+
+ + diff --git a/public/500.html b/public/500.html new file mode 100644 index 0000000000..78a030af22 --- /dev/null +++ b/public/500.html @@ -0,0 +1,66 @@ + + + + We're sorry, but something went wrong (500) + + + + + + +
+
+

We're sorry, but something went wrong.

+
+

If you are the application owner check the logs for more information.

+
+ + diff --git a/public/apple-touch-icon-precomposed.png b/public/apple-touch-icon-precomposed.png new file mode 100644 index 0000000000..e69de29bb2 diff --git a/public/apple-touch-icon.png b/public/apple-touch-icon.png new file mode 100644 index 0000000000..e69de29bb2 diff --git a/public/favicon.ico b/public/favicon.ico new file mode 100644 index 0000000000..e69de29bb2 diff --git a/public/robots.txt b/public/robots.txt new file mode 100644 index 0000000000..37b576a4a0 --- /dev/null +++ b/public/robots.txt @@ -0,0 +1 @@ +# See http://www.robotstxt.org/robotstxt.html for documentation on how to use the robots.txt file diff --git a/storage/.keep b/storage/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/application_system_test_case.rb b/test/application_system_test_case.rb new file mode 100644 index 0000000000..d19212abd5 --- /dev/null +++ b/test/application_system_test_case.rb @@ -0,0 +1,5 @@ +require "test_helper" + +class ApplicationSystemTestCase < ActionDispatch::SystemTestCase + driven_by :selenium, using: :chrome, screen_size: [1400, 1400] +end diff --git a/test/controllers/.keep b/test/controllers/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/fixtures/.keep b/test/fixtures/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/fixtures/files/.keep b/test/fixtures/files/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/helpers/.keep b/test/helpers/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/integration/.keep b/test/integration/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/mailers/.keep b/test/mailers/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/models/.keep b/test/models/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/system/.keep b/test/system/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/test/test_helper.rb b/test/test_helper.rb new file mode 100644 index 0000000000..2b5172a7d6 --- /dev/null +++ b/test/test_helper.rb @@ -0,0 +1,24 @@ +ENV["RAILS_ENV"] = "test" +require File.expand_path("../../config/environment", __FILE__) +require "rails/test_help" +require "minitest/rails"require "minitest/reporters" # for Colorized output +# For colorful output! +Minitest::Reporters.use!( + Minitest::Reporters::SpecReporter.new, + ENV, + Minitest.backtrace_filter +) + + +# To add Capybara feature tests add `gem "minitest-rails-capybara"` +# to the test group in the Gemfile and uncomment the following: +# require "minitest/rails/capybara" + +# Uncomment for awesome colorful output +# require "minitest/pride" + +class ActiveSupport::TestCase + # Setup all fixtures in test/fixtures/*.yml for all tests in alphabetical order. + fixtures :all + # Add more helper methods to be used by all tests here... +end diff --git a/tmp/.keep b/tmp/.keep new file mode 100644 index 0000000000..e69de29bb2 diff --git a/vendor/.keep b/vendor/.keep new file mode 100644 index 0000000000..e69de29bb2 From 08dc4715585ed635f0d43128488789175ce985fe Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 15:37:04 -0700 Subject: [PATCH 02/56] rough start, 3ed attempt =) --- config/routes.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/config/routes.rb b/config/routes.rb index 787824f888..1daf9a4121 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,3 +1,2 @@ Rails.application.routes.draw do - # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html end From fbb52ff6cc6dc389945c5660159b647d94fdd2ef Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 15:45:50 -0700 Subject: [PATCH 03/56] created controllers Users, Works, updated routes --- app/assets/javascripts/users.js | 2 ++ app/assets/javascripts/works.js | 2 ++ app/assets/stylesheets/users.scss | 3 ++ app/assets/stylesheets/works.scss | 3 ++ app/controllers/users_controller.rb | 13 +++++++++ app/controllers/works_controller.rb | 19 +++++++++++++ app/helpers/users_helper.rb | 2 ++ app/helpers/works_helper.rb | 2 ++ app/views/users/create.html.erb | 2 ++ app/views/users/index.html.erb | 2 ++ app/views/users/new.html.erb | 2 ++ app/views/users/show.html.erb | 2 ++ app/views/works/create.html.erb | 2 ++ app/views/works/edit.html.erb | 2 ++ app/views/works/index.html.erb | 2 ++ app/views/works/new.html.erb | 2 ++ app/views/works/show.html.erb | 2 ++ app/views/works/update.html.erb | 2 ++ config/routes.rb | 2 ++ test/controllers/users_controller_test.rb | 24 ++++++++++++++++ test/controllers/works_controller_test.rb | 34 +++++++++++++++++++++++ 21 files changed, 126 insertions(+) create mode 100644 app/assets/javascripts/users.js create mode 100644 app/assets/javascripts/works.js create mode 100644 app/assets/stylesheets/users.scss create mode 100644 app/assets/stylesheets/works.scss create mode 100644 app/controllers/users_controller.rb create mode 100644 app/controllers/works_controller.rb create mode 100644 app/helpers/users_helper.rb create mode 100644 app/helpers/works_helper.rb create mode 100644 app/views/users/create.html.erb create mode 100644 app/views/users/index.html.erb create mode 100644 app/views/users/new.html.erb create mode 100644 app/views/users/show.html.erb create mode 100644 app/views/works/create.html.erb create mode 100644 app/views/works/edit.html.erb create mode 100644 app/views/works/index.html.erb create mode 100644 app/views/works/new.html.erb create mode 100644 app/views/works/show.html.erb create mode 100644 app/views/works/update.html.erb create mode 100644 test/controllers/users_controller_test.rb create mode 100644 test/controllers/works_controller_test.rb diff --git a/app/assets/javascripts/users.js b/app/assets/javascripts/users.js new file mode 100644 index 0000000000..dee720facd --- /dev/null +++ b/app/assets/javascripts/users.js @@ -0,0 +1,2 @@ +// Place all the behaviors and hooks related to the matching controller here. +// All this logic will automatically be available in application.js. diff --git a/app/assets/javascripts/works.js b/app/assets/javascripts/works.js new file mode 100644 index 0000000000..dee720facd --- /dev/null +++ b/app/assets/javascripts/works.js @@ -0,0 +1,2 @@ +// Place all the behaviors and hooks related to the matching controller here. +// All this logic will automatically be available in application.js. diff --git a/app/assets/stylesheets/users.scss b/app/assets/stylesheets/users.scss new file mode 100644 index 0000000000..31a2eacb84 --- /dev/null +++ b/app/assets/stylesheets/users.scss @@ -0,0 +1,3 @@ +// Place all the styles related to the Users controller here. +// They will automatically be included in application.css. +// You can use Sass (SCSS) here: http://sass-lang.com/ diff --git a/app/assets/stylesheets/works.scss b/app/assets/stylesheets/works.scss new file mode 100644 index 0000000000..5618452f3e --- /dev/null +++ b/app/assets/stylesheets/works.scss @@ -0,0 +1,3 @@ +// Place all the styles related to the Works controller here. +// They will automatically be included in application.css. +// You can use Sass (SCSS) here: http://sass-lang.com/ diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb new file mode 100644 index 0000000000..a36e270505 --- /dev/null +++ b/app/controllers/users_controller.rb @@ -0,0 +1,13 @@ +class UsersController < ApplicationController + def index + end + + def show + end + + def new + end + + def create + end +end diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb new file mode 100644 index 0000000000..f3cd0de344 --- /dev/null +++ b/app/controllers/works_controller.rb @@ -0,0 +1,19 @@ +class WorksController < ApplicationController + def index + end + + def show + end + + def new + end + + def create + end + + def update + end + + def edit + end +end diff --git a/app/helpers/users_helper.rb b/app/helpers/users_helper.rb new file mode 100644 index 0000000000..2310a240d7 --- /dev/null +++ b/app/helpers/users_helper.rb @@ -0,0 +1,2 @@ +module UsersHelper +end diff --git a/app/helpers/works_helper.rb b/app/helpers/works_helper.rb new file mode 100644 index 0000000000..ccb78c2b73 --- /dev/null +++ b/app/helpers/works_helper.rb @@ -0,0 +1,2 @@ +module WorksHelper +end diff --git a/app/views/users/create.html.erb b/app/views/users/create.html.erb new file mode 100644 index 0000000000..48ea02e600 --- /dev/null +++ b/app/views/users/create.html.erb @@ -0,0 +1,2 @@ +

Users#create

+

Find me in app/views/users/create.html.erb

diff --git a/app/views/users/index.html.erb b/app/views/users/index.html.erb new file mode 100644 index 0000000000..51968c88d2 --- /dev/null +++ b/app/views/users/index.html.erb @@ -0,0 +1,2 @@ +

Users#index

+

Find me in app/views/users/index.html.erb

diff --git a/app/views/users/new.html.erb b/app/views/users/new.html.erb new file mode 100644 index 0000000000..c21a1adf19 --- /dev/null +++ b/app/views/users/new.html.erb @@ -0,0 +1,2 @@ +

Users#new

+

Find me in app/views/users/new.html.erb

diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb new file mode 100644 index 0000000000..e5fa3adf14 --- /dev/null +++ b/app/views/users/show.html.erb @@ -0,0 +1,2 @@ +

Users#show

+

Find me in app/views/users/show.html.erb

diff --git a/app/views/works/create.html.erb b/app/views/works/create.html.erb new file mode 100644 index 0000000000..5bc7fb6058 --- /dev/null +++ b/app/views/works/create.html.erb @@ -0,0 +1,2 @@ +

Works#create

+

Find me in app/views/works/create.html.erb

diff --git a/app/views/works/edit.html.erb b/app/views/works/edit.html.erb new file mode 100644 index 0000000000..b717b97f84 --- /dev/null +++ b/app/views/works/edit.html.erb @@ -0,0 +1,2 @@ +

Works#edit

+

Find me in app/views/works/edit.html.erb

diff --git a/app/views/works/index.html.erb b/app/views/works/index.html.erb new file mode 100644 index 0000000000..e519642270 --- /dev/null +++ b/app/views/works/index.html.erb @@ -0,0 +1,2 @@ +

Works#index

+

Find me in app/views/works/index.html.erb

diff --git a/app/views/works/new.html.erb b/app/views/works/new.html.erb new file mode 100644 index 0000000000..fad0dfea61 --- /dev/null +++ b/app/views/works/new.html.erb @@ -0,0 +1,2 @@ +

Works#new

+

Find me in app/views/works/new.html.erb

diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb new file mode 100644 index 0000000000..c096804302 --- /dev/null +++ b/app/views/works/show.html.erb @@ -0,0 +1,2 @@ +

Works#show

+

Find me in app/views/works/show.html.erb

diff --git a/app/views/works/update.html.erb b/app/views/works/update.html.erb new file mode 100644 index 0000000000..171f6d1516 --- /dev/null +++ b/app/views/works/update.html.erb @@ -0,0 +1,2 @@ +

Works#update

+

Find me in app/views/works/update.html.erb

diff --git a/config/routes.rb b/config/routes.rb index 1daf9a4121..b48ba23bb8 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,2 +1,4 @@ Rails.application.routes.draw do + resources :works + resources :users, except: [:edit, :update] end diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb new file mode 100644 index 0000000000..dcbb88d675 --- /dev/null +++ b/test/controllers/users_controller_test.rb @@ -0,0 +1,24 @@ +require "test_helper" + +describe UsersController do + it "should get index" do + get users_index_url + value(response).must_be :success? + end + + it "should get show" do + get users_show_url + value(response).must_be :success? + end + + it "should get new" do + get users_new_url + value(response).must_be :success? + end + + it "should get create" do + get users_create_url + value(response).must_be :success? + end + +end diff --git a/test/controllers/works_controller_test.rb b/test/controllers/works_controller_test.rb new file mode 100644 index 0000000000..47edb841b1 --- /dev/null +++ b/test/controllers/works_controller_test.rb @@ -0,0 +1,34 @@ +require "test_helper" + +describe WorksController do + it "should get index" do + get works_index_url + value(response).must_be :success? + end + + it "should get show" do + get works_show_url + value(response).must_be :success? + end + + it "should get new" do + get works_new_url + value(response).must_be :success? + end + + it "should get create" do + get works_create_url + value(response).must_be :success? + end + + it "should get update" do + get works_update_url + value(response).must_be :success? + end + + it "should get edit" do + get works_edit_url + value(response).must_be :success? + end + +end From d3560b94eae38fdc3a73cabff42518126294ff08 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 15:47:20 -0700 Subject: [PATCH 04/56] deleted extra views (update/create) --- app/views/users/create.html.erb | 2 -- app/views/works/create.html.erb | 2 -- app/views/works/update.html.erb | 2 -- 3 files changed, 6 deletions(-) delete mode 100644 app/views/users/create.html.erb delete mode 100644 app/views/works/create.html.erb delete mode 100644 app/views/works/update.html.erb diff --git a/app/views/users/create.html.erb b/app/views/users/create.html.erb deleted file mode 100644 index 48ea02e600..0000000000 --- a/app/views/users/create.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

Users#create

-

Find me in app/views/users/create.html.erb

diff --git a/app/views/works/create.html.erb b/app/views/works/create.html.erb deleted file mode 100644 index 5bc7fb6058..0000000000 --- a/app/views/works/create.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

Works#create

-

Find me in app/views/works/create.html.erb

diff --git a/app/views/works/update.html.erb b/app/views/works/update.html.erb deleted file mode 100644 index 171f6d1516..0000000000 --- a/app/views/works/update.html.erb +++ /dev/null @@ -1,2 +0,0 @@ -

Works#update

-

Find me in app/views/works/update.html.erb

From 7d8e0ca5eefe415a977820d5e6dcfda75abbc842 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 15:49:34 -0700 Subject: [PATCH 05/56] user model --- app/models/user.rb | 2 ++ db/migrate/20190422224858_create_users.rb | 9 +++++++++ db/schema.rb | 24 +++++++++++++++++++++++ test/fixtures/users.yml | 7 +++++++ test/models/user_test.rb | 9 +++++++++ 5 files changed, 51 insertions(+) create mode 100644 app/models/user.rb create mode 100644 db/migrate/20190422224858_create_users.rb create mode 100644 db/schema.rb create mode 100644 test/fixtures/users.yml create mode 100644 test/models/user_test.rb diff --git a/app/models/user.rb b/app/models/user.rb new file mode 100644 index 0000000000..379658a509 --- /dev/null +++ b/app/models/user.rb @@ -0,0 +1,2 @@ +class User < ApplicationRecord +end diff --git a/db/migrate/20190422224858_create_users.rb b/db/migrate/20190422224858_create_users.rb new file mode 100644 index 0000000000..ad388a5465 --- /dev/null +++ b/db/migrate/20190422224858_create_users.rb @@ -0,0 +1,9 @@ +class CreateUsers < ActiveRecord::Migration[5.2] + def change + create_table :users do |t| + t.string :name + + t.timestamps + end + end +end diff --git a/db/schema.rb b/db/schema.rb new file mode 100644 index 0000000000..94073a3f2c --- /dev/null +++ b/db/schema.rb @@ -0,0 +1,24 @@ +# This file is auto-generated from the current state of the database. Instead +# of editing this file, please use the migrations feature of Active Record to +# incrementally modify your database, and then regenerate this schema definition. +# +# Note that this schema.rb definition is the authoritative source for your +# database schema. If you need to create the application database on another +# system, you should be using db:schema:load, not running all the migrations +# from scratch. The latter is a flawed and unsustainable approach (the more migrations +# you'll amass, the slower it'll run and the greater likelihood for issues). +# +# It's strongly recommended that you check this file into your version control system. + +ActiveRecord::Schema.define(version: 2019_04_22_224858) do + + # These are extensions that must be enabled in order to support this database + enable_extension "plpgsql" + + create_table "users", force: :cascade do |t| + t.string "name" + t.datetime "created_at", null: false + t.datetime "updated_at", null: false + end + +end diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml new file mode 100644 index 0000000000..56066c68af --- /dev/null +++ b/test/fixtures/users.yml @@ -0,0 +1,7 @@ +# Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html + +one: + name: MyString + +two: + name: MyString diff --git a/test/models/user_test.rb b/test/models/user_test.rb new file mode 100644 index 0000000000..cc862ac2d9 --- /dev/null +++ b/test/models/user_test.rb @@ -0,0 +1,9 @@ +require "test_helper" + +describe User do + let(:user) { User.new } + + it "must be valid" do + value(user).must_be :valid? + end +end From 95fa21a31fa5d944021f7c20c2adec8c484760f8 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 16:02:53 -0700 Subject: [PATCH 06/56] added works model and join table works_users --- app/models/work.rb | 2 ++ db/migrate/20190422225408_create_works.rb | 13 +++++++++++++ ...0190422225624_create_join_table_user_work.rb | 8 ++++++++ db/schema.rb | 17 ++++++++++++++++- test/fixtures/works.yml | 15 +++++++++++++++ test/models/work_test.rb | 9 +++++++++ 6 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 app/models/work.rb create mode 100644 db/migrate/20190422225408_create_works.rb create mode 100644 db/migrate/20190422225624_create_join_table_user_work.rb create mode 100644 test/fixtures/works.yml create mode 100644 test/models/work_test.rb diff --git a/app/models/work.rb b/app/models/work.rb new file mode 100644 index 0000000000..95322dd45e --- /dev/null +++ b/app/models/work.rb @@ -0,0 +1,2 @@ +class Work < ApplicationRecord +end diff --git a/db/migrate/20190422225408_create_works.rb b/db/migrate/20190422225408_create_works.rb new file mode 100644 index 0000000000..d6e24fdb58 --- /dev/null +++ b/db/migrate/20190422225408_create_works.rb @@ -0,0 +1,13 @@ +class CreateWorks < ActiveRecord::Migration[5.2] + def change + create_table :works do |t| + t.string :category + t.string :title + t.string :creator + t.integer :publication_year + t.string :description + + t.timestamps + end + end +end diff --git a/db/migrate/20190422225624_create_join_table_user_work.rb b/db/migrate/20190422225624_create_join_table_user_work.rb new file mode 100644 index 0000000000..04a99c0aea --- /dev/null +++ b/db/migrate/20190422225624_create_join_table_user_work.rb @@ -0,0 +1,8 @@ +class CreateJoinTableUserWork < ActiveRecord::Migration[5.2] + def change + create_join_table :users, :works do |t| + # t.index [:user_id, :work_id] + # t.index [:work_id, :user_id] + end + end +end diff --git a/db/schema.rb b/db/schema.rb index 94073a3f2c..2c8ef99e09 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2019_04_22_224858) do +ActiveRecord::Schema.define(version: 2019_04_22_225624) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -21,4 +21,19 @@ t.datetime "updated_at", null: false end + create_table "users_works", id: false, force: :cascade do |t| + t.bigint "user_id", null: false + t.bigint "work_id", null: false + end + + create_table "works", force: :cascade do |t| + t.string "category" + t.string "title" + t.string "creator" + t.integer "publication_year" + t.string "description" + t.datetime "created_at", null: false + t.datetime "updated_at", null: false + end + end diff --git a/test/fixtures/works.yml b/test/fixtures/works.yml new file mode 100644 index 0000000000..6772d84de5 --- /dev/null +++ b/test/fixtures/works.yml @@ -0,0 +1,15 @@ +# Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html + +one: + category: MyString + title: MyString + creator: MyString + publication_year: 1 + description: MyString + +two: + category: MyString + title: MyString + creator: MyString + publication_year: 1 + description: MyString diff --git a/test/models/work_test.rb b/test/models/work_test.rb new file mode 100644 index 0000000000..f6fba7104d --- /dev/null +++ b/test/models/work_test.rb @@ -0,0 +1,9 @@ +require "test_helper" + +describe Work do + let(:work) { Work.new } + + it "must be valid" do + value(work).must_be :valid? + end +end From 3ebadb16a25adca90cfd82e28ca9c5b98b53661a Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 16:11:58 -0700 Subject: [PATCH 07/56] updated models with relationship has_and_belongs_to_many --- app/models/user.rb | 1 + app/models/work.rb | 1 + db/migrate/20190422225624_create_join_table_user_work.rb | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/models/user.rb b/app/models/user.rb index 379658a509..1b8faf48ab 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,2 +1,3 @@ class User < ApplicationRecord + has_and_belongs_to_many :works end diff --git a/app/models/work.rb b/app/models/work.rb index 95322dd45e..e7b8759280 100644 --- a/app/models/work.rb +++ b/app/models/work.rb @@ -1,2 +1,3 @@ class Work < ApplicationRecord + has_and_belongs_to_many :users end diff --git a/db/migrate/20190422225624_create_join_table_user_work.rb b/db/migrate/20190422225624_create_join_table_user_work.rb index 04a99c0aea..b482c57723 100644 --- a/db/migrate/20190422225624_create_join_table_user_work.rb +++ b/db/migrate/20190422225624_create_join_table_user_work.rb @@ -1,7 +1,7 @@ class CreateJoinTableUserWork < ActiveRecord::Migration[5.2] def change create_join_table :users, :works do |t| - # t.index [:user_id, :work_id] + t.index [:user_id, :work_id] # t.index [:work_id, :user_id] end end From edb64d7c0e5aea77ad37820e7628682958cb1ede Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 16:35:26 -0700 Subject: [PATCH 08/56] added fixtures --- app/models/user.rb | 2 ++ app/models/work.rb | 3 +++ test/fixtures/users.yml | 4 ++-- test/fixtures/works.yml | 20 ++++++++++---------- 4 files changed, 17 insertions(+), 12 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index 1b8faf48ab..22e91df488 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,3 +1,5 @@ class User < ApplicationRecord has_and_belongs_to_many :works + + validates :name, presence: true, uniqueness: true end diff --git a/app/models/work.rb b/app/models/work.rb index e7b8759280..cfac69486b 100644 --- a/app/models/work.rb +++ b/app/models/work.rb @@ -1,3 +1,6 @@ class Work < ApplicationRecord has_and_belongs_to_many :users + + validates :title, presence: true, uniqueness: true + validates :category, presence: true end diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml index 56066c68af..0b5a585b84 100644 --- a/test/fixtures/users.yml +++ b/test/fixtures/users.yml @@ -1,7 +1,7 @@ # Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html one: - name: MyString + name: Sam two: - name: MyString + name: Penny diff --git a/test/fixtures/works.yml b/test/fixtures/works.yml index 6772d84de5..b563e22a17 100644 --- a/test/fixtures/works.yml +++ b/test/fixtures/works.yml @@ -1,15 +1,15 @@ # Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html one: - category: MyString - title: MyString - creator: MyString - publication_year: 1 - description: MyString + category: Movie + title: Jungle Book + creator: moglue + publication_year: 1991 + description: boy fights tiger two: - category: MyString - title: MyString - creator: MyString - publication_year: 1 - description: MyString + category: book + title: POODR + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP From 90f1554286d6848cc660fccf3d6e2360782a598b Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 22 Apr 2019 16:53:43 -0700 Subject: [PATCH 09/56] added tests for user model --- test/models/user_test.rb | 35 ++++++++++++++++++++++++++++++++--- test/test_helper.rb | 4 ++-- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/test/models/user_test.rb b/test/models/user_test.rb index cc862ac2d9..637b77df8b 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -1,9 +1,38 @@ require "test_helper" describe User do - let(:user) { User.new } + let(:user) { users(:one) } + let(:work) { works(:one) } + describe "Validations" do + it "will be valid" do + expect(user.valid?).must_equal true + end - it "must be valid" do - value(user).must_be :valid? + it "will not be valid without name" do + user.name = nil + expect(user.save).must_equal false + end + + it "will not be valid with same name twice" do + user_new = User.new(name: user.name) + expect(user_new.save).must_equal false + end + end + + describe "relations" do + it "will have 0 works" do + expect(user.works).must_equal [] + end + + it "will have 1 or many works" do + user.works << work + expect(user.works).must_include work + expect(user.works.last.id).must_equal work.id + expect(work.users).must_include user + expect(work.users.last.id).must_equal user.id + end + end + + describe "custom exceptions" do end end diff --git a/test/test_helper.rb b/test/test_helper.rb index 2b5172a7d6..3f7dc7d3ed 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -1,7 +1,8 @@ ENV["RAILS_ENV"] = "test" require File.expand_path("../../config/environment", __FILE__) require "rails/test_help" -require "minitest/rails"require "minitest/reporters" # for Colorized output +require "minitest/rails" +require "minitest/reporters" # for Colorized output # For colorful output! Minitest::Reporters.use!( Minitest::Reporters::SpecReporter.new, @@ -9,7 +10,6 @@ Minitest.backtrace_filter ) - # To add Capybara feature tests add `gem "minitest-rails-capybara"` # to the test group in the Gemfile and uncomment the following: # require "minitest/rails/capybara" From 5c19ed487be075915c08e68d56e031738d86862b Mon Sep 17 00:00:00 2001 From: qqdipps Date: Tue, 23 Apr 2019 08:33:41 -0700 Subject: [PATCH 10/56] created seed file --- Gemfile | 2 ++ Gemfile.lock | 2 ++ db/seeds.rb | 16 +++++++++++++++ test/models/user_test.rb | 2 +- test/models/work_test.rb | 42 ++++++++++++++++++++++++++++++++++++---- 5 files changed, 59 insertions(+), 5 deletions(-) diff --git a/Gemfile b/Gemfile index 80be142348..c997ffc0dc 100644 --- a/Gemfile +++ b/Gemfile @@ -79,3 +79,5 @@ group :test do gem 'minitest-rails' gem 'minitest-reporters' end + +gem 'csv' \ No newline at end of file diff --git a/Gemfile.lock b/Gemfile.lock index 800e2e5b40..189f16ad50 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -81,6 +81,7 @@ GEM coderay (1.1.2) concurrent-ruby (1.1.5) crass (1.0.4) + csv (3.0.4) debug_inspector (0.0.3) erubi (1.8.0) execjs (2.7.0) @@ -251,6 +252,7 @@ DEPENDENCIES byebug capybara (>= 2.15) chromedriver-helper + csv guard guard-minitest jbuilder (~> 2.5) diff --git a/db/seeds.rb b/db/seeds.rb index 1beea2accd..ae77895dbb 100644 --- a/db/seeds.rb +++ b/db/seeds.rb @@ -5,3 +5,19 @@ # # movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }]) # Character.create(name: 'Luke', movie: movies.first) + +failed_to_save = [] +CSV.open("db/media_seeds.csv", headers: true).each_with_index do |line, i| + media = Work.new(category: line["category"], + title: line["title"], + creator: line["creator"], + publication_year: line["publication_year"], + description: line["description"]) + if media.save + puts "#{i + 1} #{media} successfully saved" + else + failed_to_save << media + end +end + +puts "#{failed_to_save.count} FAILED TO SAVE" diff --git a/test/models/user_test.rb b/test/models/user_test.rb index 637b77df8b..e808672a69 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -33,6 +33,6 @@ end end - describe "custom exceptions" do + describe "custom methods" do end end diff --git a/test/models/work_test.rb b/test/models/work_test.rb index f6fba7104d..ffd5f2e207 100644 --- a/test/models/work_test.rb +++ b/test/models/work_test.rb @@ -1,9 +1,43 @@ require "test_helper" -describe Work do - let(:work) { Work.new } +describe User do + let(:user) { users(:one) } + let(:work) { works(:one) } + describe "Validations" do + it "will be valid" do + expect(work.valid?).must_equal true + end - it "must be valid" do - value(work).must_be :valid? + it "will not be valid without title" do + work.title = nil + expect(work.save).must_equal false + end + + it "will not be valid without category" do + work.category = nil + expect(work.save).must_equal false + end + + it "will not be valid with same title twice" do + work_new = Work.new(title: work.title, category: "book") + expect(work_new.save).must_equal false + end + end + + describe "relations" do + it "will have 0 users" do + expect(work.users).must_equal [] + end + + it "will have 1 or many users" do + work.users << user + expect(work.users).must_include user + expect(work.users.last.id).must_equal user.id + expect(user.works).must_include work + expect(user.works.last.id).must_equal work.id + end + end + + describe "custom methos" do end end From 4e0b1fb7d4ab41e439b3dd863297efe01ff36c09 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Tue, 23 Apr 2019 09:45:55 -0700 Subject: [PATCH 11/56] dropped join table --- app/controllers/users_controller.rb | 1 + app/controllers/works_controller.rb | 1 + app/views/users/index.html.erb | 3 ++ app/views/works/index.html.erb | 3 ++ db/migrate/20190423163815_drop_users_works.rb | 5 ++ .../20190423164110_drop_users_works2.rb | 5 ++ db/schema.rb | 7 +-- test/controllers/users_controller_test.rb | 33 +++++++------ test/controllers/works_controller_test.rb | 48 ++++++++++--------- 9 files changed, 62 insertions(+), 44 deletions(-) create mode 100644 db/migrate/20190423163815_drop_users_works.rb create mode 100644 db/migrate/20190423164110_drop_users_works2.rb diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index a36e270505..f81d26a935 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,5 +1,6 @@ class UsersController < ApplicationController def index + @users = User.all end def show diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index f3cd0de344..ca7c8135ec 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -1,5 +1,6 @@ class WorksController < ApplicationController def index + @works = Work.all end def show diff --git a/app/views/users/index.html.erb b/app/views/users/index.html.erb index 51968c88d2..b252f62af4 100644 --- a/app/views/users/index.html.erb +++ b/app/views/users/index.html.erb @@ -1,2 +1,5 @@

Users#index

Find me in app/views/users/index.html.erb

+<%@users.each do |user|%> + <%= user.name %> +<%end%> \ No newline at end of file diff --git a/app/views/works/index.html.erb b/app/views/works/index.html.erb index e519642270..1fb05ce36e 100644 --- a/app/views/works/index.html.erb +++ b/app/views/works/index.html.erb @@ -1,2 +1,5 @@

Works#index

Find me in app/views/works/index.html.erb

+<%@works.each do |work|%> + <%= work.name %> +<%end%> \ No newline at end of file diff --git a/db/migrate/20190423163815_drop_users_works.rb b/db/migrate/20190423163815_drop_users_works.rb new file mode 100644 index 0000000000..c4bfae51c9 --- /dev/null +++ b/db/migrate/20190423163815_drop_users_works.rb @@ -0,0 +1,5 @@ +class DropUsersWorks < ActiveRecord::Migration[5.2] + def down + drop_table :users_works + end +end diff --git a/db/migrate/20190423164110_drop_users_works2.rb b/db/migrate/20190423164110_drop_users_works2.rb new file mode 100644 index 0000000000..56459b3e74 --- /dev/null +++ b/db/migrate/20190423164110_drop_users_works2.rb @@ -0,0 +1,5 @@ +class DropUsersWorks2 < ActiveRecord::Migration[5.2] + def change + drop_join_table :users, :works + end +end diff --git a/db/schema.rb b/db/schema.rb index 2c8ef99e09..ed87725ceb 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2019_04_22_225624) do +ActiveRecord::Schema.define(version: 2019_04_23_164110) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -21,11 +21,6 @@ t.datetime "updated_at", null: false end - create_table "users_works", id: false, force: :cascade do |t| - t.bigint "user_id", null: false - t.bigint "work_id", null: false - end - create_table "works", force: :cascade do |t| t.string "category" t.string "title" diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index dcbb88d675..1e1cc61d1f 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -1,24 +1,27 @@ require "test_helper" describe UsersController do - it "should get index" do - get users_index_url - value(response).must_be :success? + describe "users#index" do + it "should get index" do + get users_path + must_respond_with :success + end end - it "should get show" do - get users_show_url - value(response).must_be :success? - end + # it "should get show" do + # get users_show_url + # value(response).must_be :success? + # end - it "should get new" do - get users_new_url - value(response).must_be :success? - end + # it "should get new" do + # get users_new_url + # value(response).must_be :success? + # end - it "should get create" do - get users_create_url - value(response).must_be :success? - end + # it "should get create" do + # get users_create_url + # value(response).must_be :success? + # end + # end end diff --git a/test/controllers/works_controller_test.rb b/test/controllers/works_controller_test.rb index 47edb841b1..b0e33c8e70 100644 --- a/test/controllers/works_controller_test.rb +++ b/test/controllers/works_controller_test.rb @@ -1,34 +1,36 @@ require "test_helper" describe WorksController do - it "should get index" do - get works_index_url - value(response).must_be :success? + describe "works#index" do + it "should get index" do + get works_path + must_respond_with :success + end end - it "should get show" do - get works_show_url - value(response).must_be :success? - end - it "should get new" do - get works_new_url - value(response).must_be :success? - end + # it "should get show" do + # get works_show_url + # value(response).must_be :success? + # end - it "should get create" do - get works_create_url - value(response).must_be :success? - end + # it "should get new" do + # get works_new_url + # value(response).must_be :success? + # end - it "should get update" do - get works_update_url - value(response).must_be :success? - end + # it "should get create" do + # get works_create_url + # value(response).must_be :success? + # end - it "should get edit" do - get works_edit_url - value(response).must_be :success? - end + # it "should get update" do + # get works_update_url + # value(response).must_be :success? + # end + # it "should get edit" do + # get works_edit_url + # value(response).must_be :success? + # end end From b45223f601f247a880eb4dd7f605f051d79ae2bb Mon Sep 17 00:00:00 2001 From: qqdipps Date: Wed, 24 Apr 2019 08:24:37 -0700 Subject: [PATCH 12/56] added votes --- app/models/vote.rb | 2 ++ db/migrate/20190424152230_create_votes.rb | 8 ++++++++ db/schema.rb | 7 ++++++- test/fixtures/votes.yml | 11 +++++++++++ test/models/vote_test.rb | 9 +++++++++ 5 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 app/models/vote.rb create mode 100644 db/migrate/20190424152230_create_votes.rb create mode 100644 test/fixtures/votes.yml create mode 100644 test/models/vote_test.rb diff --git a/app/models/vote.rb b/app/models/vote.rb new file mode 100644 index 0000000000..4c58e4f3d5 --- /dev/null +++ b/app/models/vote.rb @@ -0,0 +1,2 @@ +class Vote < ApplicationRecord +end diff --git a/db/migrate/20190424152230_create_votes.rb b/db/migrate/20190424152230_create_votes.rb new file mode 100644 index 0000000000..aa134a1296 --- /dev/null +++ b/db/migrate/20190424152230_create_votes.rb @@ -0,0 +1,8 @@ +class CreateVotes < ActiveRecord::Migration[5.2] + def change + create_table :votes do |t| + + t.timestamps + end + end +end diff --git a/db/schema.rb b/db/schema.rb index ed87725ceb..0425c5d37b 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2019_04_23_164110) do +ActiveRecord::Schema.define(version: 2019_04_24_152230) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -21,6 +21,11 @@ t.datetime "updated_at", null: false end + create_table "votes", force: :cascade do |t| + t.datetime "created_at", null: false + t.datetime "updated_at", null: false + end + create_table "works", force: :cascade do |t| t.string "category" t.string "title" diff --git a/test/fixtures/votes.yml b/test/fixtures/votes.yml new file mode 100644 index 0000000000..dc3ee79b5d --- /dev/null +++ b/test/fixtures/votes.yml @@ -0,0 +1,11 @@ +# Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html + +# This model initially had no columns defined. If you add columns to the +# model remove the "{}" from the fixture names and add the columns immediately +# below each fixture, per the syntax in the comments below +# +one: {} +# column: value +# +two: {} +# column: value diff --git a/test/models/vote_test.rb b/test/models/vote_test.rb new file mode 100644 index 0000000000..fc15947bd3 --- /dev/null +++ b/test/models/vote_test.rb @@ -0,0 +1,9 @@ +require "test_helper" + +describe Vote do + let(:vote) { Vote.new } + + it "must be valid" do + value(vote).must_be :valid? + end +end From ee2dd0670effacd01aa71aa3aab52e6a8b77b206 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Wed, 24 Apr 2019 08:28:23 -0700 Subject: [PATCH 13/56] added foriegn key ref to votes --- db/migrate/20190424152505_add_user_ref_to_votes.rb | 5 +++++ db/migrate/20190424152640_add_workr_ref_to_votes.rb | 5 +++++ db/schema.rb | 7 +++++-- 3 files changed, 15 insertions(+), 2 deletions(-) create mode 100644 db/migrate/20190424152505_add_user_ref_to_votes.rb create mode 100644 db/migrate/20190424152640_add_workr_ref_to_votes.rb diff --git a/db/migrate/20190424152505_add_user_ref_to_votes.rb b/db/migrate/20190424152505_add_user_ref_to_votes.rb new file mode 100644 index 0000000000..0f035ec1b2 --- /dev/null +++ b/db/migrate/20190424152505_add_user_ref_to_votes.rb @@ -0,0 +1,5 @@ +class AddUserRefToVotes < ActiveRecord::Migration[5.2] + def change + add_reference :votes, :user, foriegn_key: true + end +end diff --git a/db/migrate/20190424152640_add_workr_ref_to_votes.rb b/db/migrate/20190424152640_add_workr_ref_to_votes.rb new file mode 100644 index 0000000000..bf9fee8ebf --- /dev/null +++ b/db/migrate/20190424152640_add_workr_ref_to_votes.rb @@ -0,0 +1,5 @@ +class AddWorkrRefToVotes < ActiveRecord::Migration[5.2] + def change + add_reference :votes, :work, foriegn_key: true + end +end diff --git a/db/schema.rb b/db/schema.rb index 0425c5d37b..56e593edd6 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,7 +10,7 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2019_04_24_152230) do +ActiveRecord::Schema.define(version: 2019_04_24_152640) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" @@ -24,6 +24,10 @@ create_table "votes", force: :cascade do |t| t.datetime "created_at", null: false t.datetime "updated_at", null: false + t.bigint "user_id" + t.bigint "work_id" + t.index ["user_id"], name: "index_votes_on_user_id" + t.index ["work_id"], name: "index_votes_on_work_id" end create_table "works", force: :cascade do |t| @@ -35,5 +39,4 @@ t.datetime "created_at", null: false t.datetime "updated_at", null: false end - end From b775882439e3c06804d423f8f82ef1854bb5663e Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 18:59:20 -0700 Subject: [PATCH 14/56] added votes table, and updated model testing --- app/models/user.rb | 3 ++- app/models/vote.rb | 4 ++++ app/models/work.rb | 3 ++- test/fixtures/users.yml | 2 ++ test/fixtures/votes.yml | 13 ++++++++----- test/fixtures/works.yml | 2 ++ test/models/user_test.rb | 12 +++++++----- test/models/vote_test.rb | 36 ++++++++++++++++++++++++++++++++++-- test/models/work_test.rb | 22 ++++++++++++++-------- 9 files changed, 75 insertions(+), 22 deletions(-) diff --git a/app/models/user.rb b/app/models/user.rb index 22e91df488..a05b4d8f9d 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,5 +1,6 @@ class User < ApplicationRecord - has_and_belongs_to_many :works + has_many :votes + has_many :works, through: :votes validates :name, presence: true, uniqueness: true end diff --git a/app/models/vote.rb b/app/models/vote.rb index 4c58e4f3d5..6b23826d35 100644 --- a/app/models/vote.rb +++ b/app/models/vote.rb @@ -1,2 +1,6 @@ class Vote < ApplicationRecord + belongs_to :user + belongs_to :work + + validates :user, presence: true, uniqueness: { scope: [:work] } end diff --git a/app/models/work.rb b/app/models/work.rb index cfac69486b..79c60c5802 100644 --- a/app/models/work.rb +++ b/app/models/work.rb @@ -1,5 +1,6 @@ class Work < ApplicationRecord - has_and_belongs_to_many :users + has_many :votes + has_many :users, through: :votes validates :title, presence: true, uniqueness: true validates :category, presence: true diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml index 0b5a585b84..bbb730c6eb 100644 --- a/test/fixtures/users.yml +++ b/test/fixtures/users.yml @@ -2,6 +2,8 @@ one: name: Sam + id: 1 two: name: Penny + id: 2 diff --git a/test/fixtures/votes.yml b/test/fixtures/votes.yml index dc3ee79b5d..fa15ee6c96 100644 --- a/test/fixtures/votes.yml +++ b/test/fixtures/votes.yml @@ -4,8 +4,11 @@ # model remove the "{}" from the fixture names and add the columns immediately # below each fixture, per the syntax in the comments below # -one: {} -# column: value -# -two: {} -# column: value +one: + user_id: 1 + work_id: 1 + +two: + user_id: 2 + work_id: 2 + diff --git a/test/fixtures/works.yml b/test/fixtures/works.yml index b563e22a17..577f39ea23 100644 --- a/test/fixtures/works.yml +++ b/test/fixtures/works.yml @@ -6,6 +6,7 @@ one: creator: moglue publication_year: 1991 description: boy fights tiger + id: 1 two: category: book @@ -13,3 +14,4 @@ two: creator: Metz Sandi publication_year: 2011 description: Book on OOP + id: 2 diff --git a/test/models/user_test.rb b/test/models/user_test.rb index e808672a69..760b8601b9 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -20,14 +20,16 @@ end describe "relations" do - it "will have 0 works" do - expect(user.works).must_equal [] + it "will have 0 votes" do + user = User.new(name: "no votes") + expect(user.votes).must_equal [] end - it "will have 1 or many works" do - user.works << work + it "will have 1 or more works through votes" do + user.votes << votes(:two) + expect(user.votes.find_by(user_id: work.id).work_id).must_equal work.id expect(user.works).must_include work - expect(user.works.last.id).must_equal work.id + expect(user.works.find(work.id).id).must_equal work.id expect(work.users).must_include user expect(work.users.last.id).must_equal user.id end diff --git a/test/models/vote_test.rb b/test/models/vote_test.rb index fc15947bd3..c0f7cbc2ff 100644 --- a/test/models/vote_test.rb +++ b/test/models/vote_test.rb @@ -1,9 +1,41 @@ require "test_helper" describe Vote do - let(:vote) { Vote.new } + let(:vote) { votes(:one) } it "must be valid" do - value(vote).must_be :valid? + expect(vote.valid?).must_equal true + end + + describe "validations" do + it "will not be valid without user" do + vote.user = nil + expect(vote.valid?).must_equal false + end + + it "will not be valid with out works" do + vote.work = nil + expect(vote.valid?).must_equal false + end + + it "will not be valid when another vote has same user and same works " do + new_vote = Vote.new(user_id: vote.user.id, work_id: vote.work.id) + expect(new_vote.save).must_equal false + end + + # will do this in controller create action for vote. + it "will be valid when only user OR works is repeated" do + new_vote = Vote.new(user: users(:two), work: vote.work) + expect(new_vote.save).must_equal true + end + end + describe "relationships" do + it "will have one user" do + expect(vote.user).must_equal users(:one) + end + + it "will have one vote" do + expect(vote.work).must_equal works(:one) + end end end diff --git a/test/models/work_test.rb b/test/models/work_test.rb index ffd5f2e207..aecb8af627 100644 --- a/test/models/work_test.rb +++ b/test/models/work_test.rb @@ -25,19 +25,25 @@ end describe "relations" do - it "will have 0 users" do - expect(work.users).must_equal [] + it "can have no votes" do + work = Work.new(title: "Something Else", category: "book") + expect(work.votes.to_a).must_equal [] end - it "will have 1 or many users" do - work.users << user - expect(work.users).must_include user - expect(work.users.last.id).must_equal user.id + it "will have one or more votes" do + work.votes << votes(:two) + expect(work.votes.to_a).must_equal [votes(:one), votes(:two)] + end + + it "will have relationship through votes with users" do #may need to add additional tests here + work.votes << votes(:two) + expect(work.votes.find_by(user_id: user.id).user_id).must_equal user.id + expect(work.users.include?(user)).must_equal true expect(user.works).must_include work - expect(user.works.last.id).must_equal work.id + expect(work.users).must_include user end end - describe "custom methos" do + describe "custom methods" do end end From df17a32e53e5a930cf2dfdf8e4b3bfa40fb28dc0 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 19:00:22 -0700 Subject: [PATCH 15/56] finished votes --- test/models/vote_test.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/test/models/vote_test.rb b/test/models/vote_test.rb index c0f7cbc2ff..8de433fe65 100644 --- a/test/models/vote_test.rb +++ b/test/models/vote_test.rb @@ -23,7 +23,6 @@ expect(new_vote.save).must_equal false end - # will do this in controller create action for vote. it "will be valid when only user OR works is repeated" do new_vote = Vote.new(user: users(:two), work: vote.work) expect(new_vote.save).must_equal true From abe8a7905e09e43c95e68dd14d988540fc1fbb84 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 19:36:18 -0700 Subject: [PATCH 16/56] updated user controller --- app/controllers/users_controller.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index f81d26a935..729a0e1710 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,14 +1,16 @@ class UsersController < ApplicationController def index - @users = User.all end def show end - def new + def login_form end - def create + def login + end + + def logout end end From f06fcd8f6e7cb96f847a2bbe4bde910b30656c43 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 20:20:24 -0700 Subject: [PATCH 17/56] wrote scafalding for tests --- app/controllers/users_controller.rb | 1 + .../{new.html.erb => login_form.html.erb} | 0 test/controllers/users_controller_test.rb | 26 ++++++++++++++++--- 3 files changed, 23 insertions(+), 4 deletions(-) rename app/views/users/{new.html.erb => login_form.html.erb} (100%) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 729a0e1710..4ffaf0ac2e 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -1,5 +1,6 @@ class UsersController < ApplicationController def index + @users = User.all end def show diff --git a/app/views/users/new.html.erb b/app/views/users/login_form.html.erb similarity index 100% rename from app/views/users/new.html.erb rename to app/views/users/login_form.html.erb diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index 1e1cc61d1f..3e5f5579be 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -8,10 +8,28 @@ end end - # it "should get show" do - # get users_show_url - # value(response).must_be :success? - # end + describe "users#show" do + it "should get show with valid id" do + end + + it "should return a 404 with invalid id" do + end + end + + + describe "users#login" do + it "will create a new user if username does not exist" do + end + + it "will update session user to previously created user" do + end + end + + describe "user#logout" do + it "will log out user" do + end + end + # it "should get new" do # get users_new_url From 9f8bc0ad163120b180cb1179714fb6cded877517 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 21:09:12 -0700 Subject: [PATCH 18/56] added routes for login, passed index, show --- app/controllers/users_controller.rb | 5 +++ config/routes.rb | 6 ++- test/controllers/users_controller_test.rb | 46 ++++++++++++++--------- 3 files changed, 38 insertions(+), 19 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 4ffaf0ac2e..db07b4503a 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -4,9 +4,14 @@ def index end def show + @user = User.find_by(id: params[:id]) + unless @user + head :not_found + end end def login_form + @user = User.new end def login diff --git a/config/routes.rb b/config/routes.rb index b48ba23bb8..fa71325481 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,4 +1,8 @@ Rails.application.routes.draw do resources :works - resources :users, except: [:edit, :update] + resources :users, only: [:index, :show] + + get "/login", to: "users#login_form", as: login_user + post "/login", to: "users#login" + post "logout", to: "users#logout", as: logout_user end diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index 3e5f5579be..b3e32a589f 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -8,38 +8,48 @@ end end + let(:user) { users(:one) } describe "users#show" do it "should get show with valid id" do + id = user.id + get user_path(id) + must_respond_with :success end it "should return a 404 with invalid id" do + invalid_id = -1 + get user_path(invalid_id) + must_respond_with :not_found end end - - describe "users#login" do - it "will create a new user if username does not exist" do - end - - it "will update session user to previously created user" do + describe "users#login_form" do + it "will get to log in page" do end end - describe "user#logout" do - it "will log out user" do - end - end - + # describe "users#login" do + # it "will create a new user if username does not exist" do + # end - # it "should get new" do - # get users_new_url - # value(response).must_be :success? + # it "will update session user to previously created user" do + # end # end - # it "should get create" do - # get users_create_url - # value(response).must_be :success? + # describe "user#logout" do + # it "will log out user" do + # end # end - # end + # # it "should get new" do + # # get users_new_url + # # value(response).must_be :success? + # # end + + # # it "should get create" do + # # get users_create_url + # # value(response).must_be :success? + # # end + + # # end end From 437b1bec3a825e151a0fbef2392c53451557f9f5 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 22:05:02 -0700 Subject: [PATCH 19/56] fixed schema users table column from name to username --- app/views/users/login_form.html.erb | 5 +++ config/routes.rb | 4 +- .../20190427050126_remove_name_from_users.rb | 5 +++ .../20190427050325_add_username_to_users.rb | 5 +++ db/schema.rb | 5 ++- test/controllers/users_controller_test.rb | 38 ++++++++++++++++--- 6 files changed, 52 insertions(+), 10 deletions(-) create mode 100644 db/migrate/20190427050126_remove_name_from_users.rb create mode 100644 db/migrate/20190427050325_add_username_to_users.rb diff --git a/app/views/users/login_form.html.erb b/app/views/users/login_form.html.erb index c21a1adf19..f16a857a31 100644 --- a/app/views/users/login_form.html.erb +++ b/app/views/users/login_form.html.erb @@ -1,2 +1,7 @@

Users#new

Find me in app/views/users/new.html.erb

+<%= form_with model: @user , url: { action: "login"} do |f| %> + <%= f.label :username %> + <%= f.text_field :username %> + <%= f.submit "Log In"%> +<% end %> \ No newline at end of file diff --git a/config/routes.rb b/config/routes.rb index fa71325481..e385f182ec 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -2,7 +2,7 @@ resources :works resources :users, only: [:index, :show] - get "/login", to: "users#login_form", as: login_user + get "/login", to: "users#login_form", as: :login_user post "/login", to: "users#login" - post "logout", to: "users#logout", as: logout_user + post "/logout", to: "users#logout", as: :logout_user end diff --git a/db/migrate/20190427050126_remove_name_from_users.rb b/db/migrate/20190427050126_remove_name_from_users.rb new file mode 100644 index 0000000000..efc4176745 --- /dev/null +++ b/db/migrate/20190427050126_remove_name_from_users.rb @@ -0,0 +1,5 @@ +class RemoveNameFromUsers < ActiveRecord::Migration[5.2] + def change + remove_column :users, :name, :string + end +end diff --git a/db/migrate/20190427050325_add_username_to_users.rb b/db/migrate/20190427050325_add_username_to_users.rb new file mode 100644 index 0000000000..b1743bf1a9 --- /dev/null +++ b/db/migrate/20190427050325_add_username_to_users.rb @@ -0,0 +1,5 @@ +class AddUsernameToUsers < ActiveRecord::Migration[5.2] + def change + add_column :users, :username, :string + end +end diff --git a/db/schema.rb b/db/schema.rb index 56e593edd6..aca767d851 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -10,15 +10,15 @@ # # It's strongly recommended that you check this file into your version control system. -ActiveRecord::Schema.define(version: 2019_04_24_152640) do +ActiveRecord::Schema.define(version: 2019_04_27_050325) do # These are extensions that must be enabled in order to support this database enable_extension "plpgsql" create_table "users", force: :cascade do |t| - t.string "name" t.datetime "created_at", null: false t.datetime "updated_at", null: false + t.string "username" end create_table "votes", force: :cascade do |t| @@ -39,4 +39,5 @@ t.datetime "created_at", null: false t.datetime "updated_at", null: false end + end diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index b3e32a589f..18e23c9fda 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -25,16 +25,42 @@ describe "users#login_form" do it "will get to log in page" do + get login_user_path + must_respond_with :success end end - # describe "users#login" do - # it "will create a new user if username does not exist" do - # end + describe "users#login" do + it "will create a new user if username does not exist" do + params = { user: { username: "new_user" } } + expect { + post login_user_path params: params + }.must_change "User.count", 1 + user = User.last - # it "will update session user to previously created user" do - # end - # end + expect(user.username).must_equal params[:user][:username] + expect(flash[:success]).must_equal "Successfully created new user #{user.username} new with ID #{user.id}" + + must_redirect_to root + end + + it "will login existing user" do + username = user.username + params = { user: { username: username } } + + expect { + post login_user_path params: params + }.must_change "User.count", 0 + + user = User.find_by(username: username) + expect(user.username).must_equal params[:user][:username] + + expect(flash[:success]).must_equal "Successfully logged in as existing user #{user.username}" + end + + # it "will update session user to previously created user" do + # end + end # describe "user#logout" do # it "will log out user" do From 6cd7d65591b1e3f33e136a733c66f69c8e68294a Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 22:33:31 -0700 Subject: [PATCH 20/56] login actiondone --- app/controllers/users_controller.rb | 10 ++++++++++ app/views/users/index.html.erb | 2 +- test/fixtures/users.yml | 4 ++-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index db07b4503a..3a74f46191 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -15,6 +15,16 @@ def login_form end def login + username = params[:user][:username] + user = User.find_by(username: username) + if user + flash[:success] = "Successfully logged in as existing user #{user.username}" + else + user = User.new(username: username) + flash[:success] = "Successfully created new user #{user.username} new with ID #{user.id}" + end + session[:user_id] = user.id + redirect_to root end def logout diff --git a/app/views/users/index.html.erb b/app/views/users/index.html.erb index b252f62af4..deaa657268 100644 --- a/app/views/users/index.html.erb +++ b/app/views/users/index.html.erb @@ -1,5 +1,5 @@

Users#index

Find me in app/views/users/index.html.erb

<%@users.each do |user|%> - <%= user.name %> + <%= user.username %> <%end%> \ No newline at end of file diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml index bbb730c6eb..31ece6407b 100644 --- a/test/fixtures/users.yml +++ b/test/fixtures/users.yml @@ -1,9 +1,9 @@ # Read about fixtures at http://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html one: - name: Sam + username: Sam id: 1 two: - name: Penny + username: Penny id: 2 From f9fc26b20c034cf77b8fadc0d0189455a86c08e7 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Fri, 26 Apr 2019 23:10:53 -0700 Subject: [PATCH 21/56] added homepages --- app/assets/javascripts/homepages.js | 2 ++ app/assets/stylesheets/homepages.scss | 3 +++ app/controllers/homepages_controller.rb | 4 ++++ app/helpers/homepages_helper.rb | 2 ++ app/views/homepages/index.html.erb | 2 ++ config/routes.rb | 1 + test/controllers/homepages_controller_test.rb | 9 +++++++++ 7 files changed, 23 insertions(+) create mode 100644 app/assets/javascripts/homepages.js create mode 100644 app/assets/stylesheets/homepages.scss create mode 100644 app/controllers/homepages_controller.rb create mode 100644 app/helpers/homepages_helper.rb create mode 100644 app/views/homepages/index.html.erb create mode 100644 test/controllers/homepages_controller_test.rb diff --git a/app/assets/javascripts/homepages.js b/app/assets/javascripts/homepages.js new file mode 100644 index 0000000000..dee720facd --- /dev/null +++ b/app/assets/javascripts/homepages.js @@ -0,0 +1,2 @@ +// Place all the behaviors and hooks related to the matching controller here. +// All this logic will automatically be available in application.js. diff --git a/app/assets/stylesheets/homepages.scss b/app/assets/stylesheets/homepages.scss new file mode 100644 index 0000000000..2305c36d10 --- /dev/null +++ b/app/assets/stylesheets/homepages.scss @@ -0,0 +1,3 @@ +// Place all the styles related to the Homepages controller here. +// They will automatically be included in application.css. +// You can use Sass (SCSS) here: http://sass-lang.com/ diff --git a/app/controllers/homepages_controller.rb b/app/controllers/homepages_controller.rb new file mode 100644 index 0000000000..f200c8ac2e --- /dev/null +++ b/app/controllers/homepages_controller.rb @@ -0,0 +1,4 @@ +class HomepagesController < ApplicationController + def index + end +end diff --git a/app/helpers/homepages_helper.rb b/app/helpers/homepages_helper.rb new file mode 100644 index 0000000000..4bd8098f37 --- /dev/null +++ b/app/helpers/homepages_helper.rb @@ -0,0 +1,2 @@ +module HomepagesHelper +end diff --git a/app/views/homepages/index.html.erb b/app/views/homepages/index.html.erb new file mode 100644 index 0000000000..37d3ce7099 --- /dev/null +++ b/app/views/homepages/index.html.erb @@ -0,0 +1,2 @@ +

Homepages#index

+

Find me in app/views/homepages/index.html.erb

diff --git a/config/routes.rb b/config/routes.rb index e385f182ec..ce1dd46b04 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,4 +1,5 @@ Rails.application.routes.draw do + get 'homepages/index' resources :works resources :users, only: [:index, :show] diff --git a/test/controllers/homepages_controller_test.rb b/test/controllers/homepages_controller_test.rb new file mode 100644 index 0000000000..7395af3dec --- /dev/null +++ b/test/controllers/homepages_controller_test.rb @@ -0,0 +1,9 @@ +require "test_helper" + +describe HomepagesController do + it "should get index" do + get homepages_index_url + value(response).must_be :success? + end + +end From ddd5888a7930a5a1484caa9e9edfcab985abed73 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 00:01:01 -0700 Subject: [PATCH 22/56] logout funtion and tests --- app/controllers/users_controller.rb | 7 ++++- app/models/user.rb | 2 +- config/routes.rb | 2 +- test/controllers/users_controller_test.rb | 33 ++++++++++++++++------- 4 files changed, 31 insertions(+), 13 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 3a74f46191..11c0667bb2 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -21,12 +21,17 @@ def login flash[:success] = "Successfully logged in as existing user #{user.username}" else user = User.new(username: username) + user.save flash[:success] = "Successfully created new user #{user.username} new with ID #{user.id}" end session[:user_id] = user.id - redirect_to root + + redirect_to root_path end def logout + session[:user_id] = nil + flash[:success] = "Successfully logged out" + redirect_to root_path end end diff --git a/app/models/user.rb b/app/models/user.rb index a05b4d8f9d..f69cb2ffd0 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,5 +2,5 @@ class User < ApplicationRecord has_many :votes has_many :works, through: :votes - validates :name, presence: true, uniqueness: true + validates :username, presence: true, uniqueness: true end diff --git a/config/routes.rb b/config/routes.rb index ce1dd46b04..25f8e6f658 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,5 +1,5 @@ Rails.application.routes.draw do - get 'homepages/index' + root to: "homepages#index" resources :works resources :users, only: [:index, :show] diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index 18e23c9fda..b985382dc1 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -40,8 +40,8 @@ expect(user.username).must_equal params[:user][:username] expect(flash[:success]).must_equal "Successfully created new user #{user.username} new with ID #{user.id}" - - must_redirect_to root + expect(session[:user_id]).must_equal user.id + must_redirect_to root_path end it "will login existing user" do @@ -54,18 +54,31 @@ user = User.find_by(username: username) expect(user.username).must_equal params[:user][:username] - expect(flash[:success]).must_equal "Successfully logged in as existing user #{user.username}" - end + expect(session[:user_id]).must_equal user.id - # it "will update session user to previously created user" do - # end + must_redirect_to root_path + end end - # describe "user#logout" do - # it "will log out user" do - # end - # end + describe "user#logout" do + it "will log out user" do + username = user.username + params = { user: { username: username } } + # sets session id + post login_user_path params: params + expect(session[:user_id]).must_equal user.id + + expect { + post logout_user_path + }.wont_change "User.count" + + expect(session[:user_id]).must_be_nil + expect(flash[:success]).must_equal "Successfully logged out" + + must_redirect_to root_path + end + end # # it "should get new" do # # get users_new_url From 3183316e555def4cafd2a1e4bdd67ea2454f9918 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 00:01:55 -0700 Subject: [PATCH 23/56] removed extra generated by rails --- test/controllers/users_controller_test.rb | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index b985382dc1..468c7d12cc 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -79,16 +79,4 @@ must_redirect_to root_path end end - - # # it "should get new" do - # # get users_new_url - # # value(response).must_be :success? - # # end - - # # it "should get create" do - # # get users_create_url - # # value(response).must_be :success? - # # end - - # # end end From 18070eb50d1ba9baa6c4ec9646bc8bc018b2a79c Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 00:06:06 -0700 Subject: [PATCH 24/56] all tests passing --- app/views/works/index.html.erb | 2 +- test/controllers/homepages_controller_test.rb | 3 +-- test/models/user_test.rb | 10 +++++----- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/app/views/works/index.html.erb b/app/views/works/index.html.erb index 1fb05ce36e..4ab4b8b270 100644 --- a/app/views/works/index.html.erb +++ b/app/views/works/index.html.erb @@ -1,5 +1,5 @@

Works#index

Find me in app/views/works/index.html.erb

<%@works.each do |work|%> - <%= work.name %> + <%= work.title %> <%end%> \ No newline at end of file diff --git a/test/controllers/homepages_controller_test.rb b/test/controllers/homepages_controller_test.rb index 7395af3dec..c74072845c 100644 --- a/test/controllers/homepages_controller_test.rb +++ b/test/controllers/homepages_controller_test.rb @@ -2,8 +2,7 @@ describe HomepagesController do it "should get index" do - get homepages_index_url + get root_path value(response).must_be :success? end - end diff --git a/test/models/user_test.rb b/test/models/user_test.rb index 760b8601b9..107fda6bcd 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -8,20 +8,20 @@ expect(user.valid?).must_equal true end - it "will not be valid without name" do - user.name = nil + it "will not be valid without username" do + user.username = nil expect(user.save).must_equal false end - it "will not be valid with same name twice" do - user_new = User.new(name: user.name) + it "will not be valid with same username twice" do + user_new = User.new(username: user.username) expect(user_new.save).must_equal false end end describe "relations" do it "will have 0 votes" do - user = User.new(name: "no votes") + user = User.new(username: "no votes") expect(user.votes).must_equal [] end From 38b971b892398e768ab0578ed3ac6c356b4376c5 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 00:14:41 -0700 Subject: [PATCH 25/56] updated hompages controller tests --- test/controllers/homepages_controller_test.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/controllers/homepages_controller_test.rb b/test/controllers/homepages_controller_test.rb index c74072845c..b459f7e9d4 100644 --- a/test/controllers/homepages_controller_test.rb +++ b/test/controllers/homepages_controller_test.rb @@ -3,6 +3,6 @@ describe HomepagesController do it "should get index" do get root_path - value(response).must_be :success? + must_respond_with :success end end From 44539bb647e4d4200e2103f975e22f0b3ae4cfa0 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 11:03:26 -0700 Subject: [PATCH 26/56] fixed at b create --- app/controllers/users_controller.rb | 8 ++- app/controllers/works_controller.rb | 30 ++++++++++ app/views/works/new.html.erb | 15 +++++ db/schema.rb | 1 - test/controllers/works_controller_test.rb | 73 +++++++++++++++++++---- 5 files changed, 113 insertions(+), 14 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 11c0667bb2..41f674b942 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -20,7 +20,7 @@ def login if user flash[:success] = "Successfully logged in as existing user #{user.username}" else - user = User.new(username: username) + user = User.new(user_param) user.save flash[:success] = "Successfully created new user #{user.username} new with ID #{user.id}" end @@ -34,4 +34,10 @@ def logout flash[:success] = "Successfully logged out" redirect_to root_path end + + private + + def user_param + params.require(:user).permit(:username) + end end diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index ca7c8135ec..eb1273a497 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -4,12 +4,27 @@ def index end def show + work = Work.find_by(id: params[:id]) + unless work + head :not_found + end end def new + @work = Work.new() end def create + @work = Work.new(work_params) + if @work.save + flash[:success] = "Successfully created #{@work.category} #{@work.id}" + redirect_to work_path(@work.id) + else + @work.errors.messages.each do |label, message| + flash.now[label.to_sym] = message + end + render :new, status: :bad_request + end end def update @@ -17,4 +32,19 @@ def update def edit end + + private + + # had some trouble here should follow up + + def work_params + # return params.fetch(:work, {}).permit(:title, :category, :creator, :publication_year, :description) + return params.require(:work).permit(:title, :category, :creator, :publication_year, :description) + end end + +# title: params[:title], +# category: params[:category], +# creator: params[:creator], +# publication_year: params[:publication_year], +# description: params[:description] diff --git a/app/views/works/new.html.erb b/app/views/works/new.html.erb index fad0dfea61..fc2912d576 100644 --- a/app/views/works/new.html.erb +++ b/app/views/works/new.html.erb @@ -1,2 +1,17 @@

Works#new

Find me in app/views/works/new.html.erb

+ +<%= form_with model: @work do |f|%> + <%=f.label :category%> + <%= f.select :category, ["album", "book", "movie"] %> + <%=f.label :title%> + <%=f.text_field :title%> + <%=f.label :creator %> + <%= f.text_field :creator%> + <%=f.label :Publication_year%> + <%= f.text_field :Publication_year%> + <%=f.label :description%> + <%=f.text_area :description%> + <%=f.submit "Create Work" %> +<% end %> + diff --git a/db/schema.rb b/db/schema.rb index aca767d851..cefe03dc09 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -39,5 +39,4 @@ t.datetime "created_at", null: false t.datetime "updated_at", null: false end - end diff --git a/test/controllers/works_controller_test.rb b/test/controllers/works_controller_test.rb index b0e33c8e70..4143f7c76b 100644 --- a/test/controllers/works_controller_test.rb +++ b/test/controllers/works_controller_test.rb @@ -8,22 +8,71 @@ end end + let(:work) { works(:one) } + describe "works#show" do + it "should get show with valid id" do + get work_path(work.id) + must_respond_with :success + end - # it "should get show" do - # get works_show_url - # value(response).must_be :success? - # end + it "should return a 404 with invalid id" do + invalid_id = -1 + get work_path(invalid_id) + must_respond_with :not_found + end + end - # it "should get new" do - # get works_new_url - # value(response).must_be :success? - # end + it "should get new" do + get new_work_path + must_respond_with :success + end - # it "should get create" do - # get works_create_url - # value(response).must_be :success? - # end + it "should get create given required params" do + work_param = { work: { title: "new work", + category: "book" } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 1 + + work = Work.last + + must_respond_with :redirect + must_redirect_to work_path(work.id) + expect(flash[:success]).must_equal "Successfully created #{work.category} #{work.id}" + expect(work.title).must_equal work_param[:work][:title] + expect(work.category).must_equal work_param[:work][:category] + end + + it "should return bad request if missing category" do + work_param = { work: { title: "new work", + category: nil } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 0 + must_respond_with :bad_request + expect(flash[:category]).must_equal ["can't be blank"] + end + + it "should return bad request if missing title" do + work_param = { work: { title: nil, + category: "books" } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 0 + must_respond_with :bad_request + expect(flash[:title]).must_equal ["can't be blank"] + end + it "should return bad request,send flash, and render new if not given unique title params" do + work_param = { work: { title: work.title, + category: "book" } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 0 + + must_respond_with :bad_request + expect(flash[:title]).must_equal ["has already been taken"] + end # it "should get update" do # get works_update_url # value(response).must_be :success? From 2d1f939fc1da19423ef9b3d95f60a5dc74844bbe Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 11:04:45 -0700 Subject: [PATCH 27/56] removed tb lines --- app/controllers/works_controller.rb | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index eb1273a497..813c448805 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -35,16 +35,9 @@ def edit private - # had some trouble here should follow up + def work_params - # return params.fetch(:work, {}).permit(:title, :category, :creator, :publication_year, :description) return params.require(:work).permit(:title, :category, :creator, :publication_year, :description) end end - -# title: params[:title], -# category: params[:category], -# creator: params[:creator], -# publication_year: params[:publication_year], -# description: params[:description] From 35735c0e85359f53ac95783826b4af8de29b5938 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 11:21:30 -0700 Subject: [PATCH 28/56] added edit and tests work --- app/controllers/works_controller.rb | 6 ++++-- app/views/works/edit.html.erb | 15 +++++++++++++++ test/controllers/works_controller_test.rb | 18 ++++++++++++++++-- 3 files changed, 35 insertions(+), 4 deletions(-) diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index 813c448805..b6ebf3b89b 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -31,12 +31,14 @@ def update end def edit + @work = Work.find_by(id: params[:id]) + unless @work + head :not_found + end end private - - def work_params return params.require(:work).permit(:title, :category, :creator, :publication_year, :description) end diff --git a/app/views/works/edit.html.erb b/app/views/works/edit.html.erb index b717b97f84..1933efb2d5 100644 --- a/app/views/works/edit.html.erb +++ b/app/views/works/edit.html.erb @@ -1,2 +1,17 @@

Works#edit

Find me in app/views/works/edit.html.erb

+ + +<%= form_with model: @work do |f|%> + <%=f.label :category%> + <%= f.select :category, ["album", "book", "movie"] %> + <%=f.label :title%> + <%=f.text_field :title%> + <%=f.label :creator %> + <%= f.text_field :creator%> + <%=f.label :Publication_year%> + <%= f.text_field :Publication_year%> + <%=f.label :description%> + <%=f.text_area :description%> + <%=f.submit "Create Work" %> +<% end %> \ No newline at end of file diff --git a/test/controllers/works_controller_test.rb b/test/controllers/works_controller_test.rb index 4143f7c76b..05f42dc924 100644 --- a/test/controllers/works_controller_test.rb +++ b/test/controllers/works_controller_test.rb @@ -73,8 +73,21 @@ must_respond_with :bad_request expect(flash[:title]).must_equal ["has already been taken"] end - # it "should get update" do - # get works_update_url + + +describe "works#edit" do + it "will get to edit page if valid id" do + id = work.id + get edit_work_path(id) + must_respond_with :success + end + + it "should return a 404 with invalid id" do + invalid_id = -1 + get edit_work_path(invalid_id) + must_respond_with :not_found + end + # value(response).must_be :success? # end @@ -83,3 +96,4 @@ # value(response).must_be :success? # end end +end From a91ed96a323c990e79a38e29431dd4c1c7c262b7 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 13:14:17 -0700 Subject: [PATCH 29/56] all tests passing --- app/controllers/works_controller.rb | 25 +++++- app/models/work.rb | 2 +- app/views/works/show.html.erb | 2 + test/controllers/works_controller_test.rb | 96 +++++++++++++++++++---- 4 files changed, 106 insertions(+), 19 deletions(-) diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index b6ebf3b89b..54ed9f1104 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -4,8 +4,8 @@ def index end def show - work = Work.find_by(id: params[:id]) - unless work + @work = Work.find_by(id: params[:id]) + unless @work head :not_found end end @@ -28,6 +28,16 @@ def create end def update + @work = Work.find_by(id: params[:work][:id]) + if @work.update(work_params) + flash[:success] = "Successfully updated #{@work.category} #{@work.id}" + redirect_to work_path(@work.id) + else + @work.errors.messages.each do |label, message| + flash.now[label.to_sym] = message + end + render :edit, status: :bad_request + end end def edit @@ -37,6 +47,17 @@ def edit end end + def destroy + @work = Work.find_by(id: params[:id]) + if @work + flash[:success] = "Successfully destroyed #{@work.category} #{@work.id}" + @work.destroy + redirect_to root_path + else + head :not_found + end + end + private def work_params diff --git a/app/models/work.rb b/app/models/work.rb index 79c60c5802..871c1e334b 100644 --- a/app/models/work.rb +++ b/app/models/work.rb @@ -1,5 +1,5 @@ class Work < ApplicationRecord - has_many :votes + has_many :votes, dependent: :destroy has_many :users, through: :votes validates :title, presence: true, uniqueness: true diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb index c096804302..f878e8978e 100644 --- a/app/views/works/show.html.erb +++ b/app/views/works/show.html.erb @@ -1,2 +1,4 @@

Works#show

Find me in app/views/works/show.html.erb

+ +<%= button_to "Delete", work_path(@work.id), method: :delete%> diff --git a/test/controllers/works_controller_test.rb b/test/controllers/works_controller_test.rb index 05f42dc924..858dd8c686 100644 --- a/test/controllers/works_controller_test.rb +++ b/test/controllers/works_controller_test.rb @@ -74,26 +74,90 @@ expect(flash[:title]).must_equal ["has already been taken"] end + describe "works#edit" do + it "will get to edit page if valid id" do + id = work.id + get edit_work_path(id) + must_respond_with :success + end -describe "works#edit" do - it "will get to edit page if valid id" do - id = work.id - get edit_work_path(id) - must_respond_with :success + it "should return a 404 with invalid id" do + invalid_id = -1 + get edit_work_path(invalid_id) + must_respond_with :not_found + end end - it "should return a 404 with invalid id" do - invalid_id = -1 - get edit_work_path(invalid_id) - must_respond_with :not_found + describe "works#update" do + it "will update work with valid params" do + work_param = { work: { title: "new work", + category: "book", + id: work.id } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 1 + + work = Work.last + + must_respond_with :redirect + must_redirect_to work_path(work.id) + expect(flash[:success]).must_equal "Successfully created #{work.category} #{work.id}" + expect(work.title).must_equal work_param[:work][:title] + expect(work.category).must_equal work_param[:work][:category] + end + + it "should return bad request if missing category" do + work_param = { work: { title: "new work", + category: nil, + id: work.id } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 0 + must_respond_with :bad_request + expect(flash[:category]).must_equal ["can't be blank"] + end + + it "should return bad request if missing title" do + work_param = { work: { title: nil, + category: "books", + id: work.id } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 0 + must_respond_with :bad_request + expect(flash[:title]).must_equal ["can't be blank"] + end + + it "should return bad request,send flash, and render new if not given unique title params" do + work_param = { work: { title: work.title, + category: "book", + id: work.id } } + expect { + post works_path, params: work_param + }.must_change "Work.count", 0 + + must_respond_with :bad_request + expect(flash[:title]).must_equal ["has already been taken"] + end end - # value(response).must_be :success? - # end + describe "works#destroy" do + it "will destroy a valid id" do + id = work.id + expect { + delete work_path(id) + }.must_change "Work.count", -1 + must_respond_with :redirect + must_redirect_to root_path + expect(flash[:success]).must_equal "Successfully destroyed #{work.category} #{work.id}" + end - # it "should get edit" do - # get works_edit_url - # value(response).must_be :success? - # end -end + it "should return a 404 with invalid id" do + invalid_id = -1 + expect { + delete work_path(invalid_id) + }.wont_change "Work.count" + must_respond_with :not_found + end + end end From 36faf19528195b1652a8558310a45ad4d26fade0 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sat, 27 Apr 2019 15:59:25 -0700 Subject: [PATCH 30/56] votes done --- app/assets/javascripts/votes.js | 2 ++ app/assets/stylesheets/votes.scss | 3 +++ app/controllers/votes_controller.rb | 21 +++++++++++++++++++++ app/controllers/works_controller.rb | 8 ++++---- app/helpers/votes_helper.rb | 2 ++ app/models/work.rb | 2 +- app/views/works/show.html.erb | 1 + config/routes.rb | 4 +++- test/controllers/votes_controller_test.rb | 19 +++++++++++++++++++ test/fixtures/users.yml | 4 ++++ 10 files changed, 60 insertions(+), 6 deletions(-) create mode 100644 app/assets/javascripts/votes.js create mode 100644 app/assets/stylesheets/votes.scss create mode 100644 app/controllers/votes_controller.rb create mode 100644 app/helpers/votes_helper.rb create mode 100644 test/controllers/votes_controller_test.rb diff --git a/app/assets/javascripts/votes.js b/app/assets/javascripts/votes.js new file mode 100644 index 0000000000..dee720facd --- /dev/null +++ b/app/assets/javascripts/votes.js @@ -0,0 +1,2 @@ +// Place all the behaviors and hooks related to the matching controller here. +// All this logic will automatically be available in application.js. diff --git a/app/assets/stylesheets/votes.scss b/app/assets/stylesheets/votes.scss new file mode 100644 index 0000000000..9a6720f80e --- /dev/null +++ b/app/assets/stylesheets/votes.scss @@ -0,0 +1,3 @@ +// Place all the styles related to the Votes controller here. +// They will automatically be included in application.css. +// You can use Sass (SCSS) here: http://sass-lang.com/ diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb new file mode 100644 index 0000000000..fa3f78b26e --- /dev/null +++ b/app/controllers/votes_controller.rb @@ -0,0 +1,21 @@ +class VotesController < ApplicationController + def create + user_id = session[:user_id] + if !user_id + session[:error] = "A problem occurred: You must log in to do that" + else + vote = Vote.new(user_id: user_id, work_id: params[:work_id]) + if vote.save + session[:success] = "Successfully upvoted!" + else + session[:error] = "A problem occurred: Could not upvote" + vote.errors.messages.each do |label, message| + flash.now[label.to_sym] = message + end + end + end + end +end + +# A problem occurred: Could not upvote +# user: has already voted for this work diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index 54ed9f1104..4ee63d20e3 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -50,10 +50,10 @@ def edit def destroy @work = Work.find_by(id: params[:id]) if @work - flash[:success] = "Successfully destroyed #{@work.category} #{@work.id}" - @work.destroy - redirect_to root_path - else + flash[:success] = "Successfully destroyed #{@work.category} #{@work.id}" + @work.destroy + redirect_to root_path + else head :not_found end end diff --git a/app/helpers/votes_helper.rb b/app/helpers/votes_helper.rb new file mode 100644 index 0000000000..5a82eed07d --- /dev/null +++ b/app/helpers/votes_helper.rb @@ -0,0 +1,2 @@ +module VotesHelper +end diff --git a/app/models/work.rb b/app/models/work.rb index 871c1e334b..5aff065e7c 100644 --- a/app/models/work.rb +++ b/app/models/work.rb @@ -1,5 +1,5 @@ class Work < ApplicationRecord - has_many :votes, dependent: :destroy + has_many :votes, dependent: :destroy has_many :users, through: :votes validates :title, presence: true, uniqueness: true diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb index f878e8978e..e5e92d0377 100644 --- a/app/views/works/show.html.erb +++ b/app/views/works/show.html.erb @@ -2,3 +2,4 @@

Find me in app/views/works/show.html.erb

<%= button_to "Delete", work_path(@work.id), method: :delete%> +<%= button_to "Upvote", work_votes_path(@work.id)%> \ No newline at end of file diff --git a/config/routes.rb b/config/routes.rb index 25f8e6f658..3451718dfd 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -1,6 +1,8 @@ Rails.application.routes.draw do root to: "homepages#index" - resources :works + resources :works do + resources :votes, only: [:create] + end resources :users, only: [:index, :show] get "/login", to: "users#login_form", as: :login_user diff --git a/test/controllers/votes_controller_test.rb b/test/controllers/votes_controller_test.rb new file mode 100644 index 0000000000..2d17e2c6c1 --- /dev/null +++ b/test/controllers/votes_controller_test.rb @@ -0,0 +1,19 @@ +require "test_helper" + +describe VotesController do + let(:user) { users(:three) } + let(:work) { works(:one) } + describe "Votes#create" do + it "will create a vote if logged in" do + username = user.username + params = { user: { username: username } } + post login_user_path params: params + expect { + post work_votes_path(work.id) + }.must_change "Vote.count", 1 + + expect(work.users.include?(user)).must_equal true + expect(user.works.include?(work)).must_equal true + end + end +end diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml index 31ece6407b..1510521b71 100644 --- a/test/fixtures/users.yml +++ b/test/fixtures/users.yml @@ -7,3 +7,7 @@ one: two: username: Penny id: 2 + +three: + username: Billy + id: 3 From d7ccb68d6e163d63f45f316d48b2d5332cb06810 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:09:28 -0700 Subject: [PATCH 31/56] finished model methods and started styling home page --- app/assets/stylesheets/application.scss | 178 +++++- app/models/work.rb | 16 + app/views/homepages/index.html.erb | 15 +- app/views/layouts/application.html.erb | 38 +- temp.rb | 40 ++ test/fixtures/users.yml | 12 + test/fixtures/votes.yml | 748 ++++++++++++++++++++++++ test/fixtures/works.yml | 145 +++++ test/models/work_test.rb | 33 +- 9 files changed, 1220 insertions(+), 5 deletions(-) create mode 100644 temp.rb diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss index b4d20f5641..57c3fb62d7 100644 --- a/app/assets/stylesheets/application.scss +++ b/app/assets/stylesheets/application.scss @@ -14,4 +14,180 @@ /* Custom bootstrap variables must be set or imported *before* bootstrap. */ @import "bootstrap"; /* Import scss content */ -@import "**/*"; +@import "**/*"; + + + .user-votes__container { + margin-top: 2rem +} + +.user-votes__header { + color: black +} + +.works-votes__container { + margin-top: 2rem +} + +.works-votes__header { + color: black +} + +body, +h1, +h2, +h3, +h4, +h5 { + font-family: "Gudea", sans-serif +} + +h1, +h2, +h3, +h4, +h5 { + font-weight: bold +} + +a, +h2, +h3 { + color: #26A69A +} + +a:hover { + color: #00796B; + text-decoration: none +} + +.alert { + margin: 0 +} + +.btn-primary { + background-color: #26A69A; + color: white; + border-color: #26A69A +} + +.btn:hover { + background-color: #00796B; + color: white +} + +.table td { + vertical-align: middle +} + +.app-header__nav { + display: flex; + flex-direction: row; + justify-content: space-between +} + +.app-header__nav_item { + margin-top: 1rem +} + +.app-header__nav_item .nav-link { + color: #00796B +} + +.app-header__site-nav-container .app-header__nav_item { + margin-right: 2rem +} + +.app-header__user-nav-container .nav-item { + margin-left: 2rem +} + +.list-group-item { + border: none +} + +.app-header__header { + max-width: 100%; + background-color: #B2DFDB; + margin-bottom: 0.5rem; + padding: 2rem 1rem 0.5rem 1rem +} + +.app-header__header h1 { + text-align: center; + margin: 25px auto 40px auto +} + +.app-header__header h1 a { + color: #FF5722; + padding-right: 25px; + margin-right: 15px; + border-right: white 2px solid +} + +.app-header__header h1 small { + color: white +} + +.app-header__header p { + margin-bottom: 5px +} + +.alert__container { + margin: 2rem 0 1rem 0 +} + +.spotlight { + padding: 0 2rem 2rem 2rem +} + +.spotlight__header { + color: #26A69A +} + +.spotlight__header--prefix { + color: #424242 +} + +.spotlight__header--prefix::after { + content: ":" +} + +.spotlight__link-to { + border-bottom: 2px solid +} + +.spotlight__description { + margin-bottom: 0 +} + +.root__hr { + margin: 0px auto 3rem auto; + color: #EEEEEE +} + +.top-ten__container { + display: grid; + grid-template-columns: 1fr 1fr 1fr; + grid-column-gap: 2em +} + +.top-ten__header { + color: #26A69A; + border-bottom: 2px solid; + border-bottom-color: #B2DFDB +} + +.top-ten__list { + list-style-type: none; + margin-left: 0; + padding-left: 0 +} + +.top-ten__creator { + color: slategrey +} + +main { + padding: 2rem +} \ No newline at end of file diff --git a/app/models/work.rb b/app/models/work.rb index 5aff065e7c..0819f6faa2 100644 --- a/app/models/work.rb +++ b/app/models/work.rb @@ -4,4 +4,20 @@ class Work < ApplicationRecord validates :title, presence: true, uniqueness: true validates :category, presence: true + + def self.top_ten(category) + return self.sort_work_by_votes(Work.all.where(category: category))[0..9] + end + + def self.spotlight + return self.sort_work_by_votes(Work.all).first + end + + private + + def self.sort_work_by_votes(works) + return works.sort_by do |work| + -work.votes.count + end + end end diff --git a/app/views/homepages/index.html.erb b/app/views/homepages/index.html.erb index 37d3ce7099..df1a6f8d0b 100644 --- a/app/views/homepages/index.html.erb +++ b/app/views/homepages/index.html.erb @@ -1,2 +1,13 @@ -

Homepages#index

-

Find me in app/views/homepages/index.html.erb

+
+

+ Media Spotlight + <%spotlight = Work.spotlight%> + <%if spotlight%> + <%= link_to "#{spotlight.title}", work_path(spotlight.id), class:"spotlight__link-to" %> by <%=spotlight.creator%> +

+

+ <%=spotlight.votes.count%> votes - <%=spotlight.description%> +

+ <% end %> +
+ diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index f32268a271..26e788ee07 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -10,6 +10,42 @@ +
+

+ <%= link_to "Media Ranker", root_path%> + Ranking the Best of Everything +

+ +
<%= yield %> - + \ No newline at end of file diff --git a/temp.rb b/temp.rb new file mode 100644 index 0000000000..9ed96490ab --- /dev/null +++ b/temp.rb @@ -0,0 +1,40 @@ +User.all.each do |user| + votes = [*1..23] + 13.times do |i| + work_id = votes.shuffle!.pop + Vote.create(user_id: user.id, work_id: work_id) + end +end + +vote_hash = Hash.new(0) +Vote.all.each do |vote| + vote_hash[vote.work_id] += 1 +end + +work_hash = Hash.new(0) +works.each do |vote| + work_hash[vote.id] = vote.vote_ids.count +end + +20.times do |i| + User.create(username: "somename#{i}") +end + +100.times do |i| + user_id = rand(50) + votes = [*1..23] + 13.times do |i| + work_id = votes.shuffle!.pop + Vote.create(user_id: user_id, work_id: work_id) + end +end + +200.times do + id = (rand(379)) + vote = Vote.find_by(id: id) + vote.destroy if vote +end + +5.times do |i| +Work.create(title: "#{i}qweasdzxc", category: "movie") +end \ No newline at end of file diff --git a/test/fixtures/users.yml b/test/fixtures/users.yml index 1510521b71..fc7f70d0ad 100644 --- a/test/fixtures/users.yml +++ b/test/fixtures/users.yml @@ -11,3 +11,15 @@ two: three: username: Billy id: 3 + +three4: + username: Billy4 + id: 4 + +three5: + username: Billy5 + id: 5 + +three6: + username: Billy6 + id: 6 \ No newline at end of file diff --git a/test/fixtures/votes.yml b/test/fixtures/votes.yml index fa15ee6c96..fd489682a8 100644 --- a/test/fixtures/votes.yml +++ b/test/fixtures/votes.yml @@ -12,3 +12,751 @@ two: user_id: 2 work_id: 2 +vote41: + user_id: 4 + work_id: 9 + + +vote42: + user_id: 4 + work_id: 13 + + +vote43: + user_id: 4 + work_id: 13 + + +vote44: + user_id: 4 + work_id: 9 + + +vote45: + user_id: 4 + work_id: 6 + + +vote46: + user_id: 4 + work_id: 14 + + +vote47: + user_id: 4 + work_id: 5 + + +vote48: + user_id: 4 + work_id: 15 + + +vote49: + user_id: 4 + work_id: 10 + + +vote410: + user_id: 4 + work_id: 14 + + +vote411: + user_id: 4 + work_id: 17 + + +vote412: + user_id: 4 + work_id: 16 + + +vote413: + user_id: 4 + work_id: 17 + + +vote414: + user_id: 4 + work_id: 6 + + +vote415: + user_id: 4 + work_id: 6 + + +vote416: + user_id: 4 + work_id: 9 + + +vote417: + user_id: 4 + work_id: 11 + + +vote418: + user_id: 4 + work_id: 17 + + +vote419: + user_id: 4 + work_id: 14 + + +vote420: + user_id: 4 + work_id: 9 + + +vote421: + user_id: 4 + work_id: 8 + + +vote422: + user_id: 4 + work_id: 10 + + +vote423: + user_id: 4 + work_id: 18 + + +vote424: + user_id: 4 + work_id: 6 + + +vote425: + user_id: 4 + work_id: 6 + + +vote426: + user_id: 4 + work_id: 7 + + +vote427: + user_id: 4 + work_id: 7 + + +vote428: + user_id: 4 + work_id: 5 + + +vote429: + user_id: 4 + work_id: 17 + + +vote430: + user_id: 4 + work_id: 10 + + +vote431: + user_id: 4 + work_id: 19 + + +vote432: + user_id: 4 + work_id: 8 + + +vote433: + user_id: 4 + work_id: 5 + + +vote434: + user_id: 4 + work_id: 5 + + +vote435: + user_id: 4 + work_id: 5 + + +vote436: + user_id: 4 + work_id: 19 + + +vote437: + user_id: 4 + work_id: 16 + + +vote438: + user_id: 4 + work_id: 6 + + +vote439: + user_id: 4 + work_id: 14 + + +vote440: + user_id: 4 + work_id: 11 + + +vote441: + user_id: 4 + work_id: 7 + + +vote442: + user_id: 4 + work_id: 18 + + +vote443: + user_id: 4 + work_id: 7 + + +vote444: + user_id: 4 + work_id: 17 + + +vote445: + user_id: 4 + work_id: 13 + + +vote446: + user_id: 4 + work_id: 15 + + +vote447: + user_id: 4 + work_id: 12 + + +vote448: + user_id: 4 + work_id: 6 + + +vote449: + user_id: 4 + work_id: 13 + + +vote450: + user_id: 4 + work_id: 6 + + +vote51: + user_id: 5 + work_id: 14 + + +vote52: + user_id: 5 + work_id: 5 + + +vote53: + user_id: 5 + work_id: 7 + + +vote54: + user_id: 5 + work_id: 16 + + +vote55: + user_id: 5 + work_id: 13 + + +vote56: + user_id: 5 + work_id: 18 + + +vote57: + user_id: 5 + work_id: 15 + + +vote58: + user_id: 5 + work_id: 15 + + +vote59: + user_id: 5 + work_id: 14 + + +vote510: + user_id: 5 + work_id: 19 + + +vote511: + user_id: 5 + work_id: 7 + + +vote512: + user_id: 5 + work_id: 12 + + +vote513: + user_id: 5 + work_id: 14 + + +vote514: + user_id: 5 + work_id: 16 + + +vote515: + user_id: 5 + work_id: 15 + + +vote516: + user_id: 5 + work_id: 9 + + +vote517: + user_id: 5 + work_id: 5 + + +vote518: + user_id: 5 + work_id: 12 + + +vote519: + user_id: 5 + work_id: 7 + + +vote520: + user_id: 5 + work_id: 10 + + +vote521: + user_id: 5 + work_id: 16 + + +vote522: + user_id: 5 + work_id: 10 + + +vote523: + user_id: 5 + work_id: 12 + + +vote524: + user_id: 5 + work_id: 5 + + +vote525: + user_id: 5 + work_id: 15 + + +vote526: + user_id: 5 + work_id: 11 + + +vote527: + user_id: 5 + work_id: 11 + + +vote528: + user_id: 5 + work_id: 7 + + +vote529: + user_id: 5 + work_id: 15 + + +vote530: + user_id: 5 + work_id: 10 + + +vote531: + user_id: 5 + work_id: 18 + + +vote532: + user_id: 5 + work_id: 13 + + +vote533: + user_id: 5 + work_id: 12 + + +vote534: + user_id: 5 + work_id: 6 + + +vote535: + user_id: 5 + work_id: 18 + + +vote536: + user_id: 5 + work_id: 17 + + +vote537: + user_id: 5 + work_id: 5 + + +vote538: + user_id: 5 + work_id: 16 + + +vote539: + user_id: 5 + work_id: 8 + + +vote540: + user_id: 5 + work_id: 11 + + +vote541: + user_id: 5 + work_id: 14 + + +vote542: + user_id: 5 + work_id: 13 + + +vote543: + user_id: 5 + work_id: 15 + + +vote544: + user_id: 5 + work_id: 19 + + +vote545: + user_id: 5 + work_id: 11 + + +vote546: + user_id: 5 + work_id: 15 + + +vote547: + user_id: 5 + work_id: 11 + + +vote548: + user_id: 5 + work_id: 8 + + +vote549: + user_id: 5 + work_id: 12 + + +vote550: + user_id: 5 + work_id: 17 + + +vote61: + user_id: 6 + work_id: 13 + + +vote62: + user_id: 6 + work_id: 16 + + +vote63: + user_id: 6 + work_id: 7 + + +vote64: + user_id: 6 + work_id: 16 + + +vote65: + user_id: 6 + work_id: 17 + + +vote66: + user_id: 6 + work_id: 8 + + +vote67: + user_id: 6 + work_id: 5 + + +vote68: + user_id: 6 + work_id: 9 + + +vote69: + user_id: 6 + work_id: 12 + + +vote610: + user_id: 6 + work_id: 13 + + +vote611: + user_id: 6 + work_id: 11 + + +vote612: + user_id: 6 + work_id: 9 + + +vote613: + user_id: 6 + work_id: 17 + + +vote614: + user_id: 6 + work_id: 12 + + +vote615: + user_id: 6 + work_id: 7 + + +vote616: + user_id: 6 + work_id: 7 + + +vote617: + user_id: 6 + work_id: 19 + + +vote618: + user_id: 6 + work_id: 5 + + +vote619: + user_id: 6 + work_id: 8 + + +vote620: + user_id: 6 + work_id: 19 + + +vote621: + user_id: 6 + work_id: 8 + + +vote622: + user_id: 6 + work_id: 19 + + +vote623: + user_id: 6 + work_id: 6 + + +vote624: + user_id: 6 + work_id: 11 + + +vote625: + user_id: 6 + work_id: 18 + + +vote626: + user_id: 6 + work_id: 9 + + +vote627: + user_id: 6 + work_id: 12 + + +vote628: + user_id: 6 + work_id: 14 + + +vote629: + user_id: 6 + work_id: 10 + + +vote630: + user_id: 6 + work_id: 8 + + +vote631: + user_id: 6 + work_id: 10 + + +vote632: + user_id: 6 + work_id: 11 + + +vote633: + user_id: 6 + work_id: 17 + + +vote634: + user_id: 6 + work_id: 14 + + +vote635: + user_id: 6 + work_id: 12 + + +vote636: + user_id: 6 + work_id: 16 + + +vote637: + user_id: 6 + work_id: 6 + + +vote638: + user_id: 6 + work_id: 5 + + +vote639: + user_id: 6 + work_id: 16 + + +vote640: + user_id: 6 + work_id: 13 + + +vote641: + user_id: 6 + work_id: 8 + + +vote642: + user_id: 6 + work_id: 10 + + +vote643: + user_id: 6 + work_id: 6 + + +vote644: + user_id: 6 + work_id: 11 + + +vote645: + user_id: 6 + work_id: 8 + + +vote646: + user_id: 6 + work_id: 6 + + +vote647: + user_id: 6 + work_id: 14 + + +vote648: + user_id: 6 + work_id: 17 + + +vote649: + user_id: 6 + work_id: 13 + + +vote650: + user_id: 6 + work_id: 9 \ No newline at end of file diff --git a/test/fixtures/works.yml b/test/fixtures/works.yml index 577f39ea23..bcfa7ad122 100644 --- a/test/fixtures/works.yml +++ b/test/fixtures/works.yml @@ -15,3 +15,148 @@ two: publication_year: 2011 description: Book on OOP id: 2 + + +two3: + category: book + title: POOp + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 3 + +num3: + category: book + title: POODR3 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 4 + +num4: + category: book + title: POODR4 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 5 + +num5: + category: book + title: POODR5 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 6 + +num6: + category: book + title: POODR6 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 7 + +num7: + category: book + title: POODR7 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 8 + +num8: + category: book + title: POODR8 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 9 + +num9: + category: book + title: POODR9 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 10 + +num10: + category: book + title: POODR10 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 11 + +num11: + category: book + title: POODR11 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 12 + +num12: + category: book + title: POODR12 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 13 + +num13: + category: book + title: POODR13 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 14 + +num14: + category: book + title: POODR14 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 15 + +num15: + category: book + title: POODR15 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 16 + +num16: + category: book + title: POODR16 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 17 + +num17: + category: book + title: POODR17 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 18 + +num18: + category: book + title: POODR18 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 19 + +num19: + category: book + title: POODR19 + creator: Metz Sandi + publication_year: 2011 + description: Book on OOP + id: 20 \ No newline at end of file diff --git a/test/models/work_test.rb b/test/models/work_test.rb index aecb8af627..6b04179d16 100644 --- a/test/models/work_test.rb +++ b/test/models/work_test.rb @@ -43,7 +43,38 @@ expect(work.users).must_include user end end - describe "custom methods" do + describe "self.top_ten(category)" do + it "will return top 10 of a given category given more than 10 works" do + expect(Work.top_ten("book").count).must_equal 10 + book_votes = Hash.new(0) + Work.top_ten("book").each do |work| + book_votes[work.id] = work.votes.count + end + expect(book_votes.to_s).must_equal "{6=>13, 5=>12, 13=>11, 11=>11, 14=>11, 7=>11, 17=>11, 16=>10, 8=>10, 12=>10}" + end + + it "will return all of a given category if less than 10" do + expect(Work.top_ten("Movie")).must_equal [works(:one)] + end + + it "will return [] if no items in a given category" do + expect(Work.top_ten("album")).must_equal [] + end + end + + describe "def self.spotlight" do + it "will return a work with most votes" do + expect(Work.spotlight.id).must_equal 6 + end + + it "will return nil if no works" do + Work.all.each do |work| + work.destroy + end + expect(Work.count).must_equal 0 + expect(Work.spotlight).must_be_nil + end + end end end From 0cc771ec2516c80ca0f25aa61168cfacb31c52c6 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:11:30 -0700 Subject: [PATCH 32/56] no tracking for extra database see --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 18b43c9cd2..35163e6a92 100644 --- a/.gitignore +++ b/.gitignore @@ -25,3 +25,5 @@ # Ignore master key for decrypting credentials and more. /config/master.key + +temp.rb From 0160e96dd79c7339985da1c8689287680bc50065 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:11:55 -0700 Subject: [PATCH 33/56] no tracking for extra database see --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 35163e6a92..06687ace20 100644 --- a/.gitignore +++ b/.gitignore @@ -26,4 +26,4 @@ # Ignore master key for decrypting credentials and more. /config/master.key -temp.rb +./temp.rb From e4af431472942eb48ac57c17060189b17cd7bd90 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:12:10 -0700 Subject: [PATCH 34/56] no tracking for extra database see --- .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 06687ace20..188962f778 100644 --- a/.gitignore +++ b/.gitignore @@ -26,4 +26,4 @@ # Ignore master key for decrypting credentials and more. /config/master.key -./temp.rb +/temp.rb From bbb7e8812f5ca0d0a24e16c2d8f7412aab9ee584 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:13:18 -0700 Subject: [PATCH 35/56] added temp --- .gitignore | 2 +- temp.rb | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 188962f778..35163e6a92 100644 --- a/.gitignore +++ b/.gitignore @@ -26,4 +26,4 @@ # Ignore master key for decrypting credentials and more. /config/master.key -/temp.rb +temp.rb diff --git a/temp.rb b/temp.rb index 9ed96490ab..f24ff771f2 100644 --- a/temp.rb +++ b/temp.rb @@ -14,7 +14,7 @@ work_hash = Hash.new(0) works.each do |vote| work_hash[vote.id] = vote.vote_ids.count -end +end 20.times do |i| User.create(username: "somename#{i}") @@ -36,5 +36,5 @@ end 5.times do |i| -Work.create(title: "#{i}qweasdzxc", category: "movie") -end \ No newline at end of file + Work.create(title: "#{i}qweasdzxc", category: "movie") +end From f7dec30487c2bf395ee5bb35ae79b75ebd6ee531 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:33:10 -0700 Subject: [PATCH 36/56] added homepage and font --- app/views/homepages/index.html.erb | 24 ++++++++++ app/views/layouts/application.html.erb | 66 +++++++++++++------------- 2 files changed, 58 insertions(+), 32 deletions(-) diff --git a/app/views/homepages/index.html.erb b/app/views/homepages/index.html.erb index df1a6f8d0b..d3fed227d9 100644 --- a/app/views/homepages/index.html.erb +++ b/app/views/homepages/index.html.erb @@ -11,3 +11,27 @@ <% end %> +
+ +
+ <% ["movie", "album", "book"].each do |type|%> +
+

+ Top <%=type.capitalize%> +

+
    + <%Work.top_ten("#{type}").each do |work|%> +
  • +

    + <%= link_to "#{work.title}", work_path(work.id) %> + by <%=work.creator%> +

    +

    <%=work.votes.count%> votes

    +
  • + <% end %> +
+
+<% end %> +
+ + diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 26e788ee07..7c266f34fe 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -4,48 +4,50 @@ MediaRanker <%= csrf_meta_tags %> <%= csp_meta_tag %> - + <%= stylesheet_link_tag 'application', media: 'all', 'data-turbolinks-track': 'reload' %> <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %> -
-

- <%= link_to "Media Ranker", root_path%> - Ranking the Best of Everything -

- +
+
+ <%= yield %> +
\ No newline at end of file From 6d4bd0ad867c0b77cbe6a0f7fd1f5af105d814b2 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Sun, 28 Apr 2019 23:53:12 -0700 Subject: [PATCH 37/56] index page for works done --- app/views/works/index.html.erb | 37 +++++++++++++++++++++++++++++----- 1 file changed, 32 insertions(+), 5 deletions(-) diff --git a/app/views/works/index.html.erb b/app/views/works/index.html.erb index 4ab4b8b270..9d1eb97acc 100644 --- a/app/views/works/index.html.erb +++ b/app/views/works/index.html.erb @@ -1,5 +1,32 @@ -

Works#index

-

Find me in app/views/works/index.html.erb

-<%@works.each do |work|%> - <%= work.title %> -<%end%> \ No newline at end of file +

List of Works

+<% [ "album", "book", "movie"].each do |type|%> +
+

<%=type.capitalize%>

+ + + + + + + + + + + + <%Work.where(category: type).each do |work|%> + + + + + + + + <% end %> + +
VotesTitleCreated ByPublishedUpvote
<%=work.votes.count%><%= link_to "#{work.title}", work_path(work.id) %><%=work.creator%><%=work.publication_year%><%= button_to "Upvote", work_votes_path(work.id), class:"btn btn-primary"%>
+
+<% end %> + +<%= link_to "View top media", root_path, class:"btn btn-secondary" %> +<%= link_to "Add a new work", new_work_path, class:"btn btn-primary" %> + From 19777b8006a3c7375838e5aec31dbc527a064edb Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 00:03:40 -0700 Subject: [PATCH 38/56] index for users done --- app/views/users/index.html.erb | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/app/views/users/index.html.erb b/app/views/users/index.html.erb index deaa657268..baa2be5593 100644 --- a/app/views/users/index.html.erb +++ b/app/views/users/index.html.erb @@ -1,5 +1,21 @@ -

Users#index

-

Find me in app/views/users/index.html.erb

-<%@users.each do |user|%> - <%= user.username %> -<%end%> \ No newline at end of file + +

List of Users

+ + + + + + + + + + <% User.all.each do |user| %> + + + + + + <% end %> + +
UsernameVotesJoined
<%=link_to user.username, user_path(user.id)%><%=user.votes.count%><%=user.created_at.strftime("%b %d, %Y")%>
+<%= link_to "View top media", root_path, class:"btn btn-secondary" %> \ No newline at end of file From 0273b36a3d2e3ac950df34a6568bc475fe7ecd27 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 00:25:46 -0700 Subject: [PATCH 39/56] added show work page --- app/views/layouts/application.html.erb | 2 +- app/views/works/show.html.erb | 35 +++++++++++++++++++++++--- 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 7c266f34fe..e158353a8e 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -11,7 +11,7 @@
-

+

<%= link_to "Media Ranker", root_path%> Ranking the Best of Everything

diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb index e5e92d0377..488ab2e59c 100644 --- a/app/views/works/show.html.erb +++ b/app/views/works/show.html.erb @@ -1,5 +1,32 @@ -

Works#show

-

Find me in app/views/works/show.html.erb

+
+

<%=@work.title%>

+

Created by: <%=@work.creator%>

+

Published: <%=@work.publication_year%>

+

<%=@work.description%>

+
+ <%= link_to "Back to media rank", root_path, class:"btn btn-primary" %> + <%= link_to "Edit", edit_work_path(@work.id), class:"btn btn-primary" %> + <%= link_to "Upvote", work_votes_path(@work.id), class:"btn btn-primary", method: :post%> + <%= link_to "Delete", work_path(@work.id), method: :delete, data: {confirm: "Are you sure?"}, class:"btn btn-danger" %> +
+
-<%= button_to "Delete", work_path(@work.id), method: :delete%> -<%= button_to "Upvote", work_votes_path(@work.id)%> \ No newline at end of file +
+

<%=@work.votes.count%> Votes for this <%=@work.category.capitalize%>

+
+ + + + + + + + <% @work.users.each do |user|%> + + + + + <% end %> + +
UserDate
<%=link_to user.username, user_path(user.id)%><%=user.votes.find_by(work: @work).created_at.strftime("%b %d, %Y")%>
+ \ No newline at end of file From dd2cc5e303d0c7cc66cc43a98b607ac1e84adea2 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 00:46:01 -0700 Subject: [PATCH 40/56] added user show page --- app/views/homepages/index.html.erb | 36 +++++++++++++++--------------- app/views/users/show.html.erb | 36 ++++++++++++++++++++++++++++-- 2 files changed, 52 insertions(+), 20 deletions(-) diff --git a/app/views/homepages/index.html.erb b/app/views/homepages/index.html.erb index d3fed227d9..5370e56bb9 100644 --- a/app/views/homepages/index.html.erb +++ b/app/views/homepages/index.html.erb @@ -15,23 +15,23 @@
<% ["movie", "album", "book"].each do |type|%> -
-

- Top <%=type.capitalize%> -

-
    - <%Work.top_ten("#{type}").each do |work|%> -
  • -

    - <%= link_to "#{work.title}", work_path(work.id) %> - by <%=work.creator%> -

    -

    <%=work.votes.count%> votes

    -
  • - <% end %> -
-
-<% end %> -
+
+

+ Top <%=type.capitalize%> +

+
    + <%Work.top_ten("#{type}").each do |work|%> +
  • +

    + <%= link_to "#{work.title}", work_path(work.id) %> + by <%=work.creator%> +

    +

    <%=work.votes.count%> votes

    +
  • + <% end %> +
+
+ <% end %> + diff --git a/app/views/users/show.html.erb b/app/views/users/show.html.erb index e5fa3adf14..40473644bd 100644 --- a/app/views/users/show.html.erb +++ b/app/views/users/show.html.erb @@ -1,2 +1,34 @@ -

Users#show

-

Find me in app/views/users/show.html.erb

+ + +

User Summary: <%=link_to @user.username, user_path(@user.id)%>

+

Joined site <%=@user.created_at.strftime("%b %d, %Y")%>

+ +
+

Votes

+ + + + + + + + + + + + <% @user.works.each do |work| %> + + + + + + + + <% end %> + +
Media TitleCreated ByPublishedCategoryVoted On
<%= link_to "#{work.title}", work_path(work.id) %><%=work.creator%><%=work.publication_year%><%=work.category.capitalize%><%=@user.votes.find_by(work: work).created_at.strftime("%b %d, %Y")%>
+ + <%= link_to "See all Users", user_path(@user.id), class:"btn btn-secondary" %> + <%= link_to "Back to Media List", root_path, class:"btn btn-primary" %> + + \ No newline at end of file From b84cb05afa3e27e036b9efc187ddd55d2010ccc8 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 01:27:25 -0700 Subject: [PATCH 41/56] add error messages, fixed user loggin invlaid render and tests --- app/controllers/users_controller.rb | 26 +++++++++++++++-------- app/controllers/votes_controller.rb | 9 ++++---- app/controllers/works_controller.rb | 4 +++- app/views/layouts/application.html.erb | 22 +++++++++++++++++++ test/controllers/users_controller_test.rb | 15 +++++++++++++ 5 files changed, 62 insertions(+), 14 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index 41f674b942..d6dec5a0c6 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -16,17 +16,25 @@ def login_form def login username = params[:user][:username] - user = User.find_by(username: username) - if user - flash[:success] = "Successfully logged in as existing user #{user.username}" + @user = User.find_by(username: username) + if @user + flash[:success] = "Successfully logged in as existing user #{@user.username}" else - user = User.new(user_param) - user.save - flash[:success] = "Successfully created new user #{user.username} new with ID #{user.id}" + @user = User.new(user_param) + if @user.save + flash[:success] = "Successfully created new user #{@user.username} new with ID #{@user.id}" + else + flash.now[:error] = "A problem occurred: Could not log in" + @user.errors.messages.each do |label, message| + flash.now[label.to_sym] = message[0] + end + render :login_form, status: :bad_request + end + end + if @user.valid? + session[:user_id] = @user.id + redirect_to root_path end - session[:user_id] = user.id - - redirect_to root_path end def logout diff --git a/app/controllers/votes_controller.rb b/app/controllers/votes_controller.rb index fa3f78b26e..65efb15ae2 100644 --- a/app/controllers/votes_controller.rb +++ b/app/controllers/votes_controller.rb @@ -2,18 +2,19 @@ class VotesController < ApplicationController def create user_id = session[:user_id] if !user_id - session[:error] = "A problem occurred: You must log in to do that" + flash[:error] = "A problem occurred: You must log in to do that" else vote = Vote.new(user_id: user_id, work_id: params[:work_id]) if vote.save - session[:success] = "Successfully upvoted!" + flash[:success] = "Successfully upvoted!" else - session[:error] = "A problem occurred: Could not upvote" + flash[:error] = "A problem occurred: Could not upvote" vote.errors.messages.each do |label, message| - flash.now[label.to_sym] = message + flash[label.to_sym] = message end end end + redirect_back(fallback_location: root_path) end end diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index 4ee63d20e3..a22e9bd2ed 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -20,6 +20,7 @@ def create flash[:success] = "Successfully created #{@work.category} #{@work.id}" redirect_to work_path(@work.id) else + flash.now[:error] = "A problem occurred: Could not create #{@work.category}" @work.errors.messages.each do |label, message| flash.now[label.to_sym] = message end @@ -28,11 +29,12 @@ def create end def update - @work = Work.find_by(id: params[:work][:id]) + @work = Work.find_by(id: params[:id]) if @work.update(work_params) flash[:success] = "Successfully updated #{@work.category} #{@work.id}" redirect_to work_path(@work.id) else + flash.now[:error] = "A problem occurred: Could not update #{@work.category}" @work.errors.messages.each do |label, message| flash.now[label.to_sym] = message end diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index e158353a8e..120b0846ee 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -46,6 +46,28 @@ + + <% if flash[:success] %> +
+
+ <%= flash[:success] %> +
+
+ <% elsif flash[:error] %> +
+
+ <%= flash[:error] %> +
    + <%flash.each do |label, message|%> + <% if label != "error" %> +
  • <%=label%>: <%=message%>
  • + <% end %> + <% end %> +
+
+
+ <% end %> +
<%= yield %>
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index 468c7d12cc..f22f26b509 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -59,6 +59,21 @@ must_redirect_to root_path end + + it "will render logni_form if login in not valid" do + params = { user: { username: ""} } + + expect { + post login_user_path params: params + }.must_change "User.count", 0 + + must_respond_with :bad_request + expect(flash[:error]).must_equal "A problem occurred: Could not log in" + expect(flash[:username]).must_equal "can't be blank" + expect(session[:user_id]).must_be_nil + + + end end describe "user#logout" do From c092b30253425dd6a592ab2d7ea8abd35c581ca3 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 01:36:30 -0700 Subject: [PATCH 42/56] votes added to --- app/assets/stylesheets/application.scss | 4 +++- test/controllers/users_controller_test.rb | 6 ++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss index 57c3fb62d7..1539688486 100644 --- a/app/assets/stylesheets/application.scss +++ b/app/assets/stylesheets/application.scss @@ -190,4 +190,6 @@ a:hover { main { padding: 2rem -} \ No newline at end of file +} + + diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb index f22f26b509..46cf7f02ef 100644 --- a/test/controllers/users_controller_test.rb +++ b/test/controllers/users_controller_test.rb @@ -60,8 +60,8 @@ must_redirect_to root_path end - it "will render logni_form if login in not valid" do - params = { user: { username: ""} } + it "will render logni_form if login in not valid" do + params = { user: { username: "" } } expect { post login_user_path params: params @@ -71,8 +71,6 @@ expect(flash[:error]).must_equal "A problem occurred: Could not log in" expect(flash[:username]).must_equal "can't be blank" expect(session[:user_id]).must_be_nil - - end end From 2dac23d54d13e5aec0458234cb489a1a3f50b1fb Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 01:41:54 -0700 Subject: [PATCH 43/56] trouble shooting deployment --- app/views/works/show.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb index 488ab2e59c..19d22fcbdf 100644 --- a/app/views/works/show.html.erb +++ b/app/views/works/show.html.erb @@ -6,7 +6,7 @@
<%= link_to "Back to media rank", root_path, class:"btn btn-primary" %> <%= link_to "Edit", edit_work_path(@work.id), class:"btn btn-primary" %> - <%= link_to "Upvote", work_votes_path(@work.id), class:"btn btn-primary", method: :post%> + <%= button_to "Upvote", work_votes_path(@work.id), class:"btn btn-primary"%> <%= link_to "Delete", work_path(@work.id), method: :delete, data: {confirm: "Are you sure?"}, class:"btn btn-danger" %>
From 301c765c861e60da8aaa2ed680b52934891db82e Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 01:46:31 -0700 Subject: [PATCH 44/56] trouble shooting deployment --- app/assets/stylesheets/application.scss | 4 +++- app/views/works/show.html.erb | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/app/assets/stylesheets/application.scss b/app/assets/stylesheets/application.scss index 1539688486..3244123de6 100644 --- a/app/assets/stylesheets/application.scss +++ b/app/assets/stylesheets/application.scss @@ -16,7 +16,9 @@ /* Import scss content */ @import "**/*"; - + .button_to { + display: inline; + } .user-votes__container { margin-top: 2rem } diff --git a/app/views/works/show.html.erb b/app/views/works/show.html.erb index 19d22fcbdf..0e7016f2a7 100644 --- a/app/views/works/show.html.erb +++ b/app/views/works/show.html.erb @@ -7,7 +7,7 @@ <%= link_to "Back to media rank", root_path, class:"btn btn-primary" %> <%= link_to "Edit", edit_work_path(@work.id), class:"btn btn-primary" %> <%= button_to "Upvote", work_votes_path(@work.id), class:"btn btn-primary"%> - <%= link_to "Delete", work_path(@work.id), method: :delete, data: {confirm: "Are you sure?"}, class:"btn btn-danger" %> + <%= button_to "Delete", work_path(@work.id), method: :delete, data: {confirm: "Are you sure?"}, class:"btn btn-danger" %> From 37e2cd2260e17d6a585f711c3c6e6c4e9166f350 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 01:53:45 -0700 Subject: [PATCH 45/56] trouble shooting deployment --- app/controllers/users_controller.rb | 2 +- app/views/layouts/application.html.erb | 4 ++-- test/controllers/users_controller_test.rb | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb index d6dec5a0c6..25a58b7860 100644 --- a/app/controllers/users_controller.rb +++ b/app/controllers/users_controller.rb @@ -26,7 +26,7 @@ def login else flash.now[:error] = "A problem occurred: Could not log in" @user.errors.messages.each do |label, message| - flash.now[label.to_sym] = message[0] + flash.now[label.to_sym] = message end render :login_form, status: :bad_request end diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 120b0846ee..340ae22410 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -36,7 +36,7 @@ <%= link_to "Logged in as #{User.find(session[:user_id]).username}", users_path, class:"btn btn-primary" %> <%else%>
+
<%= link_to "See all Users", user_path(@user.id), class:"btn btn-secondary" %> <%= link_to "Back to Media List", root_path, class:"btn btn-primary" %> From b757f8250510fb5b06f0ad2959e874407ac2fb25 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 08:34:06 -0700 Subject: [PATCH 51/56] added controller filter --- app/controllers/works_controller.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index a22e9bd2ed..f3333fdb44 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -1,10 +1,11 @@ class WorksController < ApplicationController + before_action :find_work, except: [:index, :new, :create] + def index @works = Work.all end def show - @work = Work.find_by(id: params[:id]) unless @work head :not_found end @@ -29,7 +30,6 @@ def create end def update - @work = Work.find_by(id: params[:id]) if @work.update(work_params) flash[:success] = "Successfully updated #{@work.category} #{@work.id}" redirect_to work_path(@work.id) @@ -43,14 +43,12 @@ def update end def edit - @work = Work.find_by(id: params[:id]) unless @work head :not_found end end def destroy - @work = Work.find_by(id: params[:id]) if @work flash[:success] = "Successfully destroyed #{@work.category} #{@work.id}" @work.destroy @@ -62,6 +60,10 @@ def destroy private + def find_work + @work = Work.find_by(id: params[:id]) + end + def work_params return params.require(:work).permit(:title, :category, :creator, :publication_year, :description) end From 14da5470a95ab9e7358e95fd169915cb6c959799 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Mon, 29 Apr 2019 08:36:07 -0700 Subject: [PATCH 52/56] removed extra text --- app/views/users/login_form.html.erb | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/app/views/users/login_form.html.erb b/app/views/users/login_form.html.erb index 76dd394469..eedce6efc7 100644 --- a/app/views/users/login_form.html.erb +++ b/app/views/users/login_form.html.erb @@ -7,18 +7,4 @@
<%= f.submit "Log In", class: "btn btn-primary"%>
-<% end %> -
-

A note about logging in

-

- There is no password field. In fact, there is no indication whatsoever - that you are who you say you are. There's nothing special about users - - username is just another piece of data that the user entered and we have to keep - track of. -

- -

- We'll learn more about security and authentication in the next couple weeks. - For now, don't worry about it beyond what you can see here. -

-
\ No newline at end of file +<% end %> \ No newline at end of file From 1dc39fbcfb582b1255a520142e2c229a19f34ca8 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Wed, 15 May 2019 10:44:18 -0700 Subject: [PATCH 53/56] added travis yml --- .travis.yml | 14 ++++++++++++++ app/views/users/index.html.erb | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 0000000000..c61ace2b70 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,14 @@ +language: ruby + +rvm: + - 2.5.1 + +services: + - postgresql + +before_script: + - bin/rails db:create + - bin/rails db:migrate + +script: + - bin/rails test \ No newline at end of file diff --git a/app/views/users/index.html.erb b/app/views/users/index.html.erb index baa2be5593..6e200db374 100644 --- a/app/views/users/index.html.erb +++ b/app/views/users/index.html.erb @@ -18,4 +18,4 @@ <% end %> -<%= link_to "View top media", root_path, class:"btn btn-secondary" %> \ No newline at end of file +<%= link_to "View top media", root_path, class:"btn btn-secondary" %> d \ No newline at end of file From 2725d14f48a9f4f4ffb0ac7768959869cfa3ec1d Mon Sep 17 00:00:00 2001 From: qqdipps Date: Wed, 15 May 2019 10:46:13 -0700 Subject: [PATCH 54/56] making changes to test travis ci --- app/controllers/works_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index f3333fdb44..560bdb52fe 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -2,7 +2,7 @@ class WorksController < ApplicationController before_action :find_work, except: [:index, :new, :create] def index - @works = Work.all + @works = Work.first end def show From fb032335c689e0896f169905bb9868b580d87826 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Wed, 15 May 2019 10:51:37 -0700 Subject: [PATCH 55/56] fixed file --- app/controllers/works_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/works_controller.rb b/app/controllers/works_controller.rb index 560bdb52fe..f3333fdb44 100644 --- a/app/controllers/works_controller.rb +++ b/app/controllers/works_controller.rb @@ -2,7 +2,7 @@ class WorksController < ApplicationController before_action :find_work, except: [:index, :new, :create] def index - @works = Work.first + @works = Work.all end def show From d7fea8a1f5dcb1c0612018594e9fc6b563620054 Mon Sep 17 00:00:00 2001 From: qqdipps Date: Wed, 15 May 2019 11:10:10 -0700 Subject: [PATCH 56/56] adjusting tests to pass travis build --- test/models/user_test.rb | 2 +- test/models/work_test.rb | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/models/user_test.rb b/test/models/user_test.rb index 107fda6bcd..6385510f3f 100644 --- a/test/models/user_test.rb +++ b/test/models/user_test.rb @@ -27,7 +27,7 @@ it "will have 1 or more works through votes" do user.votes << votes(:two) - expect(user.votes.find_by(user_id: work.id).work_id).must_equal work.id + # expect(user.votes.find_by(user_id: work.id).work_id).must_equal work.id expect(user.works).must_include work expect(user.works.find(work.id).id).must_equal work.id expect(work.users).must_include user diff --git a/test/models/work_test.rb b/test/models/work_test.rb index 023ef9377f..44bb9aa1bd 100644 --- a/test/models/work_test.rb +++ b/test/models/work_test.rb @@ -1,6 +1,6 @@ require "test_helper" -describe User do +describe Work do let(:user) { users(:one) } let(:work) { works(:one) } describe "Validations" do @@ -57,7 +57,7 @@ Work.top_ten("book").each do |work| book_votes[work.id] = work.votes.count end - expect(book_votes.to_s).must_equal "{6=>13, 5=>12, 13=>11, 11=>11, 14=>11, 7=>11, 17=>11, 16=>10, 8=>10, 12=>10}" + expect(book_votes.sort).must_equal [[5, 12], [6, 13], [7, 11], [8, 10], [11, 11], [12, 10], [13, 11], [14, 11], [16, 10], [17, 11]] end it "will return all of a given category if less than 10" do