diff --git a/app/__init__.py b/app/__init__.py index 70b4cabfe..9e4e3fbf1 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -1,7 +1,36 @@ from flask import Flask +from flask_sqlalchemy import SQLAlchemy +from flask_migrate import Migrate +from dotenv import load_dotenv +import os + +db = SQLAlchemy() +migrate = Migrate() +load_dotenv() def create_app(test_config=None): app = Flask(__name__) + if not test_config: + app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False + app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get( + "SQLALCHEMY_DATABASE_URI") + + else: + app.config["TESTING"] = True + app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False + app.config['SQLALCHEMY_DATABASE_URI'] = os.environ.get( + "SQLALCHEMY_TEST_DATABASE_URI") + + db.init_app(app) + migrate.init_app(app, db) + + from app.models.planet import Planet + + from .planet_routes import planets_bp + app.register_blueprint(planets_bp) + + + return app diff --git a/app/helper.py b/app/helper.py new file mode 100644 index 000000000..7d44a01f5 --- /dev/null +++ b/app/helper.py @@ -0,0 +1,16 @@ +from app import db +from app.models.planet import Planet +from flask import Blueprint, jsonify, abort, make_response, request + +def validate_model(cls,model_id): + try: + model_id = int(model_id) + except: + abort(make_response({"error message": f"{cls.__name__} {model_id} is invalid"}, 400)) + + model = cls.query.get(model_id) + + if not model: + abort(make_response({"error message": f"{cls.__name__} {model_id} not found"}, 404)) + + return model \ No newline at end of file diff --git a/app/models/__init__.py b/app/models/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/app/models/planet.py b/app/models/planet.py new file mode 100644 index 000000000..59cde40ce --- /dev/null +++ b/app/models/planet.py @@ -0,0 +1,23 @@ +from app import db + +class Planet(db.Model): + id = db.Column(db.Integer, primary_key=True, autoincrement=True) + name = db.Column(db.String, nullable=False) + description = db.Column(db.String, nullable=False) + num_moons = db.Column(db.Integer, nullable=False) + + def to_dict(self): + return { + "id": self.id, + "name": self.name, + "description": self.description, + "num_moons": self.num_moons + } + + @classmethod + def from_dict(cls, data_dict): + return cls( + name = data_dict["name"], + description = data_dict["description"], + num_moons = data_dict["num_moons"] + ) \ No newline at end of file diff --git a/app/planet_routes.py b/app/planet_routes.py new file mode 100644 index 000000000..0cba42f57 --- /dev/null +++ b/app/planet_routes.py @@ -0,0 +1,67 @@ +from app import db +from app.models.planet import Planet +from app.helper import validate_model +from flask import Blueprint, jsonify, abort, make_response, request + + +planets_bp = Blueprint("planets", __name__, url_prefix="/planets") + +@planets_bp.route("", methods=["POST"]) +def create_planets(): + request_body = request.get_json() + try: + new_planet = Planet.from_dict(request_body) + db.session.add(new_planet) + db.session.commit() + + return make_response(jsonify(f"Planet {new_planet.name} successfully created"), 201) + + except KeyError as error: + abort(make_response({"error message": f"missing required value: {error}"}, 400)) + +@planets_bp.route("", methods=["GET"]) +def read_all_planets(): + name_query = request.args.get("name") + description_query = request.args.get("description") + num_moons_query = request.args.get("num_moons") + if name_query: + planets = Planet.query.filter_by(name = name_query) + + if num_moons_query: + planets = Planet.query.filter_by(num_moons = num_moons_query) + + else: + planets = Planet.query.all() + + planets_response = [planet.to_dict() for planet in planets] + return jsonify(planets_response) + + +@planets_bp.route("/", methods=["GET"]) +def read_one_planet(planet_id): + planet = validate_model(Planet,planet_id) + + return jsonify(planet.to_dict()) + + +@planets_bp.route("/", methods=["PUT"]) +def update_planet(planet_id): + planet = validate_model(planet_id) + + request_body = request.get_json() + planet.name = request_body["name"] + planet.description = request_body["description"] + planet.num_moons = request_body["num_moons"] + + db.session.commit() + + return make_response(f"Planet {planet.id} successfully updated") + +@planets_bp.route("/", methods=["DELETE"]) +def delete_planet(planet_id): + planet = validate_model(planet_id) + + db.session.delete(planet) + db.session.commit() + + return make_response(f"Planet {planet.id} successfully deleted") \ No newline at end of file diff --git a/app/routes.py b/app/routes.py deleted file mode 100644 index 8e9dfe684..000000000 --- a/app/routes.py +++ /dev/null @@ -1,2 +0,0 @@ -from flask import Blueprint - diff --git a/migrations/README b/migrations/README new file mode 100644 index 000000000..98e4f9c44 --- /dev/null +++ b/migrations/README @@ -0,0 +1 @@ +Generic single-database configuration. \ No newline at end of file diff --git a/migrations/alembic.ini b/migrations/alembic.ini new file mode 100644 index 000000000..f8ed4801f --- /dev/null +++ b/migrations/alembic.ini @@ -0,0 +1,45 @@ +# A generic, single database configuration. + +[alembic] +# template used to generate migration files +# file_template = %%(rev)s_%%(slug)s + +# set to 'true' to run the environment during +# the 'revision' command, regardless of autogenerate +# revision_environment = false + + +# Logging configuration +[loggers] +keys = root,sqlalchemy,alembic + +[handlers] +keys = console + +[formatters] +keys = generic + +[logger_root] +level = WARN +handlers = console +qualname = + +[logger_sqlalchemy] +level = WARN +handlers = +qualname = sqlalchemy.engine + +[logger_alembic] +level = INFO +handlers = +qualname = alembic + +[handler_console] +class = StreamHandler +args = (sys.stderr,) +level = NOTSET +formatter = generic + +[formatter_generic] +format = %(levelname)-5.5s [%(name)s] %(message)s +datefmt = %H:%M:%S diff --git a/migrations/env.py b/migrations/env.py new file mode 100644 index 000000000..8b3fb3353 --- /dev/null +++ b/migrations/env.py @@ -0,0 +1,96 @@ +from __future__ import with_statement + +import logging +from logging.config import fileConfig + +from sqlalchemy import engine_from_config +from sqlalchemy import pool +from flask import current_app + +from alembic import context + +# this is the Alembic Config object, which provides +# access to the values within the .ini file in use. +config = context.config + +# Interpret the config file for Python logging. +# This line sets up loggers basically. +fileConfig(config.config_file_name) +logger = logging.getLogger('alembic.env') + +# add your model's MetaData object here +# for 'autogenerate' support +# from myapp import mymodel +# target_metadata = mymodel.Base.metadata +config.set_main_option( + 'sqlalchemy.url', + str(current_app.extensions['migrate'].db.engine.url).replace('%', '%%')) +target_metadata = current_app.extensions['migrate'].db.metadata + +# other values from the config, defined by the needs of env.py, +# can be acquired: +# my_important_option = config.get_main_option("my_important_option") +# ... etc. + + +def run_migrations_offline(): + """Run migrations in 'offline' mode. + + This configures the context with just a URL + and not an Engine, though an Engine is acceptable + here as well. By skipping the Engine creation + we don't even need a DBAPI to be available. + + Calls to context.execute() here emit the given string to the + script output. + + """ + url = config.get_main_option("sqlalchemy.url") + context.configure( + url=url, target_metadata=target_metadata, literal_binds=True + ) + + with context.begin_transaction(): + context.run_migrations() + + +def run_migrations_online(): + """Run migrations in 'online' mode. + + In this scenario we need to create an Engine + and associate a connection with the context. + + """ + + # this callback is used to prevent an auto-migration from being generated + # when there are no changes to the schema + # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html + def process_revision_directives(context, revision, directives): + if getattr(config.cmd_opts, 'autogenerate', False): + script = directives[0] + if script.upgrade_ops.is_empty(): + directives[:] = [] + logger.info('No changes in schema detected.') + + connectable = engine_from_config( + config.get_section(config.config_ini_section), + prefix='sqlalchemy.', + poolclass=pool.NullPool, + ) + + with connectable.connect() as connection: + context.configure( + connection=connection, + target_metadata=target_metadata, + process_revision_directives=process_revision_directives, + **current_app.extensions['migrate'].configure_args + ) + + with context.begin_transaction(): + context.run_migrations() + + +if context.is_offline_mode(): + run_migrations_offline() +else: + run_migrations_online() diff --git a/migrations/script.py.mako b/migrations/script.py.mako new file mode 100644 index 000000000..2c0156303 --- /dev/null +++ b/migrations/script.py.mako @@ -0,0 +1,24 @@ +"""${message} + +Revision ID: ${up_revision} +Revises: ${down_revision | comma,n} +Create Date: ${create_date} + +""" +from alembic import op +import sqlalchemy as sa +${imports if imports else ""} + +# revision identifiers, used by Alembic. +revision = ${repr(up_revision)} +down_revision = ${repr(down_revision)} +branch_labels = ${repr(branch_labels)} +depends_on = ${repr(depends_on)} + + +def upgrade(): + ${upgrades if upgrades else "pass"} + + +def downgrade(): + ${downgrades if downgrades else "pass"} diff --git a/migrations/versions/6f10d35aed47_adds_planet_model.py b/migrations/versions/6f10d35aed47_adds_planet_model.py new file mode 100644 index 000000000..cdd58db95 --- /dev/null +++ b/migrations/versions/6f10d35aed47_adds_planet_model.py @@ -0,0 +1,34 @@ +"""adds Planet model + +Revision ID: 6f10d35aed47 +Revises: +Create Date: 2023-04-28 19:09:55.071118 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = '6f10d35aed47' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('planet', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('name', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('num_moons', sa.Integer(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('planet') + # ### end Alembic commands ### diff --git a/migrations/versions/c2db3d6bd34d_adds_planet_model.py b/migrations/versions/c2db3d6bd34d_adds_planet_model.py new file mode 100644 index 000000000..2ea345111 --- /dev/null +++ b/migrations/versions/c2db3d6bd34d_adds_planet_model.py @@ -0,0 +1,34 @@ +"""adds Planet model + +Revision ID: c2db3d6bd34d +Revises: +Create Date: 2023-04-30 17:09:28.989027 + +""" +from alembic import op +import sqlalchemy as sa + + +# revision identifiers, used by Alembic. +revision = 'c2db3d6bd34d' +down_revision = None +branch_labels = None +depends_on = None + + +def upgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.create_table('planet', + sa.Column('id', sa.Integer(), autoincrement=True, nullable=False), + sa.Column('name', sa.String(), nullable=True), + sa.Column('description', sa.String(), nullable=True), + sa.Column('num_moons', sa.Integer(), nullable=True), + sa.PrimaryKeyConstraint('id') + ) + # ### end Alembic commands ### + + +def downgrade(): + # ### commands auto generated by Alembic - please adjust! ### + op.drop_table('planet') + # ### end Alembic commands ### diff --git a/tests/__init__.py b/tests/__init__.py new file mode 100644 index 000000000..e69de29bb diff --git a/tests/conftest.py b/tests/conftest.py new file mode 100644 index 000000000..8112a1b95 --- /dev/null +++ b/tests/conftest.py @@ -0,0 +1,49 @@ +import pytest +from app import create_app, db +from flask.signals import request_finished +from app.models.planet import Planet + + +@pytest.fixture +def app(): + app = create_app({"TESTING": True}) + + @request_finished.connect_via(app) + def expire_session(sender, response, **extra): + db.session.remove() + + with app.app_context(): + db.create_all() + yield app + + with app.app_context(): + db.drop_all() + + +@pytest.fixture +def client(app): + return app.test_client() + +@pytest.fixture +def one_planet(app): + planet = Planet( + name = "Mercury", + description = "It's the first planet in our solar system", + num_moons = 0 + ) + db.session.add(planet) + db.session.commit() + return planet + + +@pytest.fixture +def saved_planets(app, one_planet): + planet_two = Planet(name = "Venus", + description = "It's the second planet in our solar system", + num_moons = 0) + planet_three = Planet(name = "Earth", + description = "It's the third planet in our solar system", + num_moons = 1) + + db.session.add_all([one_planet, planet_two, planet_three]) + db.session.commit() diff --git a/tests/test_routes.py b/tests/test_routes.py new file mode 100644 index 000000000..ef96eb293 --- /dev/null +++ b/tests/test_routes.py @@ -0,0 +1,85 @@ +from app.models.planet import Planet + +def test_get_all_planets_with_no_records(client): + # Act + response = client.get("/planets") + response_body = response.get_json() + + # Assert + assert response.status_code == 200 + assert response_body == [] + +def test_get_one_planet_returns_seeded_planet(client, one_planet): + response = client.get(f"/planets/{one_planet.id}") + response_body = response.get_json() + + assert response.status_code == 200 + assert response_body["id"] == one_planet.id + assert response_body["name"] == one_planet.name + assert response_body["description"] == one_planet.description + assert response_body["num_moons"] == one_planet.num_moons + + +def test_create_planet_happy_path(client): + # arrange + EXPECTED_PLANET = { + "name": "Mercury", + "description": "It's the first planet in our solar system", + "num_moons": 0 + } + + response = client.post("/planets", json=EXPECTED_PLANET) + response_body = response.get_json() + + actual_planet = Planet.query.get(1) + assert response.status_code == 201 + assert response_body == f"Planet {EXPECTED_PLANET['name']} successfully created" + assert actual_planet.name == EXPECTED_PLANET["name"] + assert actual_planet.description == EXPECTED_PLANET["description"] + assert actual_planet.num_moons == EXPECTED_PLANET["num_moons"] + + +def test_get_one_planet_id_not_found(client, one_planet): + # Act + response = client.get("/planets/4") + response_body = response.get_json() + + # Assert + assert response.status_code == 404 + assert response_body == {"error message":"Planet 4 not found"} + + +def test_get_all_planets_with_saved_records(client, saved_planets): + #Assert + EXPECTED_PLANET_ONE_NAME= {"name": "Mercury"} + EXPECTED_PLANET_TWO_DESCRIPTION= {"description": "It's the second planet in our solar system"} + EXPECTED_PLANET_THREE_NUM_MOONS= {"num_moons": 1} + + response = client.get("/planets") + response_saved_body = response.get_json() + + planet_one = Planet.query.get(1) + planet_two = Planet.query.get(2) + planet_three = Planet.query.get(3) + assert response.status_code == 200 + assert len(response_saved_body) == 3 + assert planet_one.name == EXPECTED_PLANET_ONE_NAME["name"] + assert planet_two.description == EXPECTED_PLANET_TWO_DESCRIPTION["description"] + assert planet_three.num_moons == EXPECTED_PLANET_THREE_NUM_MOONS["num_moons"] + + +def test_create_planet_raises_key_error_with_missing_atr(client): + error_planet = { + "name": "Pluto", + "description": "It's the first planet in our solar system" + } + + response = client.post("/planets", json=error_planet) + response_body = response.get_json() + + assert response.status_code == 400 + assert response_body == {"error message": f"missing required value: 'num_moons'"}, 400 + + + +