-
Notifications
You must be signed in to change notification settings - Fork 79
Rename the malformed test file webhook mapper.test.ts #105
Copy link
Copy link
Open
Labels
GrantFox OSSGrantFox Open Source Sponsorship program tagGrantFox Open Source Sponsorship program tagMaybe RewardedIssue may qualify for a reward upon successful completion per campaign rulesIssue may qualify for a reward upon successful completion per campaign rulesThird CampaignOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsbugConfirmed defect or incorrect behavior that needs to be fixedConfirmed defect or incorrect behavior that needs to be fixedgood first issueWell-scoped issue suitable for contributors making an initial contribution to the projectWell-scoped issue suitable for contributors making an initial contribution to the projectteststeststests
Description
Activity
Metadata
Metadata
Assignees
Labels
GrantFox OSSGrantFox Open Source Sponsorship program tagGrantFox Open Source Sponsorship program tagMaybe RewardedIssue may qualify for a reward upon successful completion per campaign rulesIssue may qualify for a reward upon successful completion per campaign rulesThird CampaignOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsOfficial FWC26 campaign issue — eligible for campaign scoring and rewardsbugConfirmed defect or incorrect behavior that needs to be fixedConfirmed defect or incorrect behavior that needs to be fixedgood first issueWell-scoped issue suitable for contributors making an initial contribution to the projectWell-scoped issue suitable for contributors making an initial contribution to the projectteststeststests
Rename the malformed test file
webhook mapper.test.tsDifficulty: Intermediate
Type: Bug
Background:
apps/dashboard/test/webhook mapper.test.tscontains a literal space in its filename, sitting alongside the correctly namedwebhook-mapper.test.ts-style siblings such aswebhook.test.tsandwebhook-validation.test.ts.Problem: The stray space is inconsistent with every other test file in the repo, can break shell globbing/tooling on some CI or editor configurations, and looks like an accidental save-as.
Expected outcome: The file is renamed to
webhook-mapper.test.ts(or merged into an existing mapper test file if content overlaps), with no loss of test coverage.Suggested implementation:
git mv "apps/dashboard/test/webhook mapper.test.ts" apps/dashboard/test/webhook-mapper.test.tslib/activity/mapper.tsand imports resolve correctly.package.jsontest glob patterns don't special-case the old name.Acceptance criteria:
pnpm test(or the dashboard's test script) discovers and runs the renamed file.mapper-related suites.Likely affected files:
apps/dashboard/test/webhook mapper.test.tsLabels:
bug,good first issue,tests,GrantFox OSS,Maybe Rewarded,Official Campaign | FWC26