Skip to content

createAdminUser calls getCurrentActorFromAls() which is defined at the bottom of the file after usage #202

Description

@Nabeelahh

Area: Backend

  • Description: getCurrentActorFromAls is referenced inside createAdminUser but defined at the bottom of auth.service.ts after an import block. While JavaScript hoisting keeps it functional, the structure is confusing and the function relies on imports that are explicitly suppressed with void — move it to a shared utility.
  • File(s): backend/src/auth/auth.service.ts
  • Priority: Low
  • Implementation & verification: Trace all controller, service, provider, and module-registration callers before changing the implementation so the DTO and HTTP-error contract remains stable. Add focused automated coverage for the reported failure mode and the expected successful path, mocking external services where applicable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions