Skip to content

Same pattern in resendResetPasswordVerificationOtp — all errors become 500s #204

Description

@Nabeelahh

Area: Backend

  • Description: resendResetPasswordVerificationOtp wraps its catch block the same way as resendVerificationOtp, swallowing typed HTTP exceptions and returning a 500 to the client for any error, including expected ones like NotFoundException.
  • File(s): backend/src/auth/auth.service.ts, backend/src/auth/auth.service.spec.ts
  • Priority: Medium
  • Implementation & verification: Trace all controller, service, provider, and module-registration callers before changing the implementation so the DTO and HTTP-error contract remains stable. Add focused automated coverage for the reported failure mode and the expected successful path, mocking external services where applicable.
  • Work distribution: Implementation: backend/src/auth/auth.service.ts. Integration: update the closest controller, module, DTO, or caller only if the service contract changes. Verification: backend/src/auth/auth.service.spec.ts.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions