`payment_escrow` does not validate that `fee_bps` ≤ 10,000 on `initialize

[Nabeelahh]

• Area: Smart Contract
• Description: initialize stores whatever fee_bps value is passed without checking it is a valid basis-point value (0–10,000). A fee above 10,000 bps would attempt to transfer more than the deposited amount, causing an arithmetic underflow and a panic.
• File(s): contracts/payment_escrow/src/lib.rs
• Priority: High
• Implementation & verification: Treat this as a protocol-safety change: check authorization, storage/ABI compatibility, ledger-time behavior, and emitted events before changing the implementation. Add a contract-level regression test for both the invalid and successful paths.
• Required change set (2–6 files): Change the relevant contract implementation together with its focused contract test, and include a type, error, or deployment-script adjustment only when required.

[Spectre-crypto540]

@Spectre-crypto540 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello! This issue matches my skillset well. I’d appreciate the opportunity to work on it and submit a clean fix.

Thank you

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Spectre-crypto540 to this issue.

[drips-wave]

Congratulations, @Spectre-crypto540! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Spectre-crypto540: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊