`access_control` pending proposals list is never cleaned up when a proposal is rejected

[Nabeelahh]

• Area: Smart Contract
• Description: PendingProposalsList has a cleanup_expired_proposal helper but there is no counterpart that removes a proposal from the list when it is explicitly rejected via vote. Over time the list accumulates stale proposal IDs and the max_pending_proposals cap can be hit prematurely.
• File(s): contracts/access_control/src/access_control.rs
• Priority: Medium
• Implementation & verification: Treat this as a protocol-safety change: check authorization, storage/ABI compatibility, ledger-time behavior, and emitted events before changing the implementation. Add a contract-level regression test for both the invalid and successful paths.
• **Required change set **: Change the relevant contract implementation together with its focused contract test, and include a type, error, or deployment-script adjustment only when required

[Cedarich]

@Cedarich has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hello maintainer can i take up this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Cedarich to this issue.

[drips-wave]

Congratulations, @Cedarich! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @Cedarich: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been marked as completed by a Drips Wave moderator for @Cedarich as part of the Stellar Wave Program's 8th Wave 🥳

Moderator's reason: [Auto-assessed] The PR #321 has been merged (mergedAt: 2026-08-26T12:57:51Z) and features an explicit APPROVE review from maintainer @Qoder-Voidd. The changes successfully implement the requested cleanup function for rejected proposals in contracts/access_control/src/access_control.rs and include the required regression test.

😎 @Cedarich: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

ℹ️ Note: This issue was marked complete via moderation. Points were issued even though the GitHub issue remains open.