Skip to content

manage_hub::subscription — subscription cancellation does not emit a cancellation event #279

Description

@Nabeelahh
  • Area: Smart Contract
  • Description: cancel_subscription updates the subscription status in storage but a review of the module should confirm whether an event is published. If it is missing, add env.events().publish(...) so indexers can track cancellations without polling storage.
  • File(s): contracts/manage_hub/src/subscription.rs
  • Priority: Medium
  • Implementation & verification: Treat this as a protocol-safety change: check authorization, storage/ABI compatibility, ledger-time behavior, and emitted events before changing the implementation. Add a contract-level regression test for both the invalid and successful paths.
  • **Required change set **: Change the relevant contract implementation together with its focused contract test, and include a type, error, or deployment-script adjustment only when required.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions