Tests

Author: AllanKoder

app/Http/Controllers/ComputerScienceResourceController.php

@@ -122,8 +122,8 @@ public function store(StoreResourceRequest $request)
                 'platforms' => $resource->platforms,
             ]);
 
-            return redirect(route('resources.show', ['slug' => $resource->slug]))
-                ->with('success', 'Created Resource!');
+            $request->session()->flash('success', 'Created Resource!');
+            return response()->json($resource);
         } catch (Throwable $e) {
             DB::rollBack();
             Log::critical('Failed to create resource', [
@@ -133,7 +133,7 @@ public function store(StoreResourceRequest $request)
                 'data' => $validatedData,
             ]);
 
-            return back()->withErrors(['error' => 'Failed to create resource. Please try again.']);
+            return response()->json([], 500);
         }
     }
 

app/Http/Controllers/ResourceReviewController.php

@@ -58,7 +58,7 @@ public function store(StoreResourceReview $request, ComputerScienceResource $com
             'review_id' => $review->id,
         ]);
 
-        return response()->json();
+        return response()->json($review);
     }
 
     public function update(StoreResourceReview $request, ComputerScienceResource $computerScienceResource)
@@ -106,6 +106,6 @@ public function update(StoreResourceReview $request, ComputerScienceResource $co
             'review_id' => $existingReview->id,
         ]);
 
-        return response()->json();
+        return response()->json($existingReview);
     }
 }

resources/js/Components/Comments/Commentable.vue

@@ -28,7 +28,7 @@ const props = defineProps({
     },
     sortByInitialValue: {
         type: String,
-        default: "top"
+        default: "top",
     },
     loadedCommentData: {
         type: Object,
@@ -60,7 +60,9 @@ const createdNewCommentCallback = (newComment, userData) => {
 
     // Ensure DOM updates are complete, then scroll to the new comment
     nextTick(() => {
-        const newCommentElement = commentRefs.value.get(`comment_${newComment.id}`);
+        const newCommentElement = commentRefs.value.get(
+            `comment_${newComment.id}`
+        );
         if (newCommentElement) {
             newCommentElement.scrollIntoView({
                 behavior: "smooth",
@@ -80,8 +82,10 @@ provide("commentRefs", commentRefs);
 const showEmptyState = computed(() => {
     return (
         hasLoadedCommentData &&
-        idToChildren.value instanceof Map &&
-        (!idToChildren.value.get(null) || idToChildren.value.get(null).length === 0)
+        (!idToChildren.value ||
+            !(idToChildren.value instanceof Map) ||
+            !idToChildren.value.get(null) ||
+            idToChildren.value.get(null).length === 0)
     );
 });
 

resources/js/Components/Resources/Reviews/CreateResourceReview.vue

@@ -67,7 +67,6 @@ const formFields = [
 
 const {
     isSavedToLocalStorage,
-    isDataLoaded,
     hasFormContent,
     clearLocalStorage,
 } = useLocalStorageSaver(form, props.resourceId, formFields, "review-draft");
@@ -114,9 +113,7 @@ const submitReview = async (event) => {
 </script>
 
 <template>
-    <!-- Main container, conditionally rendered -->
     <div
-        v-if="isDataLoaded"
         class="mx-auto bg-white shadow-lg rounded-2xl p-6 relative"
     >
         <FormSaverChip

…s/js/Components/SubmissionGuidelines.vue …nents/Resources/SubmissionGuidelines.vueresources/js/Components/SubmissionGuidelines.vue renamed to resources/js/Components/Resources/SubmissionGuidelines.vue resources/js/Components/SubmissionGuidelines.vue renamed to resources/js/Components/Resources/SubmissionGuidelines.vue

@@ -3,7 +3,6 @@ import { ref, computed, onMounted, onUnmounted, watch } from "vue";
 export function useLocalStorageSaver(form, localStorageKeyId, formFields, keyPrefix = 'edit-draft') {
     const localStorageKey = computed(() => `${keyPrefix}-${localStorageKeyId}`);
     const isSavedToLocalStorage = ref(false);
-    const isDataLoaded = ref(false);
 
     const hasFormContent = computed(() => {
         return formFields.some(field => {
@@ -43,14 +42,17 @@ export function useLocalStorageSaver(form, localStorageKeyId, formFields, keyPre
                         form[field] = parsedData[field];
                     }
                 });
+                // Always keep image_file as null after loading
+                if (formFields.includes('image_file')) {
+                    form['image_file'] = null;
+                }
                 isSavedToLocalStorage.value = true;
             } catch (error) {
                 console.error('Error loading saved data:', error);
                 localStorage.removeItem(localStorageKey.value);
                 isSavedToLocalStorage.value = false;
             }
         }
-        isDataLoaded.value = true;
     };
 
     let saveTimeout;
@@ -76,7 +78,6 @@ export function useLocalStorageSaver(form, localStorageKeyId, formFields, keyPre
 
     return {
         isSavedToLocalStorage,
-        isDataLoaded,
         hasFormContent,
         clearLocalStorage
     };

resources/js/Composables/useLocalStorageSaver.js

@@ -6,7 +6,7 @@ import { object, string, array, number } from "yup";
 export const resourceMandatoryFields = object({
     name: string().required("Name is required").max(100, "Max 100 chars"),
     page_url: string()
-        .url("Must be a valid URL (Need to have https://)")
+        .url("Must be a valid URL")
         .required("URL is required"),
     platforms: array().of(string()).min(1, "At least one platform is required"),
     description: string().required("Description is required").max(10000),