nits

Author: AllanKoder

app/Http/Controllers/ResourceEditsController.php

@@ -44,6 +44,7 @@ public function store(ComputerScienceResource $computerScienceResource, StoreRes
 
         $actualChanges = $this->calculateChanges($computerScienceResource, $proposedChanges);
 
+        // Add image path to the actual changes
         if (array_key_exists('image_file', $proposedChanges)) {
             $actualChanges['image_path'] = null;
             if (isset($proposedChanges['image_file'])) {
@@ -135,6 +136,8 @@ public function merge(ResourceEditsService $editsService, ResourceEdits $resourc
                     $newFileName = Str::random(40).'.'.$fileExtension;
                     $destPath = 'resource/'.$newFileName;
 
+
+                    // TODO: FIGURE OUT WHAT TO DO IN CASE OF EXCEPTION IN CODE FROM LATER STEPS
                     Storage::disk('public')->move($sourcePath, $destPath);
                 }
 
@@ -145,11 +148,9 @@ public function merge(ResourceEditsService $editsService, ResourceEdits $resourc
             $resource->save();
 
             $proposedTagFields = ['topic_tags', 'programming_language_tags', 'general_tags'];
-            $allTags = [];
             foreach ($proposedTagFields as $field) {
                 if (array_key_exists($field, $changes)) {
                     $resource->$field = $changes[$field];
-                    $allTags[] = $changes[$field];
                 }
             }
 

app/Services/ComputerScienceResourceService.php

@@ -41,18 +41,8 @@ public function createResource(array $validatedData): ComputerScienceResource
             // Store the image onto storage
             $path = null;
             if (array_key_exists('image_file', $validatedData) && $imageFile = $validatedData['image_file']) {
+                // TODO: FIGURE OUT WHAT TO DO IN CASE OF EXCEPTION IN CODE FROM LATER STEPS
                 $path = $imageFile->store('resource', 'public');
-                if (! $path) {
-                    Log::error('Failed to store image file', [
-                        'user_id' => Auth::id(),
-                        'file_info' => $imageFile,
-                    ]);
-
-                    $fileName = $imageFile->getClientOriginalName();
-                    throw new \RuntimeException(
-                        "Could not save the image file '{$fileName}' for user ID ".Auth::id().'.'
-                    );
-                }
             }
 
             $resource = ComputerScienceResource::create([
@@ -94,18 +84,7 @@ public function createResource(array $validatedData): ComputerScienceResource
             return $resource;
         } catch (Throwable $e) {
             DB::rollBack();
-            // Attempt to remove the uploaded image if it was stored
-            if (isset($path) && $path) {
-                try {
-                    Storage::disk('public')->delete($path);
-                } catch (Throwable $removeEx) {
-                    Log::warning('Failed to remove image after exception', [
-                        'user_id' => Auth::id(),
-                        'image_path' => $path,
-                        'error' => $removeEx->getMessage(),
-                    ]);
-                }
-            }
+
             Log::critical('Failed to create resource', [
                 'error' => $e->getMessage(),
                 'trace' => $e->getTraceAsString(),

tests/Feature/ComputerScienceResourceTest.php

@@ -127,7 +127,7 @@ public function test_image_is_removed_if_resource_creation_fails()
         $response->assertStatus(422); // Validation error
 
         // The image should not exist in storage
-        Storage::disk('public')->assertMissing('resource/'.$formData['image_file']->hashName());
+        $this->assertEmpty(Storage::disk('public')->allFiles('resource'), "Failed asserting that no image files exist in the 'resource' directory after failed resource creation.");
     }
 
     public function test_model_removes_image_upon_deletion()