|
3 | 3 | #include <sstream> |
4 | 4 | #include <Storages/ExportReplicatedMergeTreePartitionTaskEntry.h> |
5 | 5 | #include <Storages/MergeTree/ExportPartitionUtils.h> |
| 6 | +#include <Storages/MergeTree/MergeTreePartitionExportTask.h> |
6 | 7 | #include <Common/tests/gtest_global_context.h> |
7 | 8 | #include <Core/Settings.h> |
8 | 9 | #include <Poco/JSON/Object.h> |
@@ -51,6 +52,29 @@ namespace |
51 | 52 | manifest.filename_pattern = "{part_name}"; |
52 | 53 | return manifest; |
53 | 54 | } |
| 55 | + |
| 56 | + MergeTreePartitionExportTask makeValidPlainTask() |
| 57 | + { |
| 58 | + MergeTreePartitionExportTask task; |
| 59 | + task.transaction_id = "tx1"; |
| 60 | + task.query_id = "query1"; |
| 61 | + task.partition_id = "2020"; |
| 62 | + task.source_database = "db1"; |
| 63 | + task.source_table = "source1"; |
| 64 | + task.destination_database = "db1"; |
| 65 | + task.destination_table = "table1"; |
| 66 | + task.create_time = 1000; |
| 67 | + task.parts.push_back({"part1", false, {}}); |
| 68 | + task.task_timeout_seconds = 60; |
| 69 | + task.max_threads = 1; |
| 70 | + task.parallel_formatting = true; |
| 71 | + task.parquet_parallel_encoding = true; |
| 72 | + task.max_bytes_per_file = 1000000; |
| 73 | + task.max_rows_per_file = 1000; |
| 74 | + task.file_already_exists_policy = MergeTreePartExportManifest::FileAlreadyExistsPolicy::error; |
| 75 | + task.filename_pattern = "{part_name}"; |
| 76 | + return task; |
| 77 | + } |
54 | 78 | } |
55 | 79 |
|
56 | 80 | class ExportPartitionOrderingTest : public ::testing::Test |
@@ -270,6 +294,47 @@ TEST_F(ExportPartitionManifestBackCompatTest, AggregateFunctionStateGatesApplied |
270 | 294 | } |
271 | 295 | } |
272 | 296 |
|
| 297 | +TEST_F(ExportPartitionManifestBackCompatTest, PlainTaskMissingAggregateFunctionStateGatesParseAsDisabled) |
| 298 | +{ |
| 299 | + auto task = makeValidPlainTask(); |
| 300 | + task.allow_aggregate_function_states_in_parquet = true; |
| 301 | + task.allow_aggregate_function_states_in_iceberg = true; |
| 302 | + |
| 303 | + Poco::JSON::Parser parser; |
| 304 | + auto json = parser.parse(task.toJsonString()).extract<Poco::JSON::Object::Ptr>(); |
| 305 | + json->remove("allow_aggregate_function_states_in_parquet"); |
| 306 | + json->remove("allow_aggregate_function_states_in_iceberg"); |
| 307 | + std::ostringstream oss; // STYLE_CHECK_ALLOW_STD_STRING_STREAM |
| 308 | + oss.exceptions(std::ios::failbit); |
| 309 | + Poco::JSON::Stringifier::stringify(json, oss); |
| 310 | + |
| 311 | + auto parsed = MergeTreePartitionExportTask::fromJsonString(oss.str()); |
| 312 | + EXPECT_FALSE(parsed.allow_aggregate_function_states_in_parquet); |
| 313 | + EXPECT_FALSE(parsed.allow_aggregate_function_states_in_iceberg); |
| 314 | +} |
| 315 | + |
| 316 | +TEST_F(ExportPartitionManifestBackCompatTest, PlainTaskAggregateFunctionStateGatesAppliedToWorkerContextForEveryValue) |
| 317 | +{ |
| 318 | + for (const bool value : {false, true}) |
| 319 | + { |
| 320 | + auto task = makeValidPlainTask(); |
| 321 | + task.allow_aggregate_function_states_in_parquet = value; |
| 322 | + task.allow_aggregate_function_states_in_iceberg = value; |
| 323 | + |
| 324 | + auto parsed = MergeTreePartitionExportTask::fromJsonString(task.toJsonString()); |
| 325 | + auto worker_context = ExportPartitionUtils::getContextCopyWithTaskSettings(getContext().context, parsed); |
| 326 | + |
| 327 | + EXPECT_EQ(parsed.allow_aggregate_function_states_in_parquet, value) << "value=" << value; |
| 328 | + EXPECT_EQ(parsed.allow_aggregate_function_states_in_iceberg, value) << "value=" << value; |
| 329 | + EXPECT_EQ( |
| 330 | + worker_context->getSettingsRef()[Setting::allow_experimental_aggregate_function_states_in_parquet].value, |
| 331 | + value) << "value=" << value; |
| 332 | + EXPECT_EQ( |
| 333 | + worker_context->getSettingsRef()[Setting::allow_experimental_aggregate_function_states_in_iceberg].value, |
| 334 | + value) << "value=" << value; |
| 335 | + } |
| 336 | +} |
| 337 | + |
273 | 338 | TEST(ExportPartitionRetryClassification, MissingPartIsFatalOnlyOnPlainPath) |
274 | 339 | { |
275 | 340 | EXPECT_FALSE(ExportPartitionUtils::isNonRetryableExportError(ErrorCodes::NO_SUCH_DATA_PART)); |
|
0 commit comments