From c2e34e1397b6c2c38de8ced169bfd38e5613c1fb Mon Sep 17 00:00:00 2001 From: Yohaan Narayanan <229655281+yohaann196@users.noreply.github.com> Date: Sun, 5 Apr 2026 09:59:29 -0700 Subject: [PATCH 1/5] Fix datatype validation and update assertions --- OpenBench/workloads/verify_workload.py | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/OpenBench/workloads/verify_workload.py b/OpenBench/workloads/verify_workload.py index dab4ee3af..4622ad6a5 100644 --- a/OpenBench/workloads/verify_workload.py +++ b/OpenBench/workloads/verify_workload.py @@ -313,7 +313,7 @@ def verify_spsa_inputs(errors, request, field): name, data_type, value, minimum, maximum, c, r = line.split(',') if data_type.strip() not in [ 'int', 'float' ]: - errors.append('Datatype must be int for float, for %s' % (name)) + errors.append('Datatype must be int or float, for %s' % (name)) if float(minimum) > float(maximum): errors.append('Max does not exceed Min, for %s' % (name)) @@ -324,6 +324,9 @@ def verify_spsa_inputs(errors, request, field): if data_type.strip() == 'float' and float(c) <= 0.00: errors.append('C for floats must be > 0.00, for %s' % (name)) + if data_type.strip() == 'int' and float(c) < 0.50: + errors.append('C for ints must be >= 0.50, for %s' % (name)) + if float(r) <= 0.00: errors.append('R must be > 0.00, for %s' % (name)) @@ -494,11 +497,4 @@ def fetch_artifact_url(base, engine, headers, sha): # All jobs finished, with at least one non-expired Artifact assert not any(job['conclusion'] != 'success' for job in jobs) assert not any(artifact['expired'] for artifact in artifacts) - assert len(artifacts) >= len(jobs) - - # Only set the url if we have everything we need - return (url, True) - - except Exception as error: - # If anything goes wrong, retry later with the same base URL - return (base, False) \ No newline at end of file + assert len(artifacts) >= len From b38d72c13a5d8a37de225b04e0a8226f64986dee Mon Sep 17 00:00:00 2001 From: Yohaan Narayanan <229655281+yohaann196@users.noreply.github.com> Date: Sun, 5 Apr 2026 10:44:28 -0700 Subject: [PATCH 2/5] Update OpenBench/workloads/verify_workload.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- OpenBench/workloads/verify_workload.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/OpenBench/workloads/verify_workload.py b/OpenBench/workloads/verify_workload.py index 4622ad6a5..34e0768f5 100644 --- a/OpenBench/workloads/verify_workload.py +++ b/OpenBench/workloads/verify_workload.py @@ -497,4 +497,9 @@ def fetch_artifact_url(base, engine, headers, sha): # All jobs finished, with at least one non-expired Artifact assert not any(job['conclusion'] != 'success' for job in jobs) assert not any(artifact['expired'] for artifact in artifacts) - assert len(artifacts) >= len + assert len(artifacts) >= len(jobs) + + return artifacts[0]['archive_download_url'], True + + except: + return base, False From 1a5c94d440bc067af92c6c1ff0470669ae1090e6 Mon Sep 17 00:00:00 2001 From: Yohaan Narayanan <229655281+yohaann196@users.noreply.github.com> Date: Sun, 5 Apr 2026 10:54:37 -0700 Subject: [PATCH 3/5] Update OpenBench/workloads/verify_workload.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- OpenBench/workloads/verify_workload.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/OpenBench/workloads/verify_workload.py b/OpenBench/workloads/verify_workload.py index 34e0768f5..7f233e125 100644 --- a/OpenBench/workloads/verify_workload.py +++ b/OpenBench/workloads/verify_workload.py @@ -499,7 +499,9 @@ def fetch_artifact_url(base, engine, headers, sha): assert not any(artifact['expired'] for artifact in artifacts) assert len(artifacts) >= len(jobs) - return artifacts[0]['archive_download_url'], True + # Return the artifacts listing URL so downstream availability checks + # continue to recognize private-engine artifacts as ready. + return url, True except: return base, False From a8906d7d47565d3cbaf8f79456dc12cfa6de7847 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 5 Apr 2026 17:55:24 +0000 Subject: [PATCH 4/5] Replace bare except with except Exception in fetch_artifact_url Agent-Logs-Url: https://github.com/yohaann196/OpenBench/sessions/33a68a30-9a82-4a73-8d8d-a08c562c7bc8 Co-authored-by: yohaann196 <229655281+yohaann196@users.noreply.github.com> --- OpenBench/workloads/verify_workload.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OpenBench/workloads/verify_workload.py b/OpenBench/workloads/verify_workload.py index 7f233e125..8d6e163e4 100644 --- a/OpenBench/workloads/verify_workload.py +++ b/OpenBench/workloads/verify_workload.py @@ -503,5 +503,5 @@ def fetch_artifact_url(base, engine, headers, sha): # continue to recognize private-engine artifacts as ready. return url, True - except: + except Exception: return base, False From 00d0d3746951e55665cd4a97bea2d7182630fe1f Mon Sep 17 00:00:00 2001 From: Yohaan Narayanan <229655281+yohaann196@users.noreply.github.com> Date: Sun, 5 Apr 2026 11:09:25 -0700 Subject: [PATCH 5/5] Update verify_workload.py --- OpenBench/workloads/verify_workload.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/OpenBench/workloads/verify_workload.py b/OpenBench/workloads/verify_workload.py index 8d6e163e4..babc31f1d 100644 --- a/OpenBench/workloads/verify_workload.py +++ b/OpenBench/workloads/verify_workload.py @@ -499,9 +499,9 @@ def fetch_artifact_url(base, engine, headers, sha): assert not any(artifact['expired'] for artifact in artifacts) assert len(artifacts) >= len(jobs) - # Return the artifacts listing URL so downstream availability checks - # continue to recognize private-engine artifacts as ready. - return url, True + # Only set the url if we have everything we need + return (url, True) - except Exception: - return base, False + except Exception as error: + # If anything goes wrong, retry later with the same base URL + return (base, False)