Fix TRL GRPO implementation to comply with current TRL API (≥0.29)#2
Draft
Copilot wants to merge 2 commits into
Draft
Fix TRL GRPO implementation to comply with current TRL API (≥0.29)#2Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: Antix5 <96021131+Antix5@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TRL implementation compliance with documentation
Fix TRL GRPO implementation to comply with current TRL API (≥0.29)
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several breaking incompatibilities between the GRPO training code and the current TRL library API caused silent failures (wrong dtype, wrong reward signature) or hard crashes (unknown config params).
train_grpo.pycompletionschanged fromlist[list[str]]tolist[str]— TRL decodes completions to plain strings before passing them; removed the now-dead normalization looptarget_bufferkwarg: TRL forwards extra dataset columns as**kwargs, not positional args — updated bothenv_reward_functionandreward_wrapperaccordinglyvllm_device: parameter no longer exists inGRPOConfig; replaced withvllm_mode="colocate"to preserve in-process single-GPU vLLM behaviour (default changed to"server"in current TRL)max_prompt_length: parameter no longer exists inGRPOConfigtrain.py/agent.pydtype=→torch_dtype=:AutoModelForCausalLM.from_pretrainedusestorch_dtype; the incorrect kwarg silently loaded the model in float32 instead of bfloat16Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
huggingface.co/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.