Skip to content

Missing Alembic migration for webhook signature versioning #242

Description

@usmanimamu17-create

Labels / Complexity: database, schema · Trivial — 2 pts

Summary

The alembic/versions/0016_webhook_signature_versioning.py migration adds a signature_version column to webhook_deliveries, but the migration may have been applied inconsistently across environments. The WebhookDelivery model in app/models/webhook.py expects this column, but there is no CI check to verify migration consistency.

Proposal

  • Verify the migration is present in alembic/versions/
  • Add a CI step that runs alembic check to detect migration drift
  • Ensure the migration is idempotent (safe to re-run)

Acceptance criteria

  • alembic check passes in CI
  • The signature_version column exists in production schema
  • A test verifies the model matches the migration

Out of scope

Data backfill for existing records; assume signature_version defaults to 1.

Getting started

Files in scope:

  • alembic/versions/0016_webhook_signature_versioning.py
  • app/models/webhook.py

Build/test commands:

alembic check
pytest tests/test_migration_verification.py

Good first files to read: alembic/versions/0016_webhook_signature_versioning.py.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third Campaignarea/databaseSchema design, indexes, migrations, SQLAlchemy usage, retention

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions