Game version not detected properly after locate game option was used

[p0358]

Did a quick test with locating existing Titanfall installation and it showed this warning (with current version being Unknown):

However, the file at __Installer/installerdata.xml does actually exist and the code suggests it should be working, to pick up the current version from there.

I attach the file here in case the contents matter:
installerdata.xml

[p0358]

Also it seems to have forgotten the game install dir after app restart, even though it did remember its launch options and alternate EXE location and disabled cloud save checkbox.

[p0358]

Even more interestingly, for Peggle, it says <game gameVersion="1.04.0.0" manifestVersion="3.0"> in the XML, but Maxima claims Installed: Unknown, Latest: 5, even though for Titanfall the latest versions do match up with XML...

[p0358]

I did some debugging. The version can be read from the manifest file properly. But after locating the game, it doesn't seem like games list is re-populated, because installed_version() is not called again.

And restarting Maxima won't help either, since it doesn't remember installed games currently on Linux.

So it seems the primary problem is not recognizing pre-DiP games as installed, secondary that after locating the game installation or downloading it, the game's object in UI might be not getting refreshed.

[p0358]

It seems post-DiP games create registry key like HKEY_LOCAL_MACHINE\SOFTWARE\EA Games\Mirrors Edge Catalyst\Install Dir, but for older games it'd be in places like (instead of under EA Games):

• HKEY_LOCAL_MACHINE\SOFTWARE\Respawn\Titanfall\Install Dir
• HKEY_LOCAL_MACHINE\SOFTWARE\Westwood Studios\NOX\Install Dir
• HKEY_LOCAL_MACHINE\SOFTWARE\PopCap Games\Peggle\Install Dir
• HKEY_LOCAL_MACHINE\SOFTWARE\Maxis\SimCity\Install Dir
• HKEY_LOCAL_MACHINE\SOFTWARE\Image & Form\SteamWorld Dig\Install Dir
• HKEY_LOCAL_MACHINE\SOFTWARE\Microids\Syberia II\Install Dir
• HKEY_LOCAL_MACHINE\SOFTWARE\Sims\The Sims 3\Install Dir

And the direct cause of the games being not recognized as installed is that those registry keys aren't being created in the prefix. Not sure if it can be nicely/properly fixed without #44. Possibly game locating should create appropriate registry keys?

But this also makes that part of code invalid on Windows:

#[cfg(windows)]
pub fn read_game_path(name: &str) -> Result<PathBuf, RegistryError> {
    let hklm = RegKey::predef(HKEY_LOCAL_MACHINE);

    dbg!(name);

    let mut key = hklm.open_subkey(format!("SOFTWARE\\EA Games\\{}", name));
    if key.is_err() {
        key = hklm.open_subkey(format!("SOFTWARE\\WOW6432Node\\EA Games\\{}", name));
    }

    let key = match key {
        Ok(key) => key,
        Err(_) => return Err(RegistryError::Key(format!("SOFTWARE\\EA Games\\{}", name))),
    };

    let path: String = key.get_value("Install Dir")?;
    Ok(PathBuf::from(path))
}

---

I tried, for a test, hardcoding is_install() and install_check_path() and that got me somewhat further, until this:

INFO - [maxima::bridge::get_games] - processing titanfall
WARN - [maxima::core::manifest] - Loading DiP manifest from "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Respawn\\Titanfall\\Install Dir]TitanFall.exe/__Installer/installerdata.xml"

It seems like further digging here is pointless until some more normal game dir saving method is done with #44. I hope that [HKEY_LOCAL_MACHINE\SOFTWARE\Respawn\Titanfall\Install Dir]TitanFall.exe not having a backslash between ] and executable name like some games is not something causing this in any case (it's like 50:50 amongst games whether they have a backslash there or not...).

[wannkunstbeikor]

And the direct cause of the games being not recognized as installed is that those registry keys aren't being created in the prefix

Have you tried using the CLI, I never encountered an issue like this, might be a regression, its been some time since I last used maxima.

The touchup.exe should get executed by maxima in the wine prefix and then those reg keys are added (the same way ea desktop does it on windows), the function read_game_path is not used by maxima, it parses the install path from the registry. This worked also when their key was not in EA Games, e.g. Dragon Age Inquisition

[wannkunstbeikor]

Just tried again and it works for me (I deleted the prefix and relocated both dead space and dai)

[p0358]

The CLI also doesn't recognize them as installed either (since no registry keys), and not sure if it can locate existing game install (since the text made it seem that only fresh installation is an option); though I might re-try actual installation with some tiny game with CLI if so too.

The touchup.exe should get executed by maxima in the wine prefix and then those reg keys are added

Well, so Touchup surely is executed, since for Titanfall that starts up audio_installer.exe for a second which creates a visible window, so it's easy to tell, and yet for Titanfall and Peggle the keys were not created, they were for Mirror's Edge Catalyst though.

I might test up more games, but PreDiP vs DiP is the biggest apparent difference that I can see between the two...

So far it was:

• Titanfall, PreDiP, located existing install → no key
• Peggle, PreDiP, installed with Maxima → no key
• Mirror's Edge Catalyst, DiP, installed with Maxima → key exists

I did notice that for Titanfall the Touchup created some unrelated keys like below, but not Install Dir among them (nothing else comes up when searching system.reg for Titanfall):

[Software\\Respawn\\Titanfall] 1769221739
#time=1dc8cd9322bcdfe
"GDFBinary"="Z:\\home\\p0358\\Games\\Titanfall\\GDFBinary_en_US_64.dll"

[Software\\Wow6432Node\\Respawn\\Titanfall] 1769221739
#time=1dc8cd9322bcba6
"GDFBinary64"="Z:\\home\\p0358\\Games\\Titanfall\\GDFBinary_en_US_64.dll"

[Software\\Wow6432Node\\Respawn\\Titanfall\\InstallOptSelect] 1769221736
#time=1dc8cd930b68a54
@="1"

Which also this whole GDFBinary makes me think... since I always used Origin or EA App in Polish on Windows, it'd always create GDFBinary_pl_PL_64.dll rather than GDFBinary_en_US_64.dll (the latter is missing). Not sure if this has anything to do with it, or just an unrelated quirk (the dll itself is never used or checked by the game, I never knew why EA was placing those, especially that they actually install the files for all languages in Titanfall anyway).

Just tried again and it works for me (I deleted the prefix and relocated both dead space and dai)

Hmm, that's interesting, GDFBinary also smells like it might be PreDiP too. And you did just use the locate install option rather than full reinstall?

Also, I just realized now, that even though Mirror's Edge Catalyst is detected as installed, it doesn't read the installed version from its manifest either 😭 (so exhibits the original issue, despite the game install being located at Maxima launch). This would actually confirm my suspicion that something was wrong there with the code trying to produce the path to the XML where it fails to obtain the version...

So for Mirror's Edge Catalyst, since I added some logs before, I can see it tries to read [...]/EA/mirrors-edge-catalyst/MirrorsEdgeCatalyst.exe/__Installer/installerdata.xml. (I've cut off the beginning of the path) (notice how it keeps MirrorsEdgeCatalyst.exe)

So it seems like these are somewhat separate issues, but kinda combined since both seem to based on that install_check_override property.

Do you have any of these games in your library, so that we could compare their behavior in testing?

(btw in my case the Mirror's Edges are from Steam actually, though Maxima doesn't show that)

[wannkunstbeikor]

I have mec and that worked fine for me as well, its late so I will test it again tomorrow.

To locate a game simply do maxima-cli locate-game <path to dir>

[wannkunstbeikor]

btw can u give some more info on ur system and if u build it from source or used the gh action artifacts?

[p0358]

I have mec and that worked fine for me as well

Yeah I mean for that one it locates the installed game properly for a change, but the UI asks for update from Unknown version when trying to launch, can you try this one with UI maybe?

To locate a game simply do maxima-cli locate-game <path to dir>

Okay, I'll be trying that then (but also not today since also late)

btw can u give some more info on ur system and if u build it from source or used the gh action artifacts?

It's just CachyOS with KDE, I've cloned the repo, did rustup override set nightly and then cargo build and launched it with target/debug/maxima. It seems that as far as downloading Proton, umu, etc. to their paths, it's more-less working as expected, except the actual game launching hardly works for some reason, but that's yet another issue where I'm yet to try with CLI since it doesn't see most of my installed games yet xD

I think how it reads Mirror's Edge Catalyst manifest currently might be actually some side effect of my local changes that I was trying out to fix Titanfall, I'll have to discard those and re-try.

[wannkunstbeikor]

can you try this one with UI maybe

I have tried it and it also showed me the version error, but I could still launch it and after restarting the UI, it didnt show the warning anymore and everything works fine

[wannkunstbeikor]

Do you have any of these games in your library, so that we could compare their behavior in testing?

I also just saw that I have sims 4 and apex as well, but not installed. Are those PreDip games?

[imLinguin]

I believe these are Dip