Skip to content

No test coverage for indexer, registry, safetynet, or KYC modules #9

Description

@pitah23

Problem

npm test only runs test/scoring.test.ts, test/shared.test.ts, test/wasm-runtime.test.ts, and test/behavioral.test.ts; test/api.integration.test.ts covers the HTTP layer. Nothing under src/indexer/, src/registry/ (reports.ts, review.ts, propagation.ts), src/safetynet/ (claims.ts, tracing.ts, exchange-alerts.ts, oracle.ts), src/verification/kyc/, or src/verification/reserves/ has direct unit tests. That includes the two-person confirmation rule (registry/review.ts) and the claims state machine (safetynet/claims.ts) — both security/financially sensitive logic.

Location

test/ directory vs. src/ module layout

Suggested fix

Prioritize unit tests for registry/review.ts (two-person rule edge cases: self-endorse, self-confirm, same-analyst endorse+confirm, invalid state transitions) and safetynet/claims.ts (state machine transitions) first, since those guard the most consequential logic errors.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions