Skip to content

In the VWAP Indicator,is there a typo here? #94

@kingdream123

Description

@kingdream123

In the VWAP.cs class, the following line

(prevEndTime.TimeOfDay > prevEndTime.TimeOfDay && _customSessionStart <= startTime.TimeOfDay)

The code prevEndTime.TimeOfDay > prevEndTime.TimeOfDay is always false.

var newSessionBetweenBars = previousBar != null && (
	sessionCrossesMidnight
		? (prevEndTime.TimeOfDay <= _customSessionStart && startTime.TimeOfDay > _customSessionStart) ||
		(prevEndTime.TimeOfDay > prevEndTime.TimeOfDay && _customSessionStart <= startTime.TimeOfDay)
		: prevEndTime.TimeOfDay <= _customSessionStart && startTime.TimeOfDay > _customSessionStart
);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions