From dafd17f887e1b57a8e23f0ba46aa7d6d0b3db0c8 Mon Sep 17 00:00:00 2001 From: "Lingling Ye (from Dev Box)" Date: Fri, 6 Jun 2025 14:23:20 +0800 Subject: [PATCH 1/3] callback nil check --- azureappconfiguration/azureappconfiguration.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/azureappconfiguration/azureappconfiguration.go b/azureappconfiguration/azureappconfiguration.go index 387366d..e0abbc6 100644 --- a/azureappconfiguration/azureappconfiguration.go +++ b/azureappconfiguration/azureappconfiguration.go @@ -258,6 +258,11 @@ func (azappcfg *AzureAppConfiguration) Refresh(ctx context.Context) error { // Parameters: // - callback: A function with no parameters that will be called after a successful refresh func (azappcfg *AzureAppConfiguration) OnRefreshSuccess(callback func()) { + if callback == nil { + log.Println("callback cannot be nil") + return + } + azappcfg.onRefreshSuccess = append(azappcfg.onRefreshSuccess, callback) } From 2135141d212faa690ccf64cedd022a04ab3dfedd Mon Sep 17 00:00:00 2001 From: "Lingling Ye (from Dev Box)" Date: Fri, 6 Jun 2025 15:55:00 +0800 Subject: [PATCH 2/3] update --- azureappconfiguration/azureappconfiguration.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/azureappconfiguration/azureappconfiguration.go b/azureappconfiguration/azureappconfiguration.go index e0abbc6..30b92ee 100644 --- a/azureappconfiguration/azureappconfiguration.go +++ b/azureappconfiguration/azureappconfiguration.go @@ -239,9 +239,7 @@ func (azappcfg *AzureAppConfiguration) Refresh(ctx context.Context) error { // Only execute callbacks if actual changes were applied if keyValueRefreshed || secretRefreshed { for _, callback := range azappcfg.onRefreshSuccess { - if callback != nil { - callback() - } + callback() } } @@ -259,7 +257,6 @@ func (azappcfg *AzureAppConfiguration) Refresh(ctx context.Context) error { // - callback: A function with no parameters that will be called after a successful refresh func (azappcfg *AzureAppConfiguration) OnRefreshSuccess(callback func()) { if callback == nil { - log.Println("callback cannot be nil") return } From fa7bf4782478601b90e2bd273b26af00cdf6eb2d Mon Sep 17 00:00:00 2001 From: "Lingling Ye (from Dev Box)" Date: Fri, 6 Jun 2025 16:03:00 +0800 Subject: [PATCH 3/3] nil check --- azureappconfiguration/azureappconfiguration.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/azureappconfiguration/azureappconfiguration.go b/azureappconfiguration/azureappconfiguration.go index 30b92ee..98ed36e 100644 --- a/azureappconfiguration/azureappconfiguration.go +++ b/azureappconfiguration/azureappconfiguration.go @@ -239,7 +239,9 @@ func (azappcfg *AzureAppConfiguration) Refresh(ctx context.Context) error { // Only execute callbacks if actual changes were applied if keyValueRefreshed || secretRefreshed { for _, callback := range azappcfg.onRefreshSuccess { - callback() + if callback != nil { + callback() + } } }