Merge branch 'main' of https://github.com/erinborders/azure-cli-extensions into erinborders/nodedisruptionprofile

Author: erinborders

.github/workflows/AddPRComment.yml

@@ -1,5 +1,5 @@
 on:
-  pull_request_target:
+  pull_request:
     types: [opened]
     branches:
       - main

.github/workflows/AzdevLinter.yml

@@ -2,7 +2,7 @@ name: GH Azdev Linter
 
 on:
   workflow_dispatch:
-  pull_request_target:
+  pull_request:
       types: [opened, labeled, unlabeled, synchronize]
       branches:
         - main

.github/workflows/AzdevStyle.yml

@@ -2,7 +2,7 @@ name: GH Azdev Style
 
 on:
   workflow_dispatch:
-  pull_request_target:
+  pull_request:
       types: [opened, labeled, unlabeled, synchronize]
       branches:
         - main

.github/workflows/BlockPRMerge.yml

@@ -1,14 +1,17 @@
 name: Block PR merging on blocked labels
 
 on:
-  pull_request_target:
+  pull_request:
     types: [opened, labeled, unlabeled, synchronize]
     branches:
       - main
 
+permissions: {}
+
 jobs:
   block-merge:
     runs-on: ubuntu-latest
+    permissions: {}
     steps:
       - name: Check blocked labels
         uses: actions/github-script@v7

.github/workflows/CCOA.yml

@@ -1,19 +1,21 @@
 name: CCOA
 
 on:
-  pull_request_target:
+  pull_request:
     types:
       - opened
       - reopened
     branches:
       - main
 
-permissions:
-  pull-requests: write
+permissions: {}
 
 jobs:
   add_label_and_comment:
     runs-on: ubuntu-latest
+    permissions:
+      pull-requests: write
+      issues: write
 
     steps:
       - name: Check current date securely

.github/workflows/GitHookNotice.yml

@@ -1,6 +1,6 @@
 name: Git Hook Notice
 on:
-  pull_request_target:
+  pull_request:
     types: [opened]
     branches:
       - main
@@ -11,18 +11,16 @@ jobs:
   git-hook-notice:
     runs-on: ubuntu-latest
     permissions:
-      pull-requests: write
+      contents: read
     name: Introduce git hook in developer env
     steps:
       - name: Checkout git hook notice message
         uses: actions/checkout@v4
         with:
           sparse-checkout: |
             .github/template/git-hooks-note.md
-      - name: Comment on pull request
-        uses: mshick/add-pr-comment@v2
-        with:
-           repo-token: ${{ secrets.GITHUB_TOKEN }}
-           message-id: gitHookNoticeComment
-           message-path: |
-            .github/template/git-hooks-note.md 
+      - name: Show git hook notice
+        run: |
+          echo "::group::Git hook notice"
+          cat .github/template/git-hooks-note.md
+          echo "::endgroup::"

.github/workflows/VersionCalPRComment.yml

@@ -2,7 +2,7 @@ name: Release Version Calculation
 
 on:
   workflow_dispatch:
-  pull_request_target:
+  pull_request:
       types: [opened, labeled, unlabeled, synchronize]
       branches:
         - main
@@ -228,16 +228,16 @@ jobs:
         uses: andstor/file-existence-action@v3
         with:
           files: "./version_update.txt"
-      - name: Comment on the pull request
+      - name: Show version update notice
         if: steps.check_comment_file.outputs.files_exists == 'true'
-        uses: mshick/add-pr-comment@v2
-        with:
-          repo-token: ${{ secrets.GITHUB_TOKEN }}
-          message-id: versioncommentbot
-          message-path: |
-            version_update.txt
-          message-failure: |
-            Please refer to [Extension version schema](https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md) to update release versions.
+        run: |
+          echo "::group::Version update notice"
+          cat ./version_update.txt
+          echo "::endgroup::"
+      - name: Show version update fallback notice
+        if: steps.check_comment_file.outputs.files_exists != 'true'
+        run: |
+          echo "Please refer to [Extension version schema](https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md) to update release versions."
       - name: Check add label file existence
         id: check_add_label_file
         uses: andstor/file-existence-action@v3

linter_exclusions.yml

@@ -37,6 +37,9 @@ aks create:
     node_public_ip_prefix_id:
       rule_exclusions:
         - option_length_too_long
+    node_public_ip_prefix_ids:
+      rule_exclusions:
+        - option_length_too_long
     enable_private_cluster:
       rule_exclusions:
       - option_length_too_long
@@ -130,6 +133,11 @@ aks create:
     service_account_image_pull_default_managed_identity_id:
       rule_exclusions:
       - option_length_too_long
+aks nodepool add:
+  parameters:
+    node_public_ip_prefix_ids:
+      rule_exclusions:
+        - option_length_too_long
 aks update:
   parameters:
     aad_admin_group_object_ids:

scripts/ci/validate_external_source_urls.py

@@ -122,7 +122,7 @@ def _run_diff(src: str, tgt: str, cached: bool = False) -> str:
     if cached:
         cmd.append("--cached")
     else:
-        cmd.append(f"{tgt}...{src}")
+        cmd.append(f"{tgt}..{src}")
 
     proc = subprocess.run(
         cmd,

src/aks-preview/HISTORY.rst

@@ -11,9 +11,16 @@ To release a new version, please select a new version number (usually plus 1 to
 
 Pending
 +++++++
-* `az aks create` and `az aks nodepool add`: Add `--enable-osdisk-full-caching` (preview) to enable the full-cache ephemeral OS disk feature for a node pool. Requires AFEC registration `Microsoft.ContainerService/FullCachePreview`. Property is immutable after node pool creation.
 * `az aks update`: Add `--node-disruption-policy` (preview) to update the node disruption policy for a cluster. Requires AFEC registration `Microsoft.ContainerService/NodeDisruptionProfile`. This is a cluster-level property that applies to all node pools in the cluster.
 
+21.0.0b2
+++++++++
+* `az aks create`: Add `--node-public-ip-prefix-ids` parameter for specifying dual-stack (IPv4/IPv6) public IP prefixes for instance-level public IPs.
+* `az aks nodepool add`: Add `--node-public-ip-prefix-ids` parameter for specifying dual-stack (IPv4/IPv6) public IP prefixes for instance-level public IPs.
+* `az aks create` and `az aks nodepool add`: Add `--enable-osdisk-full-caching` (preview) to enable the full-cache ephemeral OS disk feature for a node pool. Requires AFEC registration `Microsoft.ContainerService/FullCachePreview`. Property is immutable after node pool creation.
+* Clean up unused disk driver version constants and remove obsolete CSI driver v2 tests following the removal of `--disk-driver-version` in 21.0.0b1.
+* `az aks create/update`: Add `--enable-fips` (preview) to enable FIPS mode at the cluster level and `az aks update --disable-fips` to disable it. Requires Kubernetes version 1.34 or later and AFEC registration `Microsoft.ContainerService/EnableFIPSPreview`.
+
 21.0.0b1
 ++++++
 * [BREAKING CHANGE] `az aks create/update`: Remove `--disk-driver-version` option as the `version` field has been removed from the API spec for `ManagedClusterStorageProfileDiskCSIDriver`.