Skip to content

Commit 58bd080

Browse files
authored
Address code review: extract properties variable and fix chained .get() at line 997
1 parent 539d8a7 commit 58bd080

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

  • src/load/azext_load/data_plane/utils

src/load/azext_load/data_plane/utils/utils.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -850,8 +850,9 @@ def upload_generic_files_helper(
850850
def upload_properties_file_helper(
851851
client, test_id, yaml_data, load_test_config_file, existing_test_files, wait
852852
):
853-
if yaml_data and (yaml_data.get("properties") or {}).get("userPropertyFile") is not None:
854-
user_prop_file = (yaml_data.get("properties") or {}).get("userPropertyFile")
853+
properties = yaml_data.get("properties") if yaml_data else None
854+
if properties and properties.get("userPropertyFile") is not None:
855+
user_prop_file = properties.get("userPropertyFile")
855856
existing_properties_files = []
856857
for file in existing_test_files:
857858
if AllowedFileTypes.USER_PROPERTIES.value == file["fileType"]:
@@ -994,7 +995,7 @@ def validate_engine_data_with_regionwiseload_data(engine_instances, regionwise_e
994995

995996

996997
def _get_metrics_from_sampler(test_run, sampler_name, metric_name):
997-
return (test_run.get("testRunStatistics") or {}).get(sampler_name, {}).get(metric_name)
998+
return ((test_run.get("testRunStatistics") or {}).get(sampler_name) or {}).get(metric_name)
998999

9991000

10001001
def generate_trends_row(test_run, response_time_aggregate=None):

0 commit comments

Comments
 (0)