chore: drop Sponge7 support, bump to Java 17, extend CI to release/v7 (#40)

Realigns this repo with **BanManager v8.0.0-SNAPSHOT** on `master` after BanManager dropped its legacy Sponge API 7 (MC 1.12.2 / Java 8) module, then carries the WebEnhancer pin feature forward onto v8's MiniMessage-based message pipeline so the full E2E matrix passes against v8.

### Drop Sponge7 (mirrors BanManager v8)

- Remove `sponge-api7/` source module (build script, `SpongePlugin`, `SpongeCommand`, `SpongeMetrics`, `LogServerAppender`, `ReportListener`, bundled assets symlink).
- Remove `e2e/platforms/sponge7/` Docker compose + bundled configs.
- Drop `:BanManagerWebEnhancerSponge7` from `settings.gradle.kts`.
- Strip Sponge7 jar copy / test / debug tasks from `e2e/build.gradle.kts` and remove `"sponge7"` from the e2e `clean` platform list.
- Remove the `Sponge7-1.12.2` entry from the e2e workflow matrix.

### Bump baseline to Java 17

- `buildSrc/src/main/kotlin/CommonConfig.kt`: source/target compatibility 1.8 → 17 for non-Fabric modules.
- Sponge module already overrides to Java 21; Fabric uses its own toolchain; CI already provisions JDK 21 as default.

### Extend CI to `release/v7`

- `.github/workflows/build.yml` and `.github/workflows/e2e.yml` now trigger on push to `release/v7` (in addition to `master` / PRs / scheduled / dispatch).

### Migrate pin feature to BanManager v8 placeholder syntax

BanManager v8 rejects legacy `&`-code messages outright and uses MiniMessage `<token>` placeholders instead of `[token]`. Updates required so the WebEnhancer pin survives v8:

- `CommonPlayerDeniedListener.handlePin` now inspects `Message.getRawTemplate()` and looks for `<pin>` (not `[pin]` via `toString()`); skips early when the template is missing or doesn't contain the placeholder. Mirror the change in `CommonPlayerDeniedListenerTest` (mocks `getRawTemplate()`, adds null-template case).
- Rewrite the bundled `common/src/main/resources/messages.yml` (the WebEnhancer defaults) to MiniMessage with `<pin>`, `<expires>`, `<seconds>`.
- Rewrite every `e2e/platforms/*/configs/banmanager-webenhancer/messages.yml` fixture to match.
- Replace each `e2e/platforms/*/configs/banmanager/messages.yml` fixture with a minimal MiniMessage override – only the `ban` / `tempban` / `banip` / `tempbanip` `disallowed` + `kick` templates carry `<pin>`; everything else falls through to BanManager v8's bundled defaults so the override stays small.

### Fix nested kick-reason extraction in E2E helpers

MiniMessage renders nested-color templates (`<gold>A<dark_red>B<gold>C`) as nested chat components, and Paper 1.20.3+ / newer Fabric versions deliver disconnects as NBT compounds. The previous `extractNbtText` only walked top-level `extra[*].text`, which truncated the kick reason at the first nested segment and hid the `. Your appeal pin is <pin>` tail. Result: every Online Kick Pin Placeholder test failed except Fabric-1.20.1 (still on JSON disconnects).

- `extractNbtText` now recurses into each `extra[*]` list item.
- New `extractJsonText` helper applies the same recursion to JSON chat components, replacing the shallow `extra.map(e => e.text)` that had the same bug for nested JSON payloads (Velocity / Sponge login-denial kicks).

### CI

All 12 required checks green: Java 21 - mariadb, Java 21 - h2, plus E2E for Bukkit, Fabric-1.20.1 / 1.21.1 / 1.21.4 / 1.21.11, Sponge-1.20.6 / 1.21.1 / 1.21.3, Velocity, BungeeCord.

### Notes

- Replaces the closed PR #39 (CI-only); both fixes consolidated here so master goes green in one merge.
- WebEnhancer `release/v7` already shipped `v7.11.0` with Sponge7 support; this PR only changes `master`.

Author: confuser

.github/workflows/build.yml

@@ -5,6 +5,7 @@ on:
   push:
     branches:
       - master
+      - release/v7
   schedule:
     - cron: "0 0 * * 0"
 

.github/workflows/e2e.yml

@@ -8,6 +8,7 @@ on:
   push:
     branches:
       - master
+      - release/v7
   workflow_dispatch:
 
 jobs:
@@ -79,13 +80,6 @@ jobs:
             mc_version: "1.21.3"
             java_image: "java21"
             spongeversion: "1.21.3-13.0.0"
-          # Sponge API 7 (Legacy - MC 1.12.2, Java 8)
-          - platform: Sponge7-1.12.2
-            task: testSponge7
-            build_task: ":BanManagerSponge7:shadowJar"
-            compose_dir: platforms/sponge7
-            mc_version: "1.12.2"
-            java_image: "java8"
           # Velocity Proxy
           - platform: Velocity
             task: testVelocity

buildSrc/src/main/kotlin/CommonConfig.kt

@@ -30,12 +30,12 @@ fun Project.applyCommonConfiguration() {
         }
     }
 
-    // Only set Java 1.8 for non-Fabric modules
+    // Set Java 17 for non-Fabric modules (aligns with BanManager v8 baseline)
     // Fabric uses toolchain configuration in its build.gradle.kts
     plugins.withId("java") {
         if (!plugins.hasPlugin("fabric-loom")) {
-            the<JavaPluginExtension>().setSourceCompatibility("1.8")
-            the<JavaPluginExtension>().setTargetCompatibility("1.8")
+            the<JavaPluginExtension>().setSourceCompatibility("17")
+            the<JavaPluginExtension>().setTargetCompatibility("17")
         }
     }
 }

common/src/main/java/me/confuser/banmanager/webenhancer/common/listeners/CommonPlayerDeniedListener.java

@@ -13,11 +13,11 @@ public CommonPlayerDeniedListener(WebEnhancerPlugin plugin) {
   }
 
   public void handlePin(PlayerData player, Message message) {
-    if (!message.toString().contains("[pin]")) return;
+    String template = message.getRawTemplate();
+    if (template == null || !template.contains("<pin>")) return;
 
     PlayerPinData pin = plugin.getPlayerPinStorage().getValidPin(player);
 
-
     if (pin != null) {
       message.set("pin", String.valueOf(pin.getGeneratedPin()));
     }

common/src/main/resources/messages.yml

@@ -1,5 +1,8 @@
+# Message templates use MiniMessage formatting: https://docs.advntr.dev/minimessage/format.html
+# Placeholders use angle brackets, e.g. <pin>, <expires>, <seconds>
+
 messages:
   pin:
-    notify: '&6Your pin expires in [expires]'
-    pin: '[pin]'
-    rateLimited: '&cPlease wait [seconds] seconds before generating a new pin'
+    notify: '<gold>Your pin expires in <expires>'
+    pin: '<pin>'
+    rateLimited: '<red>Please wait <seconds> seconds before generating a new pin'

common/src/test/java/me/confuser/banmanager/webenhancer/common/listeners/CommonPlayerDeniedListenerTest.java

@@ -39,13 +39,11 @@ public void setUp() {
 
     @Test
     public void handlePin_replacesPlaceholderWithPin() {
-        // Setup
         when(playerPinStorage.getValidPin(player)).thenReturn(pinData);
         when(pinData.getGeneratedPin()).thenReturn(123456);
 
-        // Create a mocked message with [pin] placeholder
         Message message = mock(Message.class);
-        when(message.toString()).thenReturn("Your login pin is: [pin]");
+        when(message.getRawTemplate()).thenReturn("Your login pin is: <pin>");
 
         listener.handlePin(player, message);
 
@@ -54,9 +52,19 @@ public void handlePin_replacesPlaceholderWithPin() {
 
     @Test
     public void handlePin_ignoresMessagesWithoutPlaceholder() {
-        // Create a mocked message without [pin] placeholder
         Message message = mock(Message.class);
-        when(message.toString()).thenReturn("You have been banned!");
+        when(message.getRawTemplate()).thenReturn("You have been banned!");
+
+        listener.handlePin(player, message);
+
+        verify(playerPinStorage, never()).getValidPin(any());
+        verify(message, never()).set(anyString(), anyString());
+    }
+
+    @Test
+    public void handlePin_ignoresMessagesWithNullTemplate() {
+        Message message = mock(Message.class);
+        when(message.getRawTemplate()).thenReturn(null);
 
         listener.handlePin(player, message);
 
@@ -66,12 +74,10 @@ public void handlePin_ignoresMessagesWithoutPlaceholder() {
 
     @Test
     public void handlePin_handlesNullPinGracefully() {
-        // Setup - getValidPin returns null
         when(playerPinStorage.getValidPin(player)).thenReturn(null);
 
-        // Create a mocked message with [pin] placeholder
         Message message = mock(Message.class);
-        when(message.toString()).thenReturn("Your login pin is: [pin]");
+        when(message.getRawTemplate()).thenReturn("Your login pin is: <pin>");
 
         listener.handlePin(player, message);
 

e2e/build.gradle.kts

@@ -47,14 +47,6 @@ tasks.register<Copy>("copyBanManagerSpongeJar") {
     from(file("${banManagerDir.absolutePath}/sponge/build/libs/BanManagerSponge.jar"))
 }
 
-tasks.register<Copy>("copyBanManagerSponge7Jar") {
-    group = "verification"
-    description = "Copy BanManager Sponge7 shadow JAR to e2e/jars"
-
-    into(file("jars"))
-    from(file("${banManagerDir.absolutePath}/sponge-api7/build/libs/BanManagerSponge7.jar"))
-}
-
 tasks.register<Copy>("copyWebEnhancerBukkitJar") {
     group = "verification"
     description = "Copy WebEnhancer Bukkit JAR to e2e/jars"
@@ -98,18 +90,6 @@ tasks.register<Copy>("copyWebEnhancerSpongeJar") {
     }
 }
 
-tasks.register<Copy>("copyWebEnhancerSponge7Jar") {
-    group = "verification"
-    description = "Copy WebEnhancer Sponge7 JAR to e2e/jars"
-
-    dependsOn(":BanManagerWebEnhancerSponge7:shadowJar")
-
-    into(file("jars"))
-    from(project(":BanManagerWebEnhancerSponge7").tasks.named("shadowJar")) {
-        rename { "BanManagerWebEnhancerSponge7.jar" }
-    }
-}
-
 // Velocity JAR copy tasks
 tasks.register<Copy>("copyBanManagerVelocityJar") {
     group = "verification"
@@ -314,20 +294,6 @@ tasks.register("testSpongeAll") {
     }
 }
 
-// Sponge7 (Legacy API 7 / MC 1.12.2) E2E tests
-tasks.register("prepareSponge7Jars") {
-    group = "verification"
-    description = "Prepare Sponge7 (legacy) plugin JARs for E2E tests"
-    dependsOn("copyBanManagerSponge7Jar", "copyWebEnhancerSponge7Jar")
-}
-
-createPlatformTestTask(
-    "testSponge7",
-    "sponge7",
-    "prepareSponge7Jars",
-    "Run Sponge7 (legacy API 7 / MC 1.12.2) E2E tests in Docker"
-)
-
 // Velocity E2E tests
 tasks.register("prepareVelocityJars") {
     group = "verification"
@@ -543,34 +509,6 @@ tasks.register<Exec>("logsSponge") {
     commandLine("docker", "compose", "logs", "-f", "sponge")
 }
 
-// Sponge7 debug tasks
-tasks.register<Exec>("startSponge7") {
-    group = "verification"
-    description = "Start the Sponge7 (legacy) test server without running tests (for debugging)"
-
-    dependsOn("prepareSponge7Jars")
-
-    workingDir = file("platforms/sponge7")
-    commandLine("docker", "compose", "up", "-d", "mariadb", "sponge7")
-}
-
-tasks.register<Exec>("stopSponge7") {
-    group = "verification"
-    description = "Stop the Sponge7 test server"
-
-    workingDir = file("platforms/sponge7")
-    commandLine("docker", "compose", "down", "-v")
-    isIgnoreExitValue = true
-}
-
-tasks.register<Exec>("logsSponge7") {
-    group = "verification"
-    description = "Show Sponge7 server logs"
-
-    workingDir = file("platforms/sponge7")
-    commandLine("docker", "compose", "logs", "-f", "sponge7")
-}
-
 // Velocity debug tasks
 tasks.register<Exec>("startVelocity") {
     group = "verification"
@@ -629,7 +567,7 @@ tasks.register<Exec>("logsBungee") {
 
 tasks.named("clean") {
     doLast {
-        listOf("bukkit", "fabric", "sponge", "sponge7", "velocity", "bungee").forEach { platform ->
+        listOf("bukkit", "fabric", "sponge", "velocity", "bungee").forEach { platform ->
             ProcessBuilder("docker", "compose", "down", "-v", "--rmi", "local")
                 .directory(file("platforms/$platform"))
                 .inheritIO()

e2e/platforms/bukkit/configs/banmanager-webenhancer/messages.yml

@@ -1,5 +1,5 @@
 messages:
   pin:
-    notify: '&6Your pin expires in [expires]'
-    pin: '[pin]'
-
+    notify: '<gold>Your pin expires in <expires>'
+    pin: '<pin>'
+    rateLimited: '<red>Please wait <seconds> seconds before generating a new pin'