Skip to content

main fails mix format --check-formatted (one test file), so precommit and quality.ci are red on a clean checkout #767

Description

@timujinne

main currently fails its own mix format --check-formatted, so mix precommit and quality.ci are red on a clean checkout — for anyone, not just for us.

Reproduction

Revision 3d6c941d52 (main after #762#766), clean detached checkout, dependencies installed from scratch:

mix deps.get && mix format --check-formatted

Exit code 1:

** (Mix) mix format failed due to --check-formatted.
The following files are not formatted:

test/mix/tasks/phoenix_kit_doctor_test.exs
534 534  |      assert {[{"t", "c", "r", 5, :existing_orphan}, ...
535     -|              [{"t2", "c2", "r2"}], [{"t3", "c3", "r3", ...}]} =
    535 +|              [{"t2", "c2", "r2"}],
    536 +|              [{"t3", "c3", "r3", :orphan_count, "x", nil}]} =
536 537  |               DoctorTask.classify_fk_check(...)

Elixir 1.18.4.

The fix is two lines

One assertion needs the formatter's line break. We have carried that exact change in our fork since 26 Aug as a format-only commit — no logic touched, one file, +2/−1. Say the word and we will send it as a PR; it is small enough that you may prefer to apply it directly.

What we did not check

Only mix format --check-formatted was run. Whether the full precommit is red for any other reason as well, we did not look at and are not claiming.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions