From d8fe11b6a040261ce09f92b725a222b861f4c721 Mon Sep 17 00:00:00 2001 From: timujeen Date: Mon, 16 Mar 2026 09:55:32 +0000 Subject: [PATCH] Fix test and worker guard after Newsletters extraction - Remove PhoenixKit.Modules.Newsletters from @all_internal_modules in module_test.exs (module deleted from core, extracted to separate package) - Update describe block count from 21 to 20 modules - Add function_exported? guard for process_scheduled_broadcasts/0 in ProcessScheduledJobsWorker to prevent crash on version mismatch --- .../scheduled_jobs/workers/process_scheduled_jobs_worker.ex | 1 + test/phoenix_kit/module_test.exs | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/phoenix_kit/scheduled_jobs/workers/process_scheduled_jobs_worker.ex b/lib/phoenix_kit/scheduled_jobs/workers/process_scheduled_jobs_worker.ex index a35ac84fb..966b3d5c1 100644 --- a/lib/phoenix_kit/scheduled_jobs/workers/process_scheduled_jobs_worker.ex +++ b/lib/phoenix_kit/scheduled_jobs/workers/process_scheduled_jobs_worker.ex @@ -78,6 +78,7 @@ defmodule PhoenixKit.ScheduledJobs.Workers.ProcessScheduledJobsWorker do if newsletters_mod && Code.ensure_loaded?(newsletters_mod) && function_exported?(newsletters_mod, :enabled?, 0) && + function_exported?(newsletters_mod, :process_scheduled_broadcasts, 0) && newsletters_mod.enabled?() do {:ok, newsletters_count} = newsletters_mod.process_scheduled_broadcasts() diff --git a/test/phoenix_kit/module_test.exs b/test/phoenix_kit/module_test.exs index 01f43f22b..7c17a5ea4 100644 --- a/test/phoenix_kit/module_test.exs +++ b/test/phoenix_kit/module_test.exs @@ -24,7 +24,6 @@ defmodule PhoenixKit.ModuleTest do PhoenixKit.Modules.Storage, PhoenixKit.Modules.Sync, PhoenixKit.Modules.CustomerService, - PhoenixKit.Modules.Newsletters, PhoenixKit.Jobs ] @@ -35,7 +34,7 @@ defmodule PhoenixKit.ModuleTest do :ok end - describe "all 21 modules implement PhoenixKit.Module behaviour" do + describe "all 20 modules implement PhoenixKit.Module behaviour" do test "all modules are loadable" do for mod <- @all_internal_modules do assert Code.ensure_loaded?(mod), "#{inspect(mod)} should be loadable"