Skip to content

Item selector: is a comfy density mode wanted in the new resolver, and how should it relate to per-user view prefs? #92

Description

@timujinne

After #88 and #89 landed, the item selector and its view handling look quite different from what our branch was built on, so we would rather ask than guess.

What we have. On a branch cut before #88, we added a third density mode — comfy — to the item selector: three explicit buttons (card / comfy / table) and a CSS hook ([.pk-comfy_&]:…) on the selector rows. It is implemented and covered by tests (mutation-proven, revision c2bd915 on our branch).

Why we stopped. #88 reworked the selector and introduced the new resolver; #89 added per-user view preferences. Porting our work onto the current main means rewriting it against code that just moved, and we would rather not do that in a direction you do not want.

Two questions:

  1. Do you want a comfy density mode in the new resolver at all? A "no" is a perfectly good answer — we will drop it rather than carry it.

  2. If yes: should density be a separate per-user preference alongside the view mode from Item selector rework: admin parity, new defaults, per-user memory #89, or a variant of the view mode itself? The two shape the data model differently, and Item selector rework: admin parity, new defaults, per-user memory #89 is yours, so the call is yours.

We are not starting the port until we hear back. Happy to open a PR against current main once the direction is clear.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions