You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After #88 and #89 landed, the item selector and its view handling look quite different from what our branch was built on, so we would rather ask than guess.
What we have. On a branch cut before#88, we added a third density mode — comfy — to the item selector: three explicit buttons (card / comfy / table) and a CSS hook ([.pk-comfy_&]:…) on the selector rows. It is implemented and covered by tests (mutation-proven, revision c2bd915 on our branch).
Why we stopped.#88 reworked the selector and introduced the new resolver; #89 added per-user view preferences. Porting our work onto the current main means rewriting it against code that just moved, and we would rather not do that in a direction you do not want.
Two questions:
Do you want a comfy density mode in the new resolver at all? A "no" is a perfectly good answer — we will drop it rather than carry it.
After #88 and #89 landed, the item selector and its view handling look quite different from what our branch was built on, so we would rather ask than guess.
What we have. On a branch cut before #88, we added a third density mode —
comfy— to the item selector: three explicit buttons (card/comfy/table) and a CSS hook ([.pk-comfy_&]:…) on the selector rows. It is implemented and covered by tests (mutation-proven, revisionc2bd915on our branch).Why we stopped. #88 reworked the selector and introduced the new resolver; #89 added per-user view preferences. Porting our work onto the current
mainmeans rewriting it against code that just moved, and we would rather not do that in a direction you do not want.Two questions:
Do you want a
comfydensity mode in the new resolver at all? A "no" is a perfectly good answer — we will drop it rather than carry it.If yes: should density be a separate per-user preference alongside the view mode from Item selector rework: admin parity, new defaults, per-user memory #89, or a variant of the view mode itself? The two shape the data model differently, and Item selector rework: admin parity, new defaults, per-user memory #89 is yours, so the call is yours.
We are not starting the port until we hear back. Happy to open a PR against current
mainonce the direction is clear.