Skip to content

Commit f43a5bb

Browse files
ivanbarlogclaude
andcommitted
fix: add Node 24 setup to release job to replace runner's pre-installed Node 20
The release job only installs bun but has no setup-node step, so jsii falls back to the runner's pre-installed Node 20 (EOL April 2026). Insert actions/setup-node@v6 with node-version 24 before the bun setup step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent ad445dc commit f43a5bb

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.projenrc.ts

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,22 @@ const project = new awscdk.AwsCdkConstructLibrary({
4040
vscode: false,
4141
});
4242

43-
// publib's NPM_TRUSTED_PUBLISHER skips its own token check but doesn't write
44-
// npm auth — fetch the GitHub OIDC token and write it to .npmrc before publib runs.
4543
const releaseWorkflow = project.tryFindObjectFile(
4644
".github/workflows/release.yml",
4745
);
4846
if (releaseWorkflow) {
47+
// The release job uses bun but has no setup-node, so jsii falls back to the
48+
// runner's pre-installed Node 20. Insert Node 24 setup before bun setup.
49+
releaseWorkflow.patch(
50+
JsonPatch.add("/jobs/release/steps/2", {
51+
name: "Setup Node.js",
52+
uses: "actions/setup-node@v6",
53+
with: { "node-version": "24" },
54+
}),
55+
);
56+
57+
// publib's NPM_TRUSTED_PUBLISHER skips its own token check but doesn't write
58+
// npm auth — fetch the GitHub OIDC token and write it to .npmrc before publib runs.
4959
releaseWorkflow.patch(
5060
JsonPatch.replace(
5161
"/jobs/release_npm/steps/10/run",

0 commit comments

Comments
 (0)