Auto detect VRChat install path

[DeltaNeverUsed]

We could use steam's libraryfolders.vdf to detect the installation path of VRChat instead of prompting the users, so the process would be

1. Find libraryfolders.vdf
   • I'm fairly sure it's always in ~/.steam/steam/steamapps/libraryfolders.vdf, but not totally sure
2. Parse it, and find VRChat's SteamID of 438100
   • I don't think we necessarily have to even properly parse it, we could just match for "438100", then find "path" on the first line before that and then find the next pair of quotes after that, and we'd have the path to that library folder
3. And append steamapps/common/VRChat/VRChat.exe to said library path

One thing I'm uncertain about is, should we still keep the manual selection just in case?
And if so how should we do that?

Maybe we could just see if the current path is invalid and if it then try and get the path using this method?

[hypevhs]

Some distros have the steam root in a really odd location... you may need to also check ~/.steam/debian-installation and ~/.local/share/{S,s}team.
This issue has more info: https://gitlab.com/gabmus/envision/-/work_items/249
If you get this part working, the editable path should IMO only be shown if it can't find vrchat.exe.

[hypevhs]

Right now, if you do not have either the Proton-python-path or the VRChat-exe-path set, then switch to the ProtonTricks mode, it will not work because it complains that the Proton-python-path is unset, even though that control is now hidden.
It also requires you to reload domain if you installed protontricks after launching unity.

But I think ideally the protontricks mode would not need to exist at all, if we could just read the VDF files better.

We can do something like how VRCX does it:
https://github.com/vrcx-team/VRCX/blob/4ca7190169a2dece8998003ad34eb6572b8700cc/Dotnet/AppApi/Electron/RegistryPlayerPrefs.cs#L44

[DeltaNeverUsed]

Some distros have the steam root in a really odd location... you may need to also check ~/.steam/debian-installation and ~/.local/share/{S,s}team.

I believe this is an issue currently then...

LinuxVRChatSDKPatch/Packages/befuddledlabs.linuxvrchatsdkpatch.worlds/Editor/World.cs

Line 99 in 5198f93

{ "STEAM_COMPAT_CLIENT_INSTALL_PATH", Environment.GetEnvironmentVariable("HOME") + "/.steam/" }

Right now, if you do not have either the Proton-python-path or the VRChat-exe-path set, then switch to the ProtonTricks mode, it will not work because it complains that the Proton-python-path is unset, even though that control is now hidden.

Not sure how I missed that...

But I think ideally the protontricks mode would not need to exist at all, if we could just read the VDF files better.

I do agree with that, that was also kinda what I thought after making this issue

We can do something like how VRCX does it:
https://github.com/vrcx-team/VRCX/blob/4ca7190169a2dece8998003ad34eb6572b8700cc/Dotnet/AppApi/Electron/RegistryPlayerPrefs.cs#L44

The way they're finding the steam path doesn't seem great either IMO

[hypevhs]

We could try to pull in https://github.com/ValveResourceFormat/ValveKeyValue as a C# dependency to parse VDFs the "right" way, but I think half of projects just parse it as text.

• VRCX finds the steam-path: Folders.cs#L24
• VRCX finds the proton-path, with regex: RegistryPlayerPrefs.cs#L44
• ProtonPlus finds the steam-path: steam.vala#L11-L24
  • it also double-checks by looking for some dlls known to be in the root: launcher.vala#L28
• ProtonPlus finds the proton-path, with a frankly terrifying barrage of substrings: steam.vala#L244

I think we can consider flatpak/snap Steam out-of-scope for now 😅

[DeltaNeverUsed]

I do think https://github.com/ValveResourceFormat/ValveKeyValue would be overkill, and I think making a simplistic parse would be "better" rather than having to deal with dependencies

But I suppose doing the same as what ProtonPlus/VRCX does would be best
I do prefer the way ProtonPlus does to VRCX's implementation, ignoring the terrifying thing for finding the proton-path

And I would very much lean on flatpak/snap being out-of-scope as I've never once touched them, and would prefer not to, however if anyone legitimately needs it then it would be worth at least looking into