From 57550a33e4735e449980c6ea67c0627c7040c79b Mon Sep 17 00:00:00 2001 From: citymarkm Date: Mon, 4 Sep 2017 13:48:41 +0100 Subject: [PATCH 1/3] Update capabilities supported by BrowserStack real device automation and popup controls See https://www.browserstack.com/automate/behat --- .../ServiceContainer/Driver/BrowserStackFactory.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php index 66aa3fa7..fb9f57da 100644 --- a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php +++ b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php @@ -63,6 +63,9 @@ protected function getCapabilitiesNode() ->booleanNode('browserstack-tunnel')->end() ->booleanNode('emulator')->end() ->booleanNode('acceptSslCert')->end() + ->scalarNode('realMobile')->end() // Support latest Browser Stack Funcitionality + ->booleanNode('browserstack-ie-enablePopups')->end() // Support latest Browser Stack Funcitionality + ->booleanNode('browserstack-safari-enablePopups')->end() // Support latest Browser Stack Funcitionality ->end() ; From 6af069ddd0b5217dde4a3eb2599053ca4ac2b4a3 Mon Sep 17 00:00:00 2001 From: citymarkm Date: Mon, 4 Sep 2017 16:01:15 +0100 Subject: [PATCH 2/3] Update BrowserStackFactory.php --- .../ServiceContainer/Driver/BrowserStackFactory.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php index fb9f57da..f811cd61 100644 --- a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php +++ b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php @@ -63,9 +63,9 @@ protected function getCapabilitiesNode() ->booleanNode('browserstack-tunnel')->end() ->booleanNode('emulator')->end() ->booleanNode('acceptSslCert')->end() - ->scalarNode('realMobile')->end() // Support latest Browser Stack Funcitionality - ->booleanNode('browserstack-ie-enablePopups')->end() // Support latest Browser Stack Funcitionality - ->booleanNode('browserstack-safari-enablePopups')->end() // Support latest Browser Stack Funcitionality + ->scalarNode('realMobile')->end() + ->booleanNode('browserstack-ie-enablePopups')->end() + ->booleanNode('browserstack-safari-enablePopups')->end() ->end() ; From a16b230438f7cd39d185ea2c15e0bc389c9694d2 Mon Sep 17 00:00:00 2001 From: citymarkm Date: Thu, 14 Sep 2017 17:43:48 +0100 Subject: [PATCH 3/3] Added "browser_version" parameter --- .../ServiceContainer/Driver/BrowserStackFactory.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php index f811cd61..3138e612 100644 --- a/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php +++ b/src/Behat/MinkExtension/ServiceContainer/Driver/BrowserStackFactory.php @@ -58,6 +58,7 @@ protected function getCapabilitiesNode() ->scalarNode('build')->info('will be set automatically based on the TRAVIS_JOB_NUMBER environment variable if available')->end() ->scalarNode('os')->end() ->scalarNode('os_version')->end() + ->scalarNode('browser_version')->end() ->scalarNode('device')->end() ->booleanNode('browserstack-debug')->end() ->booleanNode('browserstack-tunnel')->end()