Broken ParaView export for DiffusionGrid #285
Description
Description
Exporting the DiffusionGrid to ParaView leads to unexpected behavior, e.g. I see empty slices, sometimes filled with more or less random data. See images (yet to follow).
Work Log
- Identified that the ParaView export works fine for certain combinations of
DiffusionGrid::resolutionandOMP_NUM_THREADS. For others it did not work as expected. E.g.resolution = 20did work well for 4 threads but did not work for 8 threads. - @Senui observed the same problem and verified on macOS i386
- The current setup always exports a certain number of slices
1 .. N, the error always appears for the first layer of slideN. - Double checked the entire export pipe line could not find an error.
- Test case
resolution = 20with 4 and 8 threads. 4 threads export 4 * 5 slices. 8 threads export (5*3 + 5), e.g. the last slice should be equivalent. Thedifftool shows no difference between the sliceN=4andN=6for 4 and 8 threads respectively. - Restructured export in a hopefully more load balanced way using all threads if possible, ⭐ current believe: fixes the problem (:zap: Test fail, not sure if important or why)
To Reproduce
Simply have a diffusion grid and export to PV. Choose resolution%num_threads!=0.
Reproducer to follow.
Expected behavior
No empty space.
Setup (please complete the following information):
- OS: macOS (i386, arm64); Linux (not clear yet)
- BioDynaMo version v1.05.0-137fdb15