Skip to content

Harden fee-router payout logic and collector rotation safeguards #537

Description

@grantfox-oss

Strengthen payout routing so fee distribution, collector rotation, and edge-case splits remain deterministic and cannot silently under- or over-allocate fee flows.

  • Affected files: app/contract/contracts/Folder/src/fee_router.rs, app/contract/contracts/Folder/src/fee_router_test.rs, app/contract/contracts/Folder/src/fee.rs, app/contract/contracts/Folder/src/admin.rs, app/contract/contracts/Folder/src/storage.rs, app/contract/contracts/Folder/src/types.rs, app/contract/contracts/Folder/src/lib.rs, app/contract/docs/FEE_CONFIGURATION_GUIDE.md
  • Acceptance criteria:
    • Fee allocation logic preserves the configured priority order without divergence between collector, platform, and arbiter paths.
    • Invalid or partially configured fee splits are rejected or handled safely instead of producing hidden drift.
    • Unit tests cover edge cases for fee ratios, collector rotation, and zero-or-negative payout values.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third CampaignbugSomething isn't workingenhancementNew feature or requestgood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions