Skip to content

Optimize race condition prevention delay from 1-4s to 0.5-1.5s range #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BorDevTech merged 2 commits into from
Sep 22, 2025
Merged

Optimize race condition prevention delay from 1-4s to 0.5-1.5s range #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef2a9fe
Initial plan
Copilot Sep 22, 2025
580eef7
Optimize race condition delay from 1-4s to 0.5-1.5s range
Copilot Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/lint-automation/github-issue-creator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,8 +348,8 @@ class GitHubIssueCreator {
}

// Add race condition protection: wait a random delay to prevent simultaneous creation
const delay = Math.floor(Math.random() * 3000) + 1000; // 1-4 seconds
console.log(`🕐 Waiting ${Math.round(delay/1000)}s to prevent race conditions...`);
const delay = Math.floor(Math.random() * 1000) + 500; // 0.5-1.5 seconds
console.log(`🕐 Waiting ${Math.round(delay/1000 * 10) / 10}s to prevent race conditions...`);
Copy link

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The expression Math.round(delay/1000 * 10) / 10 is a complex magic number calculation. Consider extracting this to a helper function like formatDelaySeconds(delay) or using (delay/1000).toFixed(1) for better readability.

Suggested change
console.log(`🕐 Waiting ${Math.round(delay/1000 * 10) / 10}s to prevent race conditions...`);
console.log(`🕐 Waiting ${(delay/1000).toFixed(1)}s to prevent race conditions...`);

Copilot uses AI. Check for mistakes.
await new Promise(resolve => setTimeout(resolve, delay));

// Final check for existing issues after delay (race condition protection)
Expand Down