Skip to content

fix: skip updating on zoom if unrelated fields #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NagariaHussain merged 2 commits into from
Feb 18, 2026
Merged

fix: skip updating on zoom if unrelated fields #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bad5cbb
fix: skip updating on zoom if unrelated fields
vishwajeet-13 Feb 18, 2026
c52db30
chore: remove breakpoint
vishwajeet-13 Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion zoom_integration/zoom_integration/doctype/zoom_webinar/zoom_webinar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from frappe.integrations.utils import create_request_log
from frappe.model.document import Document
from frappe.utils import cint, format_datetime
from frappe.utils.data import convert_utc_to_timezone, get_datetime
from frappe.utils.data import convert_utc_to_timezone, get_datetime, get_time

from zoom_integration.utils import ZOOM_API_BASE_PATH, get_authenticated_headers_for_zoom

Expand Down Expand Up @@ -101,6 +101,26 @@ def update_webinar_on_zoom_if_applicable(self):
if self.flags.in_import or self.flags.in_migration:
return # Skip updates during import or migration

if self.is_new():
return

before_save = self.get_doc_before_save()

current_start = get_time(self.get("start_time"))
previous_start = get_time(before_save.get("start_time"))
current_date = self.get("date")
previous_date = str(before_save.get("date"))

zoom_related_field_not_updated = (
self.title == before_save.title
and self.agenda == before_save.agenda
and self.duration == before_save.duration
and current_date == previous_date
and current_start == previous_start
)
if zoom_related_field_not_updated:
return

# For simplicity, we will only update the title and agenda in this example.
url = f"{ZOOM_API_BASE_PATH}/webinars/{self.zoom_webinar_id}"
headers = get_authenticated_headers_for_zoom()
Expand Down