-
Notifications
You must be signed in to change notification settings - Fork 6
Description
The "default" in gr3 section is a mixed blessing. On the plus side, it is fast and allows very simple gr3 files in one line.
On the other hand it causes all the usual issues of silent failure. In the present case:
It appears we do not check well whether nodes are populated. For instance, an incomplete polygon coverage with no default should be an error. In the case of windfactor.yaml, I think 1.0 is a reasonable default and (importantly) it would be equally reasonable on the ocean, in a niche expanded wetland in Suisun and in a sea level rise accommodation space upstream on the Sac. But ... I don't see a default defined in that file. I think this should give a ValueError. It will bug someone once, but not twice.
We could conceivably have some sort of checker/reporter for polygon coverage. It could be launched as long as some form of the mesh (2dm, gr3) were available, and it would report, for each gr3, the number of nodes 1) filled from poly 2) filled from default 3) missed. If 392,000 nodes are filled from polygons and 1,412 are not ... it is probably not a deliberate use of "default".