From 2b81e26f504a1947fe975b40f979bf0633e99157 Mon Sep 17 00:00:00 2001 From: Tom Wagg Date: Wed, 18 Feb 2026 17:42:22 -0500 Subject: [PATCH 1/2] ensure CO core mass is updated when surpassing mcmax --- src/cosmic/src/hrdiag.f | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cosmic/src/hrdiag.f b/src/cosmic/src/hrdiag.f index 08eddb509..5b5e1deec 100644 --- a/src/cosmic/src/hrdiag.f +++ b/src/cosmic/src/hrdiag.f @@ -493,7 +493,10 @@ SUBROUTINE hrdiag(mass,aj,mt,tm,tn,tscls,lums,GB,zpars, * if(mcmax-mcx.lt.tiny)then aj = 0.d0 + + ! adjust core masses in case we overshot the maximum allowed core mass mc = mcmax + mc_co(kidx) = mc call assign_remnant(zpars,mc,mcbagb,mass, & kidx,mt,kw,bhspin) endif From 78f87a75548bd6d283af752f0a0e6d363ec19e8b Mon Sep 17 00:00:00 2001 From: Tom Wagg Date: Wed, 18 Feb 2026 17:47:42 -0500 Subject: [PATCH 2/2] smush 3.7.3 into 3.7.2 --- changelog.md | 10 +++------- src/cosmic/_version.py | 2 +- src/cosmic/data/cosmic-settings.json | 2 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/changelog.md b/changelog.md index a01f15ef8..dcf95f2fb 100644 --- a/changelog.md +++ b/changelog.md @@ -78,7 +78,7 @@ See the discussed changes in our previous releases here: https://github.com/COSM - Bug fix [[#724](https://github.com/COSMIC-PopSynth/COSMIC/issues/724)]: remove bug where ``kstar=15`` was assigned its previous epoch mass after merging during a CE and the merger product goes SN ## 3.7.2 -This release contains _several_ fixes to how CO core masses/remnant masses are handled. It also adds a new PISN prescription and windflag. +This release contains _several_ fixes to how CO core masses/remnant masses are handled. It also adds a new PISN prescription, windflag and LBV winds flag. - Fixes: - Update ``mc_co`` and ``mc_he`` after adjusting ``mc = mcmax`` in ``hrdiag.f`` for stripped stars. This can be a fairly significant change, up to ~2 Msun. (Used to actually be up to 10 Msun because we added HeMS core mass growth) @@ -95,6 +95,8 @@ This release contains _several_ fixes to how CO core masses/remnant masses are h - Added a ``windflag = -1`` option to turn off stellar winds entirely - Added ``pisn = -4`` for Renzo+22/Hendriks+23 prescription for PPISN mass loss - With options ``ppi_co_shift`` and ``ppi_extral_ml`` + - Add new setting ``LBV_flag`` which allows one to turn off LBV winds, use Hurley+2000, or use Belcyznski+2008 + - Change the default LBV winds to Hurley - Code cleanup: - ``assign_remnant`` no longer takes ``mc_tot`` as a parameter, just get it from the common block @@ -103,12 +105,6 @@ This release contains _several_ fixes to how CO core masses/remnant masses are h - Got rid of ``mcx`` in ``assign_remnant`` in favour of clearer ``m_proto`` and ``m_FeNi`` to match the papers - [Very minor] Fryer Rapid was using <= instead of < everywhere - -## 3.7.3 -- Additions/changes: - - Add new setting ``LBV_flag`` which allows one to turn off LBV winds, use Hurley+2000, or use Belcyznski+2008 - - Change the default LBV winds to Hurley - - Documentation: - Start new settings gallery in the documentation - Tag settings/options with the version they were added in the docs page and auto link them to release \ No newline at end of file diff --git a/src/cosmic/_version.py b/src/cosmic/_version.py index 221485aea..3bdbbae2e 100644 --- a/src/cosmic/_version.py +++ b/src/cosmic/_version.py @@ -1 +1 @@ -__version__ = "3.7.3" +__version__ = "3.7.2" diff --git a/src/cosmic/data/cosmic-settings.json b/src/cosmic/data/cosmic-settings.json index 8804a45ff..5ed302d96 100644 --- a/src/cosmic/data/cosmic-settings.json +++ b/src/cosmic/data/cosmic-settings.json @@ -694,7 +694,7 @@ "description": "Selects the model for Luminous Blue Variable (LBV) mass loss", "type": "dropdown", "options-preface": "", - "version_added": "3.7.3", + "version_added": "3.7.2", "options": [ { "name": 0,