[Bug] Incorrect migration is generated

[iikuzmychov]

Let's say we have the next models:

public class Vacancy
{
    public required Guid Id { get; set; }
    public required VacancyOrigin Origin { get; set; }
}

[ComplexType]
public record VacancyOrigin
{
    public required VacancySource Source { get; init; }
    public required string ExternalId { get; init; }
}

public enum VacancySource
{
    Source1,
    Source2,
    Source3
}

and the next configurations:

internal sealed class VacancyConfiguration : IEntityTypeConfiguration<Vacancy>
{
    public void Configure(EntityTypeBuilder<Vacancy> builder)
    {
        builder.HasComplexCompositeIndex(
            vacancy => new { vacancy.Origin.Source, vacancy.Origin.ExternalId },
            isUnique: true);
    }
}

This is a result of dotnet ef migrations add ...:

public partial class AddUniqueIndexOnVacancySourceAndExternalId : Migration
{
    /// <inheritdoc />
    protected override void Up(MigrationBuilder migrationBuilder)
    {
        migrationBuilder.CreateIndex(
            name: "IX_Vacancies_Source_ExternalId",
            table: "Vacancies",
            columns: new[] { "Source", "ExternalId" },
            unique: true);
    }

    /// <inheritdoc />
    protected override void Down(MigrationBuilder migrationBuilder)
    {
        migrationBuilder.DropIndex(
            name: "IX_Vacancies_Source_ExternalId",
            table: "Vacancies");
    }
}

This migration is wrong because of incorrect column names. The columns parameter should be the next:

columns: new[] { "Origin_Source", "Origin_ExternalId" },

[mario-mestrovic]

@iikuzmychov

Got frustrated by this but found a workaround.
If you name the column explicitly it works!

Just need to call HasColumnName("Origin_Source") when defining complex property source. Example:

entity.ComplexProperty(p => p.Origin, b =>
  {
      b.Property(x => x.Source)
          .HasColumnName("Origin_Source");
  });

So a package which is a EF Core workaround needs a workaround :D

It also doesnt work with Database.EnsureCreated. It just ignores this setup. My primary reason for trying was that use case (Dont want running migrations when running tests, so I use EnsureCreated for tests)

[iikuzmychov]

@mario-mestrovic haha, nice, thanks for the tip!