Verify: read-only upstream sync fields when webhook-driven

[JohnRDOrazio]

Context

Commit 57435cb (with companion backend commit 3800304 on ontokit-api) introduced automatic upstream sync configuration when GitHub webhooks are enabled.

What was added

Backend (ontokit-api 3800304):

• When webhooks are enabled on a GitHub integration, an UpstreamSyncConfig is automatically created (or updated) with frequency="webhook", using the integration's repo_owner, repo_name, default_branch, and ontology_file_path. This eliminates the need for users to manually fill out the Upstream Source Tracking form with the same information.
• When webhooks are disabled, the upstream sync frequency is downgraded from "webhook" to "manual" (the config is preserved so the user's update_mode preference is kept).

Frontend (ontokit-web 57435cb):

• In the configured (non-editing) view: a note reading "Automatically triggered by GitHub webhooks" appears below the frequency label when the config is webhook-driven.
• In the editing form: the repo owner, repo name, branch, and file path fields become read-only with dimmed styling and a note "Repository fields are managed by the GitHub integration." These values are derived from the GitHub integration and shouldn't be edited independently.
• The frequency dropdown and update mode remain fully editable.

Test checklist

• Enable webhooks on a GitHub integration → verify an upstream sync config is auto-created with frequency="webhook"
• Check the Upstream Source Tracking section shows "Automatically triggered by GitHub webhooks"
• Click "Edit" on the upstream sync config → verify repo owner, repo name, branch, and file path are read-only with dimmed styling
• Verify the explanatory note "Repository fields are managed by the GitHub integration" appears in the edit form
• Verify the frequency dropdown and update mode are still editable
• Disable webhooks on the integration → verify upstream sync frequency changes to "manual"
• If an upstream sync config already existed before enabling webhooks, verify it is updated (not duplicated)
• Create a new integration with webhooks enabled from the start → verify upstream sync config is created on save

[JohnRDOrazio]

Verification run — 8-item checklist

Verified by tracing the live code paths in both repos and running the backend unit tests. Note: the feature was renamed UpstreamSyncConfig → RemoteSyncConfig (method _sync_remote_config_for_webhooks) since this issue was filed — functionally identical to what's described here.

Backend (ontokit-api) — pull_request_service.py

#	Item	Verdict	Evidence
1	Enable webhooks → config auto-created frequency="webhook"	✅	_sync_remote_config_for_webhooks (svc:1154-1169); create path (1222) + update path (1268). Tests test_creates_sync_config_when_webhooks_enabled, test_update_integration_enable_webhooks — pass
6	Disable webhooks → frequency → "manual"	✅	svc:1170-1172 (only downgrades if it was webhook; config preserved, not deleted). Test test_updates_sync_config_when_webhooks_disabled — pass
7	Pre-existing config updated, not duplicated	✅	Single config per project via scalar_one_or_none (svc:1149-1152); update branch 1167-1169. Test test_updates_existing_config_when_webhooks_enabled — pass
8	New integration w/ webhooks from start → config on save	✅ logic / ⚠️ test gap	create_github_integration calls helper when webhooks_enabled (svc:1222). Helper is tested, but no dedicated test exercises the create route with webhooks_enabled=True (test_create_integration_success runs with it False). Logic correct; coverage missing.

pytest -k "SyncRemoteConfigForWebhooks or update_integration_enable_webhooks" → 4 passed.

Frontend (ontokit-web) — app/projects/[id]/settings/page.tsx

#	Item	Verdict	Evidence
2	Configured view shows "Automatically triggered by GitHub webhooks"	✅	line 2681-2685, gated on webhooks_enabled && frequency === "webhook"
3	Edit form repo fields read-only + dimmed	✅	all 4 inputs readOnly={isWebhookDriven} + opacity-60 (2893/2911/2949/2967); PR #148 adds matching label dimming
4	Note "Repository fields are managed by the GitHub integration."	✅	line 2925 (repositioned below both grids by #148)
5	Frequency + update mode still editable	✅	both <select>s (2985, 3009) have no disabled/readOnly tie to isWebhookDriven

Outstanding

• Item 8 test gap — add a create_github_integration(..., webhooks_enabled=True) test asserting the config is created.
• No frontend unit tests cover RemoteSyncSection / isWebhookDriven (items 2–5 verified by inspection only).
• A live browser smoke-test of items 2–5 against a real webhook-enabled integration would be the final manual confirmation, but the implementation is verified correct.

All 8 behaviors are implemented correctly. I'd suggest keeping this issue open only until the item-8 test is added, then closing.

[JohnRDOrazio]

Checklist marked complete. All 8 behaviors verified (see the detailed verification comment above); the one gap — item 8 having no automated test — was closed by ontokit-api#175, now merged to dev. Backend items 1/6/7/8 have passing unit tests; frontend items 2–5 verified by code inspection.

Leaving this open only until the related UI-polish PR #148 (which Refs #5) is resolved.