Skip to content

[Bug]: Tasks self.validate() is not actually run anywhere #73

@bernardusrendy

Description

@bernardusrendy

Current behavior

Currently tasks self.validate() is not really ran anywhere, neither at submission or during the task executions.

Expected Behavior

In principle, it should by default ran anytime run() is called because you want to validate all parameters before running the task.

During submission However, sometimes some attribute such as self.samples are not populated yet until the whole batch is ready (like in heating). So the validate() method should not be called during running. Otherwise we would need two base methods such as validate_run() and validate_submission()

Minimal example

No response

Relevant files/images/logs

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugnot't working as it should be

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions