From 96955f46604bec4d205b717b3c153fd7b8ddf818 Mon Sep 17 00:00:00 2001 From: Jonathan Irwin Date: Tue, 11 Aug 2026 23:47:26 -0400 Subject: [PATCH] fix(deploy): hide the upload step for partner service deploys Partner deploys go straight from create to build, but the deploy checklist still listed "Upload to Cerebrium" as a pending step while creating the app, so it showed a stage that never runs. Co-Authored-By: Claude Opus 5 (1M context) --- internal/ui/commands/deploy.go | 6 ++++-- internal/ui/commands/deploy_test.go | 20 ++++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/internal/ui/commands/deploy.go b/internal/ui/commands/deploy.go index ff2d561..09f6977 100644 --- a/internal/ui/commands/deploy.go +++ b/internal/ui/commands/deploy.go @@ -706,8 +706,10 @@ func (m *DeployView) View() string { case StateCreatingApp: output.WriteString(formatStateLine(m.spinner.View(), "Creating app...", ui.ActiveStyle.Render)) output.WriteString("\n") - output.WriteString(formatStateLine("-", "Upload to Cerebrium", ui.PendingStyle.Render)) - output.WriteString("\n") + if !m.isPartnerService() { + output.WriteString(formatStateLine("-", "Upload to Cerebrium", ui.PendingStyle.Render)) + output.WriteString("\n") + } output.WriteString(formatStateLine("-", "Build app", ui.PendingStyle.Render)) output.WriteString("\n") diff --git a/internal/ui/commands/deploy_test.go b/internal/ui/commands/deploy_test.go index 96258f0..6feb72b 100644 --- a/internal/ui/commands/deploy_test.go +++ b/internal/ui/commands/deploy_test.go @@ -1067,6 +1067,26 @@ func TestDeployView_View(t *testing.T) { view := model.View() assert.Contains(t, view, "Creating app") + assert.Contains(t, view, "Upload to Cerebrium") + }) + + t.Run("view during app creation omits upload step for partner services", func(t *testing.T) { + model := NewDeployView(t.Context(), DeployConfig{ + DisplayConfig: ui.DisplayConfig{ + IsInteractive: true, + DisableAnimation: false, + }, + Config: partnerConfig("partner-app"), + ProjectID: "test-project", + Client: apimock.NewMockClient(t), + }) + + model.state = StateCreatingApp + + view := model.View() + assert.Contains(t, view, "Creating app") + assert.Contains(t, view, "Build app") + assert.NotContains(t, view, "Upload to Cerebrium") }) t.Run("view during upload", func(t *testing.T) {