Problem
In src/middleware/auth.ts lines 16-32, the auth guard loads the user by decoded.sub (user ID) and sets authUser.stellarAddress from the database record. However, it never validates that decoded.stellarAddress (from the JWT) matches user.stellarAddress.
While JWT forgery is prevented by the secret, this means the stellarAddress claim in the JWT is effectively ignored. If the JWT signing key were ever compromised, an attacker could craft tokens for any user ID without the stellarAddress check providing any validation.
Fix
Validate decoded.stellarAddress === user.stellarAddress.
Severity
Low — defense-in-depth gap
Problem
In
src/middleware/auth.tslines 16-32, the auth guard loads the user bydecoded.sub(user ID) and setsauthUser.stellarAddressfrom the database record. However, it never validates thatdecoded.stellarAddress(from the JWT) matchesuser.stellarAddress.While JWT forgery is prevented by the secret, this means the
stellarAddressclaim in the JWT is effectively ignored. If the JWT signing key were ever compromised, an attacker could craft tokens for any user ID without thestellarAddresscheck providing any validation.Fix
Validate
decoded.stellarAddress === user.stellarAddress.Severity
Low — defense-in-depth gap